MIME-Version: 1.0
References: <20230307200502.2263655-1-grundler@chromium.org> <20230307164736.37ecb2f9@kernel.org>
In-Reply-To: <20230307164736.37ecb2f9@kernel.org>
From:   Grant Grundler <grundler@chromium.org>
Date:   Wed, 8 Mar 2023 10:34:35 -0800
Message-ID: <CANEJEGuMuA=Hvu4DO7Hj8kZLwEuNmuzesY3QbVDpECanaC4hpA@mail.gmail.com>
Subject: Re: [PATCHv2 1/2] TEST:net: asix: fix modprobe "sysfs: cannot create
 duplicate filename"
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Grant Grundler <grundler@chromium.org>,
        Oleksij Rempel <linux@rempel-privat.de>,
        Pavel Skripkin <paskripkin@gmail.com>,
        Lukas Wunner <lukas@wunner.de>,
        Eizan Miyamoto <eizan@chromium.org>,
        netdev <netdev@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        LKML <linux-kernel@vger.kernel.org>,
        Anton Lundin <glance@acc.umu.se>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 7, 2023 at 4:47=E2=80=AFPM Jakub Kicinski <kuba@kernel.org> wro=
te:
>
> On Tue,  7 Mar 2023 12:05:01 -0800 Grant Grundler wrote:
> > Subject: [PATCHv2 1/2] TEST:net: asix: fix modprobe "sysfs: cannot crea=
te duplicate filename"
>
> Why the "TEST:" prefix?

Sorry - that's left over from how I mark the change for testing with
chromeos-5.15 kernel branch:
   https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel=
/+/4313619

I should have removed that.  I upload the change to gerrit so partners
can easily test the same code  (e.g. coworker Eizan who is in
Australia).

If you follow the link above, you can see I'm testing a bunch of
additional backports as well and have additional fields in the commit
message required by chromium.org.

> The patch doesn't apply cleanly, it needs to go via this tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
> so rebase it onto that, please, and put [PATCH net] in the subject
> rather than just [PATCH].

Ok - thanks! Wil repost v3 against netdev/net.git/ shortly. No problem.

> Keep patch 2 locally for about a week (we merge fixes and cleanup
> branches once a week around Thu, and the two patches depend on each
> other).

Awesome! Sounds good.

> Please look thru at least the tl;dr of our doc:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html

Thanks!

Because I've been "randomly" contributing to netdev for 20+ years,
I've not looked for documentation (beyond SubmittingPatches). But I am
quite willing to read and follow it - makes life easier for everyone.

cheers,
grant