Date: Sat, 15 Sep 2007 01:09:40 +0900 (JST)
Message-Id: <20070915.010940.25476256.anemo@mba.ocn.ne.jp>
To: david@gibson.dropbear.id.au
Cc: akpm@osdl.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
       rtc-linux@googlegroups.com
Subject: Re: rtc-ds1742.c should use resource_size_t for base address
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <20070914055427.GM481@localhost.localdomain>
References: <20070914055427.GM481@localhost.localdomain>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 978
Lines: 21

On Fri, 14 Sep 2007 15:54:27 +1000, David Gibson <david@gibson.dropbear.id.au> wrote:
> Currently the rtc driver, rtc-ds1742.c uses an unsigned long to store
> the base mmio address of the NVRAM/RTC.  This breaks on systems like
> PowerPC 440, which is a 32-bit core with 36-bit physical addresses: IO
> on the system, including the RTC, is typically above the 4GB point,
> and cannot fit into an unsigned long.
> 
> This patch fixes the problem by replacing the unsigned long with a
> resource_size_t.  Tested on Ebony (PPC440) (with additional patches to
> instantiate the ds1742 platform device appropriately).
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Thanks!

Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/