Date:   Wed, 8 Mar 2023 11:58:08 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     ye.xingchen@zte.com.cn, keescook@chromium.org, yzaikin@google.com,
        akpm@linux-foundation.org, linmiaohe@huawei.com,
        chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V2 1/2] sysctl: Limit the value of interface
 compact_memory
Message-ID: <ZAjo0HaUTCzQtN1Q@bombadil.infradead.org>
References: <202303061407332798543@zte.com.cn>
 <83344b3d-1de1-f3c2-913c-a8c54ce7a99f@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83344b3d-1de1-f3c2-913c-a8c54ce7a99f@suse.cz>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Wed, Mar 08, 2023 at 11:21:36AM +0100, Vlastimil Babka wrote:
> 
> 
> On 3/6/23 07:07, ye.xingchen@zte.com.cn wrote:
> > From: Minghao Chi <chi.minghao@zte.com.cn>
> > 
> > In Documentation/admin-guide/sysctl/vm.rst:109 say: when 1 is written
> > to the file, all zones are compacted such that free memory is available
> > in contiguous blocks where possible.
> > So limit the value of interface compact_memory to 1.
> > 
> > Link: https://lore.kernel.org/all/ZAJwoXJCzfk1WIBx@bombadil.infradead.org/
> 
> I don't think the split to two patches you did, achieves Luis' request.
> 
> IIUC his request was to move the compaction entries out of sysctl.c?

Yes, thanks Vlastimil, just git log kernel/sysctl.c and you'll see tons
of examples.

  Luis