MIME-Version: 1.0
References: <20230301060453.4031503-1-grundler@chromium.org>
In-Reply-To: <20230301060453.4031503-1-grundler@chromium.org>
From:   Grant Grundler <grundler@chromium.org>
Date:   Wed, 8 Mar 2023 12:00:48 -0800
Message-ID: <CANEJEGvB0+XTgUwJi80BRFpNYWrbtiz17baSoxcR_OpSdnzahg@mail.gmail.com>
Subject: Re: [PATCH] PCI/AER: correctable error message as KERN_INFO
To:     Grant Grundler <grundler@chromium.org>
Cc:     Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
        "Oliver O 'Halloran" <oohall@gmail.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Rajat Khandelwal <rajat.khandelwal@linux.intel.com>,
        linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, Rajat Jain <rajatja@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Ping? Did I miss an email or other work that this patch collides with?

cheers,
grant

On Tue, Feb 28, 2023 at 10:05=E2=80=AFPM Grant Grundler <grundler@chromium.=
org> wrote:
>
> Since correctable errors have been corrected (and counted), the dmesg out=
put
> should not be reported as a warning, but rather as "informational".
>
> Otherwise, using a certain well known vendor's PCIe parts in a USB4 docki=
ng
> station, the dmesg buffer can be spammed with correctable errors, 717 byt=
es
> per instance, potentially many MB per day.
>
> Given the "WARN" priority, these messages have already confused the typic=
al
> user that stumbles across them, support staff (triaging feedback reports)=
,
> and more than a few linux kernel devs. Changing to INFO will hide these
> messages from most audiences.
>
> Signed-off-by: Grant Grundler <grundler@chromium.org>
> ---
> This patch will likely conflict with:
>   https://lore.kernel.org/all/20230103165548.570377-1-rajat.khandelwal@li=
nux.intel.com/
>
> which I'd also like to see upstream. Please let me know to resubmit mine =
if Rajat's patch lands first. Or feel free to fix up this one.
>
>  drivers/pci/pcie/aer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index f6c24ded134c..e4cf3ec40d66 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -692,7 +692,7 @@ static void __aer_print_error(struct pci_dev *dev,
>
>         if (info->severity =3D=3D AER_CORRECTABLE) {
>                 strings =3D aer_correctable_error_string;
> -               level =3D KERN_WARNING;
> +               level =3D KERN_INFO;
>         } else {
>                 strings =3D aer_uncorrectable_error_string;
>                 level =3D KERN_ERR;
> @@ -724,7 +724,7 @@ void aer_print_error(struct pci_dev *dev, struct aer_=
err_info *info)
>         layer =3D AER_GET_LAYER_ERROR(info->severity, info->status);
>         agent =3D AER_GET_AGENT(info->severity, info->status);
>
> -       level =3D (info->severity =3D=3D AER_CORRECTABLE) ? KERN_WARNING =
: KERN_ERR;
> +       level =3D (info->severity =3D=3D AER_CORRECTABLE) ? KERN_INFO : K=
ERN_ERR;
>
>         pci_printk(level, dev, "PCIe Bus Error: severity=3D%s, type=3D%s,=
 (%s)\n",
>                    aer_error_severity_string[info->severity],
> --
> 2.39.2.722.g9855ee24e9-goog
>