Message-ID: <ef58cd61-f90d-f242-9923-e9544d1aa963@nvidia.com>
Date:   Wed, 8 Mar 2023 12:13:04 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH V2 6/6] arm64: tegra: Add GTE nodes
Content-Language: en-US
To:     Krzysztof Kozlowski <krzk@kernel.org>, thierry.reding@gmail.com,
        jonathanh@nvidia.com, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org,
        linus.walleij@linaro.org, devicetree@vger.kernel.org,
        linux-doc@vger.kernel.org, robh+dt@kernel.org,
        timestamp@lists.linux.dev
References: <20230214115553.10416-1-dipenp@nvidia.com>
 <20230214115553.10416-7-dipenp@nvidia.com>
 <16e3ddb4-219e-70a8-8644-c62973f84d31@kernel.org>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <16e3ddb4-219e-70a8-8644-c62973f84d31@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkZZeThZMUlVNnpvMFE1RVNzaWVsUXg0emhmOTVpZmFrNjZqQjlQdjlNUVhZ?=
 =?utf-8?B?Ymc2bThLYk5aWHM1WVcwRTdyTDJ6eDJXeGZienN4UVNRZGhvSGRTT2JIMEZh?=
 =?utf-8?B?VTdGRjU2TnRmclVhYWVTU1d5ODExNk5CN2Qzck1TcDVIVE9RenFGdGJaNzFj?=
 =?utf-8?B?M3BLWEo5RGRIV21Qc3VHME9HKzJJNTVlT0RPbVg4U0w4RGRXRSsyVmhDMExz?=
 =?utf-8?B?dndHS1ZMMXNGalVxc05CRUQ2WW1pL0t6M0UrelR0VGhGaXhEbXpqcEE1MFl6?=
 =?utf-8?B?a0x0TGVCOFBybzZ6cGdWOWNudU94eGJkZEhKYmtEOU5oY3pCdlZlbFZGb0l4?=
 =?utf-8?B?ZUQyT1RJazdsNUt3U0l2Y1lrSjRKN3lXU1EwWXh5bkZtajJOUjhjZWxoTklt?=
 =?utf-8?B?OFV1cC9id0NzZ05TVnNYOUJaeEQzRFcrRjN2YmxFREQxbHdWUmRqSVBpRDda?=
 =?utf-8?B?dXhZb2prUXVoNTZJSGhacklHdWsrc1FMWm9wRFZwSUJJQVpRVGs1a2c5ZzVZ?=
 =?utf-8?B?NHNLM3lhb29xVTlDa0ZpYXQyTlNHRk5sbTNIb290cTcrYUNYTDZQdUkvWnFW?=
 =?utf-8?B?elBUZVY2MFY2ODFXZ3NMbGY5eGFrT016aS8zUkNJU1RxaHc5UGFkU1ZsbzBa?=
 =?utf-8?B?RHVZYWQxSkU0c3hNemFoR2xBbFFSbmlldFMreDVHSWozR1BtRllXbk5HZjZz?=
 =?utf-8?B?T0FWK2k2YnVBYlZqbXdOcmtvUHJjYi9mcEFUZ241K3ZnNGx2N3hkVDRmc3Rr?=
 =?utf-8?B?RTNvbXNaTmtuMG9DV1phdkt6NXk1SFhORmZMS3R6aDQzdGJYVXdNcHRSUXRC?=
 =?utf-8?B?TDlLRjF5aWYvODdLb3FySUhtYXk4VzdEMVgyaVRTbmtFWHR1WWFES0JJL2RQ?=
 =?utf-8?B?dEFhK3RqSXc1Q0kxMk5HYmVNUFM4dXlZbVBuNCtVeVdTTEVtdmU4d0RhMXRZ?=
 =?utf-8?B?SUFXV1hXNnQ3TjBmdlArcTFRTjBaYzMzWFJ0aTM2SCsyTGw1dUdUSGJQYUsz?=
 =?utf-8?B?cUpaV1VkN0JVMGJ1N1UweXNvTWQzcWZ6a2NaZnNUODFtWTc4VFlZTVNDR2VJ?=
 =?utf-8?B?SHN1Nm8xa1dwWWppcG1jRFVIS1VaQW1sRHpYZHJnR2Q2c0ZNcFNEelNJYzBV?=
 =?utf-8?B?K0lNS3JLTWVaYlN6U1JjMnJrUm5JT1dGNjJERXhJQXlQSnlUL3BCOHc1UHpu?=
 =?utf-8?B?SWZWdFlqRmFRZFNSR2tmS0xaTzlVdDE1cnd6c1pyMEZFcjErRHVHQzJWUmVm?=
 =?utf-8?B?UHdmQnlVdGdtQXlUVnRQdmpNY2xwNlJFalkvZmpQcXZlNTVLcnExMG5wMmdl?=
 =?utf-8?B?WUIySk5HbEJCR3ZKZ1pxTTlaOWZhZkZoR1RsTDF2eHUvMUF4WGJScDhrcVBa?=
 =?utf-8?B?aXdrZmJkQy9CQzF1bi91cTZlSVUxZFRpVUgxK2Z6RkVWWVdkMHI1VHVSVEJF?=
 =?utf-8?B?OS81NWFPQnl6dmdSVmcralZ2QmdoaWFwZEpnTHlkQnFpODF0NFJJeGtXWlhF?=
 =?utf-8?B?L2dmWVRCTVFrZVZHMDZNRldlcVlvUHNmY2YvUzJuWVpseE9oTFpkcDJQWFJk?=
 =?utf-8?B?bm9QMzRKbjJxNnc2VjVzejZpZWwrWFdLbnpicEk5WXBGMUljU1p3L3BYVGs5?=
 =?utf-8?B?WGJWcFJta1NLU2VZUzVFazZ1d3ZTd2YvQmJqcmcya1RBdmg4aHgxZDM0eU9Z?=
 =?utf-8?B?S2hPRUNscjg3ci82TjBzTkF4SEhWRGdadkZlSThGeHA3aVJneWxBZ1M3NEVY?=
 =?utf-8?B?OWwwVjNYa3RVN3ZFR0J5MXlyU2hQSXFNdUE4Q1BDQTFDNUFkMlNKWEdiUHN2?=
 =?utf-8?B?WHFmenZkMEQ0ckwxbllHWUhPQ3ZPR3hQcEszeVJBN3FzeHpXNUZDcVZUTm4x?=
 =?utf-8?B?NU0waklsTklOQVplS1ZDcVFieVpyNUNQRG1YKzFpbENBZFUwdlAwWUQ1L0NB?=
 =?utf-8?B?c285RlV4bWYvL3YwRjQ1TG9GRlVEdlVTSjJsb1MwRUdmUkFmUTlZd1pzWHNu?=
 =?utf-8?B?VzdiRDA4UFVReG1aSUtPUjNxblE2dzF1MW1KOFB0enk5NDJwOG8rYm85OXhR?=
 =?utf-8?B?cGtQdVFHWllZVEJsN2R2MllST2NqU0JSb2RlZmtNM0xld25sMzdEWDNPaUVs?=
 =?utf-8?Q?AtZPfWBGTy2autlWgVtrz47ms?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea158f4-7a4a-4974-752e-08db201188b3
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 20:13:08.5551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mTXMk18Hcvw6APJMEXpGiUHStge4uPgLinNnbGAEhMRau9T5dJbPPIelk1XXgMSpmvBuDbthKQFBN1W9rVeiVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7962
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/16/23 6:18 AM, Krzysztof Kozlowski wrote:
> On 14/02/2023 12:55, Dipen Patel wrote:
>> Add GTE nodes for the tegra234. Also modify AON GTE nodes for the
>> tegra194 to remove nvidia,slice property and add nvidia,gpio-controller
>> propertyto specify AON GPIO controller node so that GTE driver can
>> do namespace conversion between GPIO lines provided by the gpiolib
>> framework and hardware timestamping engine subsystem.
>>
>> Signed-off-by: Dipen Patel <dipenp@nvidia.com>
>> ---
>>  arch/arm64/boot/dts/nvidia/tegra194.dtsi |  3 +--
>>  arch/arm64/boot/dts/nvidia/tegra234.dtsi | 19 +++++++++++++++++++
>>  2 files changed, 20 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
>> index 4afcbd60e144..4c92850b1ec4 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
>> @@ -1363,7 +1363,6 @@
>>  			reg = <0x3aa0000 0x10000>;
>>  			interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
>>  			nvidia,int-threshold = <1>;
>> -			nvidia,slices = <11>;
>>  			#timestamp-cells = <1>;
>>  			status = "okay";
>>  		};
>> @@ -1586,7 +1585,7 @@
>>  			reg = <0xc1e0000 0x10000>;
>>  			interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
>>  			nvidia,int-threshold = <1>;
>> -			nvidia,slices = <3>;
>> +			nvidia,gpio-controller = <&gpio_aon>;
>>  			#timestamp-cells = <1>;
>>  			status = "okay";
>>  		};
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> index eaf05ee9acd1..4a87490c5fd4 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> @@ -1086,6 +1086,15 @@
>>  			clock-names = "fuse";
>>  		};
>>  
>> +		hte_lic: hardware-timestamp@3aa0000 {
>> +			compatible = "nvidia,tegra234-gte-lic";
>> +			reg = <0x3aa0000 0x10000>;
>> +			interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
>> +			nvidia,int-threshold = <1>;
>> +			#timestamp-cells = <1>;
>> +			status = "okay";
> 
> Why do you need status? It's okay by default.
what's harm of having to explicitly mentioned? I can see status = okay in this dtsi file
for other nodes as well and was just following that.
> 
>> +		};
>> +
>>  		hsp_top0: hsp@3c00000 {
>>  			compatible = "nvidia,tegra234-hsp", "nvidia,tegra194-hsp";
>>  			reg = <0x03c00000 0xa0000>;
>> @@ -1603,6 +1612,16 @@
>>  			#mbox-cells = <2>;
>>  		};
>>  
>> +		hte_aon: hardware-timestamp@c1e0000 {
>> +			compatible = "nvidia,tegra234-gte-aon";
>> +			reg = <0xc1e0000 0x10000>;
>> +			interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
>> +			nvidia,int-threshold = <1>;
>> +			nvidia,gpio-controller = <&gpio_aon>;
>> +			#timestamp-cells = <1>;
>> +			status = "okay";
> 
> 
> Also here
> 
> Best regards,
> Krzysztof
>