Message-ID: <110becd9-3511-b7ab-f34c-1a4fe7fc9e82@cornelisnetworks.com>
Date:   Wed, 8 Mar 2023 15:24:55 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH] rdma/qib: Remove deprecated kmap() call
Content-Language: en-US
To:     Ira Weiny <ira.weiny@intel.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>
Cc:     linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230217-kmap-qib-v1-1-e5a6fde167e0@intel.com>
From:   Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
In-Reply-To: <20230217-kmap-qib-v1-1-e5a6fde167e0@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVI5OXlpREpNNWoxcUp5K0JxQnhKN1ZlV2JnYy9ibEhHUFRRQTBGUzRvSlRJ?=
 =?utf-8?B?SFBWODg3eENOaVdCNURmbnRldkpYOW5jWGZudWdremdLdTAwWnBUbGVqV2VP?=
 =?utf-8?B?RTBwenBOQy9qWTFoY2JHaEF6TnJadE41ZDc5azN2U1diTWR6MXhnYTBJZmJB?=
 =?utf-8?B?cFlRUEo1ZzVmSTBuRlRpcXo3YWEycElPcHB3NitSbVZBQzhRb25uTmIyRTNy?=
 =?utf-8?B?eEwveUdadkNsL2RRVzZOSDNteS9tVFRvRkpoYzFEaUtEeVRaMmFpTk1OYTlw?=
 =?utf-8?B?eDRZMzJzdDhoQ0Z0VVFBbmJJUFBQaFVjOXFIVGU0WVhYbXh3b0lpMW1lV2xN?=
 =?utf-8?B?RjhUU3I4aGhmTE1VNm41RmZyRXlrV0VKOTZ1TGhNY3Z4VXdUTXZuZVBscm9Y?=
 =?utf-8?B?YkZ4WWFRRmlLVDQ0OGRhR1pBOXo5S3NOcUIvQldHVHRJK2xkMTVDS1VYNzdr?=
 =?utf-8?B?STdJL3VGVjdvVGhheGtuT0xkTFJkRWlUL3FqOGxnaUZVS20rTE5HUXlrbG9C?=
 =?utf-8?B?WUNFaWpYZFpWaWJDdG1FM09zVE1DQkhuSVVFS1B3a09yeEo2NWc5dURiZnVa?=
 =?utf-8?B?bmVIRmRZdnFZMlRWVWhKRkVMQldjbG8rYkdkOXlISE1Mei96dVJiN3FSc2ow?=
 =?utf-8?B?aExsQ3U5Y3RVcHRWczRaUWJVOGh3T2RQZE84NjlJT2wrRkV1S0NhWHlRMitn?=
 =?utf-8?B?eXJnOTVmZ1YyaVJNaEhXZmVlK3JVOXFzZU14dyswblNFVG1sUTdUNkNWY3ZQ?=
 =?utf-8?B?TSt4YXR5MXBkWjB3WndPZEVxMWQ0L3RnKzFXd0t1SWFsWStlaUlTRnB3dkhh?=
 =?utf-8?B?d2psOWQ5cG1Cb1diWVhrL1l6bDZlN1dFTyttby9rZGJNLzlueVJ2MEpkcnZa?=
 =?utf-8?B?TUhLQk52U25XbW9JQ3p6TnZLazdZRUdKcGZFN3VwZi82azBrZHRxUFJUQzJS?=
 =?utf-8?B?VVVFMllHbUNJdUk5QjdKT1Z5QzNnSHB3M0RMUXZoTE9JNVJOQkd3MmRhemxW?=
 =?utf-8?B?R0kvalRFbzBQTG9JNUR0Z25rUFB4ZTVyWXd3N1lBWFR3ODJIdis4bGN0S1Rv?=
 =?utf-8?B?cU0xNk43eThEa2lqbWFJZzczYUcvREJMTGcyMDFSSFAzTHlKZXV4YW80YTdj?=
 =?utf-8?B?dmMwdlV5VUVDTDZKaTh0V3AyaWlzT2FkWlpiZ1hZdzZVblVwTVFMZitmY1lC?=
 =?utf-8?B?ZlIwRWVFQ2E2T2xHZ1d4a282dUpRRER3WGZCSXFJRmJGL0tSbWxyUkt2SURX?=
 =?utf-8?B?MmxrT1VHQTlMVGlLb2NkTUdTNlpxeWUwZHpaUGo0WElyOVBERGJ5NHpLRDRQ?=
 =?utf-8?B?eng2VjhKNlRrNjdtVkswL3RIdDlway8xRFQ5R1RncFROM0Y1bWlHY1N6N1FE?=
 =?utf-8?B?WGptUnZIYUNuNkovUjlWUHQ4L0MyUFRFZVI4SWVFMHcyMCtsVVlZK05kZC9G?=
 =?utf-8?B?eGsweGtBYVNtelcvbHkzYTVVejlZZllYazdqMXozclZCQWd6c3U2cE1xNVJ2?=
 =?utf-8?B?bEY3RnkwME42ODBjTGE2RWpDV2JjcTVSdXV4aXpyOW5iYkpwZWppOGxuNUVC?=
 =?utf-8?B?dE0zTnRhblMxYVBOMjVZT1ZISERyVXltZmRrNWJncW9tNHVWUVJ6aUk2VURl?=
 =?utf-8?B?cHVqUU4xTnlPbEsyWGtTZ2V4cDRYeGMwaUhSWlFHOHp3bzgwazhUWjgyYVBS?=
 =?utf-8?B?M01NWkgrb0FFcE5NSllCSGRjRC91U1E5bXlXK1FXNUcvOUJBUmVKS1lQbTFj?=
 =?utf-8?B?aWhGUS9OMFFOS1l1QW9yb3hWOWNDdmZmQmxBbjFtTzBDajVFVjF0MDJRZmwx?=
 =?utf-8?B?cDNRMTRUTllqR296Z1d0VlFIOC9TYVNJMHFQcVAzZjJpdllzQmEwVnI0OFht?=
 =?utf-8?B?bTBXMkpOZzhkYWNJbngwQ0E4Y3FXWjMxNkRxV3pyckZtNmllM0NrUnRxaFdB?=
 =?utf-8?B?ZVFwK1lOQmxMTEdrY0N3WTMyRjNBWVpJTmpFU2t6cFhEOUhHa0J5U1VwYjBH?=
 =?utf-8?B?QWhiaDR0TndmZzJBTmJNdG91WDlndHUyMVhtTU05a0RXVVhkaFpFR2xJRmlJ?=
 =?utf-8?B?R2JlVksxT3VWRzNzbVFOemlaVDltZlVEeHdLd2tqYkhzbTd0T1gzcEFTZjlk?=
 =?utf-8?B?ZTRCaWp6enZEWXVtUVVrSCtSSjBnZkx5N2MxSHV1c2JtM3JWNUpKRjgwZTFT?=
 =?utf-8?Q?3XiDPnTNhacW6GG+Ti8D03Y=3D?=
X-OriginatorOrg: cornelisnetworks.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3a39f37-5856-47d7-1f2a-08db20132f63
X-MS-Exchange-CrossTenant-AuthSource: BN6PR01MB2610.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 20:24:57.6112
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4dbdb7da-74ee-4b45-8747-ef5ce5ebe68a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lezGPxgLJ4EZeT5Lyg6lquThISk57opxnLHSEmwV0DMYlkmBMy6lvYpnj2WSM8v5hUlRFQSb8Xka2eunDSq8Wa2LS0CqW+fPITFXf9wqUt+PUng2pOn/oXmHqBkogRBH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR01MB2535
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/7/23 12:15 PM, Ira Weiny wrote:
> kmap() has been deprecated in favor of the kmap_local_page() call.
> kmap_local_page() is thread local.
> 
> In the sdma coalesce case the page allocated is potentially free'ed in a
> different context through qib_sdma_get_complete() ->
> qib_user_sdma_make_progress().  The use of kmap_local_page() is
> inappropriate in this call path.  However, the page is allocated using
> GFP_KERNEL and will never be from highmem.
> 
> Remove the use of kmap calls and use page_address() in this case.
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>