Message-ID: <774991d7-1f36-7e6b-302c-4436501625cb@cornelisnetworks.com>
Date:   Wed, 8 Mar 2023 15:38:11 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH 2/2] IB/qib: Drop redundant
 pci_enable_pcie_error_reporting()
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>
Cc:     linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>
References: <20230307193211.874747-1-helgaas@kernel.org>
 <20230307193211.874747-3-helgaas@kernel.org>
From:   Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
In-Reply-To: <20230307193211.874747-3-helgaas@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0h2MU0rQVF6Nld2TjhkUnNLZTc4RzNzNkx2eDZralE5Y2ZGVm5tTWV2Zkc3?=
 =?utf-8?B?R0pZMjBlN0tMUUtYeG1ZOHhCWVZBTThjS1YwUmp4anh1Y21DZUhMWm1ZdFRk?=
 =?utf-8?B?S2xqTE5sMWpGRCtYOGlPb3l0VGlmL1R5dXdqby9TTmUvdy8wQitHREdVcFhW?=
 =?utf-8?B?WnRtbnNETWVtdHE0WVZFQUpYZlhPdmlMY0FqM0MvdmFMd01rWXdyMll1VkNL?=
 =?utf-8?B?azJWV3JLNDBVdERIQ09UQTN0aDZmYlRxekJHRXhuWVhQeUZkeTZnQWdkVHoy?=
 =?utf-8?B?WUo0R0x4ZmNzeGVJTGhrUmkwaFF3SThNUTFWOEhhWjA4T0F0UStqd01Yc1Qr?=
 =?utf-8?B?ZUZZYkFrbHllWXp6Wk5ocTAwQ21XdzNtaHdRK0Y4c01MM09pQmhTanZBTVFo?=
 =?utf-8?B?VXB3K0Y2SzFMZFVBNWZtM1ppa1p3WlpmUDhJcTQwbWMwa0t2NWJSWmpHeTY3?=
 =?utf-8?B?cHhXNmhuRHlTMFVjcE0vMnordDQ3cmg0VVpJTkhTT3lpMDZFc291citKV1N0?=
 =?utf-8?B?ekh3VUh4OTJyc3Z3UlUxbytmRllvY01GUyticUs0RTRxS0EzMWlsbmtLWWJO?=
 =?utf-8?B?TWd3a1F3UkJOUjR5NUU3Z2FFUXBqRi9Ca1ZtekxjMmhkcFZzNnl0QXRRbFBi?=
 =?utf-8?B?QUJPY2tDZlBBMTFWRlkzN3RPNDBHTG5USUQzd3I3QnZVTXhUWmFhMjdKSnVG?=
 =?utf-8?B?VXVKNmYzTk1NSnpJME9CcGV0OWFGR21mQjFjUGd5SHRIQ0JZV3MvTHZvSWJ3?=
 =?utf-8?B?TkdJUWRIYmorZnlsaUNKbVM5Qm9IcWxvbVRaelo5UEkwMGlNMTB2NHF6aTR4?=
 =?utf-8?B?QWFwRWQyMXE0Szh1SWE2M3FQRHRTQ1pwUG0xQ0hReDN2aTlJU3J1T2p5ZW5V?=
 =?utf-8?B?eEFEQWRKSGdZYjZiMVRVS2dUbWFMVVNSWnYvV0RlR2dtblc4Q2ZtaFozRi9h?=
 =?utf-8?B?TkJqeUpkLzdpLy8xRWl5ZDNIRzZIOVlFL3FPOU5nNi9SOHFmOWJGemZVc1M3?=
 =?utf-8?B?ZXpYZ0lvNXh2OHoyTno3OUVPZEVxMjVLL0NOZi9wRDJ3Nk1Ic0pSUlpVcVds?=
 =?utf-8?B?QjI5eG52YllUVlA3VTZVVEgwSmtwVXI2aW1BNjJHR01TeXBUUEo1T05oWjRy?=
 =?utf-8?B?WjdmSHRvZ3RMaDlSZkd6bGdSY2NTaHZzUXROZUpyZCtVS3VJZE9jalFOQmdx?=
 =?utf-8?B?TTROY1hYUTNJZlVIVjZoV0RCNjlsWmxqbGEwalg4MEhIWE8wM1AwUnc1V0tZ?=
 =?utf-8?B?N0tkSDFiVDNLYXlVOHJLZFBXSlBuTnJEN29SdUZlU1JBQUZvOGM4RlVXYUp3?=
 =?utf-8?B?V0tVTDcwZEJHbzZob2g0eXVXR3pmUUFPR0wxVkdwT1RrQWt6MDdZZnhBNTVp?=
 =?utf-8?B?ZkptUmw5SDdLVzhJZFJuV2E1eHF0TFZmLzhVTm41UU1uR1FwRmNkbUhjV3Nj?=
 =?utf-8?B?cmF6S3NPRVVwenRXdXdqQmcwZnhjVlg2YXU2NW5IOW9ManZqMEJ1cVJzb2pk?=
 =?utf-8?B?WnNJV1IzcDNUdDQ3MVZmdFRYYTZueHhjWEx5SEwvemRBNXBES2g4bzQrWEg3?=
 =?utf-8?B?VVY5WEVGK3lZU0RKT2xTNUV5RlVVTzAraWRMb1NiRnJyUGdKNldCUDZHVEQv?=
 =?utf-8?B?Y3c1Sm5aUDZ4MUtMejRnQXNvMFQxZ3A3Nkh6ZEJGUFNoYUM4TEtId3d2Rkx2?=
 =?utf-8?B?cWhYaVV6K29oOERGZzJ0QmFlNWFvd2ZucGFSZGpZTGcrSkswa3NnNkJHQnMw?=
 =?utf-8?B?ZS8yMDN4TW1La3RlZHFscit3aXlHc2NVbFNrUkRyWngxWDVNbkNBVkVIaGda?=
 =?utf-8?B?OW9SdUIyTXdibGZOeHp1S052SGN2UEkxck5ZQm5DcU1uTXhRd2s4amd4djhw?=
 =?utf-8?B?cGdMZnIwL000YVo5alpkN1BnR2N3d21TTWhpVktUaVBzQmZyNzBKZlJUdHZt?=
 =?utf-8?B?aUhEU0YyUWVyTjVQSFdTVnQ0N21CeUpEL0Z6R1MxNHlheXROazRIOE5mVkg1?=
 =?utf-8?B?d2VlREs2eDlrSjFrMjJUT3MxRnFxTkx4Q2xWbDcybnE1Y1FWV3lCemxhRUI4?=
 =?utf-8?B?R01MbklOZXlCTytCTTdvVHpkQjlET3ZKNllZK0dBclU5M1FkaUZadFU1NlZ4?=
 =?utf-8?B?YVRvS0dhak9hK2h1RWYxZ1NpMDU5TjFRVk9SRm5nZnRMUnlka3JKWUZvdWJy?=
 =?utf-8?Q?ROzAl0z+f+bMnL9R0HnUeZw=3D?=
X-OriginatorOrg: cornelisnetworks.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 133645c2-e318-4b21-d4ff-08db20150997
X-MS-Exchange-CrossTenant-AuthSource: BN6PR01MB2610.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 20:38:13.1498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4dbdb7da-74ee-4b45-8747-ef5ce5ebe68a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VsMHuSrcTKcHNTHbnXErAgmWKVRsSw79/gWMYm/fYYPJTUcDmsEHX4l2OjaVFaXKeWyShsDxTHGECx5l2KJJaTaE7LxeMxpeDzNEwgpRt5bJSTDSuxQFuXH2cX/IPBTk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5835
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/7/23 2:32 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration, so the
> driver doesn't need to do it itself.
> 
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.
> 
> Note that this only controls ERR_* Messages from the device.  An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>