Message-ID: <cd60d29e-9512-dcc6-e72a-a4936fed42f5@suse.cz>
Date:   Wed, 8 Mar 2023 22:54:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH V2 2/2] mm: compaction: Limit the value of interface
 compact_memory
To:     Luis Chamberlain <mcgrof@kernel.org>
Cc:     ye.xingchen@zte.com.cn, keescook@chromium.org, yzaikin@google.com,
        akpm@linux-foundation.org, linmiaohe@huawei.com,
        chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
References: <202303061405242788477@zte.com.cn>
 <c48666f2-8226-3678-a744-6d613288f188@suse.cz>
 <ZAjorPD2nSszUsXz@bombadil.infradead.org>
Content-Language: en-US
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <ZAjorPD2nSszUsXz@bombadil.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/8/23 20:57, Luis Chamberlain wrote:
> On Wed, Mar 08, 2023 at 11:23:45AM +0100, Vlastimil Babka wrote:
>> >  {
>> > -	if (write)
>> > +	int ret;
>> > +
>> > +	ret = proc_dointvec_minmax(table, write, buffer, length, ppos);
>> > +	if (ret)
>> > +		return ret;
>> > +	if (write) {
>> > +		pr_info("compact_nodes start\n");
>> >  		compact_nodes();
>> > +		pr_info("compact_nodes end\n");
>> 
>> I'm not sure we want to start spamming the dmesg. This would make sense
>> if we wanted to deprecate the sysctl and start hunting for remaining
>> callers to be fixed. Otherwise ftrace can be used to capture e.g. the time.
> 
> Without that print, I don't think a custom proc handler is needed too,
> right? So what would simplify the code.

But we'd still call compact_nodes(), so that's not possible without a custom
handler, no?

>   Luis