Date:   Wed, 8 Mar 2023 23:06:35 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Rob Herring <robh@kernel.org>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Walle <michael@walle.cc>,
        =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Robert Marko <robert.marko@sartura.hr>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Wolfram Sang <wsa@kernel.org>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 03/21] of: Rename of_modalias_node()
Message-ID: <fca549f7-a79a-4d8f-b609-efef830becd2@mercury.local>
References: <20230307165359.225361-1-miquel.raynal@bootlin.com>
 <20230307165359.225361-4-miquel.raynal@bootlin.com>
 <20230308001903.GA513330-robh@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="j6wpdwdpkitl36cp"
Content-Disposition: inline
In-Reply-To: <20230308001903.GA513330-robh@kernel.org>
Precedence: bulk


--j6wpdwdpkitl36cp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Mar 07, 2023 at 06:19:03PM -0600, Rob Herring wrote:
> On Tue, Mar 07, 2023 at 05:53:41PM +0100, Miquel Raynal wrote:
> > This helper does not produce a real modalias, but tries to get the
> > "product" compatible part of the "vendor,product" compatibles only. It
> > is far from creating a purely useful modalias string and does not seem
> > to be used like that directly anyway, so let's try to give this helper a
> > more meaningful name before moving there a real modalias helper (already
> > existing under of/device.c).
> >=20
> > Also update the various documentations to refer to the strings as
> > "aliases" rather than "modaliases" which has a real meaning in the Linux
> > kernel.
> >=20
> > There is no functional change.
> >=20
> > Cc: Rafael J. Wysocki <rafael@kernel.org>
> > Cc: Len Brown <lenb@kernel.org>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: Sebastian Reichel <sre@kernel.org>
> > Cc: Wolfram Sang <wsa@kernel.org>
> > Cc: Mark Brown <broonie@kernel.org>
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >  drivers/acpi/bus.c                |  7 ++++---
> >  drivers/gpu/drm/drm_mipi_dsi.c    |  2 +-
> >  drivers/hsi/hsi_core.c            |  2 +-
>=20
> These should not have been using this function. The matching on just the=
=20
> product was a relic from I2C and SPI which we don't want to propogate.=20
> No clue why ACPI needed it...
>=20
> If you respin or want to fixup while applying, can you add a kerneldoc=20
> comment to not add new users of the function. Not that anyone will=20
> follow that... :(
>=20
> Reviewed-by: Rob Herring <robh@kernel.org>

I just checked and HSI is not using the data for matching. Instead
it uses the returned data to set the device name. Matching happens
using the full compatible.

FWIW the MIPI HSI standard never became a big thing, so we have only
one HSI DT driver upstream and that is the Nokia N900 modem driver.

Anyways:

Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for HSI

-- Sebastian

>=20
> >  drivers/i2c/busses/i2c-powermac.c |  2 +-
> >  drivers/i2c/i2c-core-of.c         |  2 +-
> >  drivers/of/base.c                 | 15 ++++++++-------
> >  drivers/spi/spi.c                 |  4 ++--
> >  include/linux/of.h                |  2 +-
> >  8 files changed, 19 insertions(+), 17 deletions(-)

--j6wpdwdpkitl36cp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQJBuMACgkQ2O7X88g7
+pq8tA//dfZ7GtpO1P3CEg/QoZwn+UupbXuO8DQwKADWWTMSmK39RdCUOhyy1VR/
OZsp/pifZ/vM1FlnCKdzBNgRXWxYP4li7WeKWUoV12eQkPV7SsnyffnXFishOhSe
63hZxb70SHBXCuW1iZmjt7RkgV2kmxnVzV2EcIAPoAMWDbbBARAjvsUsgoF3cr7h
jH1aeQGaVpp4weu69RU4m7ySS0lgFAV8EzSbWq6QUH5EAegQHpUKFIrqeCUIBxvL
fpR5ZW7Ca9PzqSBHik8avUiND5ZyUs9QOZA9swhy8C1lsIki/NjajDI8aspU+yZq
HlP7U2c6vLN1GYnrVLrfV8cf8ocIB3cO54oVPbJVIdenaWzCKv8yK3KUigI8UwRQ
8HabDuwJ55zKQW8Sk0lgfA1Exnd8mtTy9bBCa9qI5fUe11Nxxi9q6rWrk+p4ZaSU
yi5WNTq2raocgZnphiJhxjMjDHWhkE0/CV8H221DVgZtDcFDitQ3gq7x+5pPK3mT
6AW9JvitpIinCa3koOgr0oIHiVueEcszstHIhetDGGVTn4KgeH3vl5qSd/YNXbxf
AeeM0HOviFnJnS39oaMXpAdDtjEDVBgKwNRqX16Wl8GndMuHXDc3zTz7TSl2hbVQ
LpZ4QommfGZjUoL52eSp/JKjZkKSQXvonfF4IhgNxlJvrvUzV+w=
=SbPM
-----END PGP SIGNATURE-----

--j6wpdwdpkitl36cp--