Date:   Wed, 8 Mar 2023 14:23:07 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     ye.xingchen@zte.com.cn, keescook@chromium.org, yzaikin@google.com,
        akpm@linux-foundation.org, linmiaohe@huawei.com,
        chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V2 2/2] mm: compaction: Limit the value of interface
 compact_memory
Message-ID: <ZAkKy8LVXKF2C7kv@bombadil.infradead.org>
References: <202303061405242788477@zte.com.cn>
 <c48666f2-8226-3678-a744-6d613288f188@suse.cz>
 <ZAjorPD2nSszUsXz@bombadil.infradead.org>
 <cd60d29e-9512-dcc6-e72a-a4936fed42f5@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cd60d29e-9512-dcc6-e72a-a4936fed42f5@suse.cz>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Wed, Mar 08, 2023 at 10:54:31PM +0100, Vlastimil Babka wrote:
> On 3/8/23 20:57, Luis Chamberlain wrote:
> > On Wed, Mar 08, 2023 at 11:23:45AM +0100, Vlastimil Babka wrote:
> >> >  {
> >> > -	if (write)
> >> > +	int ret;
> >> > +
> >> > +	ret = proc_dointvec_minmax(table, write, buffer, length, ppos);
> >> > +	if (ret)
> >> > +		return ret;
> >> > +	if (write) {
> >> > +		pr_info("compact_nodes start\n");
> >> >  		compact_nodes();
> >> > +		pr_info("compact_nodes end\n");
> >> 
> >> I'm not sure we want to start spamming the dmesg. This would make sense
> >> if we wanted to deprecate the sysctl and start hunting for remaining
> >> callers to be fixed. Otherwise ftrace can be used to capture e.g. the time.
> > 
> > Without that print, I don't think a custom proc handler is needed too,
> > right? So what would simplify the code.
> 
> But we'd still call compact_nodes(), so that's not possible without a custom
> handler, no?

Ah right. It does beg the question if that form is common, so to define one.
But that's just extra work not needed now.

  Luis