Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CB89C678D5 for ; Wed, 8 Mar 2023 22:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230246AbjCHW1j (ORCPT ); Wed, 8 Mar 2023 17:27:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbjCHW1g (ORCPT ); Wed, 8 Mar 2023 17:27:36 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF4F47D577; Wed, 8 Mar 2023 14:27:35 -0800 (PST) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 328F2JPo020998; Wed, 8 Mar 2023 22:27:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=BnxJZOUWAPz9fhWBxQIvv8l5fd/RNCl9syenTA+Xu9o=; b=eL7lzc+35XtXO35B6Osdzr5QJb+e+DL1LfwtDL+Q5RXBBEllA0je18hcZE25VqNL1XYT UCldtuTGrqSJfQELpwKS27hiCs3du8R2skdaWW8YTYPHBVj5rjtR4xAzdkQtNvvY8HUX dE1LdbZ3mhjb2YW5gGXGC5QyiFhZ6fHySZRNu+iDQCMP+mpACH+Klo0KyP7+wjjknI+V 7k1LqyQsZ6Yrn+dPFw4cmI0wh+em/b1o+Lalow0cv4VEnxQMuZHC3glyNUh5N6iRw5Uo 9Q8Zcd9uZBK6QwX5KrmB0gXcxvr2uBzGVGh9LIGUWZUjwWSSXPW+aYeqaKx0FOVEMles NQ== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3p6vnah2ww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Mar 2023 22:27:13 +0000 Received: from nasanex01a.na.qualcomm.com ([10.52.223.231]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 328MRCj7021491 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 8 Mar 2023 22:27:12 GMT Received: from [192.168.143.77] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 8 Mar 2023 14:27:12 -0800 Message-ID: Date: Wed, 8 Mar 2023 14:27:11 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v1 2/4] ufs: mcq: Add supporting functions for mcq abort Content-Language: en-US To: Bart Van Assche , , , , , , , , CC: , Alim Akhtar , "James E.J. Bottomley" , Arthur Simchaev , open list References: From: "Bao D. Nguyen" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: R1Cp1VZNh3ORtuGdMmw-HrylbIUx0A5p X-Proofpoint-ORIG-GUID: R1Cp1VZNh3ORtuGdMmw-HrylbIUx0A5p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-08_15,2023-03-08_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 mlxlogscore=999 impostorscore=0 mlxscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303080189 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bart, thank you very much for the reviews. On 3/8/2023 10:48 AM, Bart Van Assche wrote: > On 3/7/23 20:01, Bao D. Nguyen wrote: >> +/* Maximum MCQ registers polling time */ > > registers -> register I will make the change in the next rev. > >> +#define MCQ_POLL_TIMEOUT   500 > >>       struct ufshcd_mcq_opr_info_t mcq_opr[OPR_MAX]; >> +    u32 mcq_poll_ms; >>   }; > > Why has the new member variable 'mcq_poll_ms' been introduced since > its value is never changed? > This is to give us the flexibility to override this parameter in the downstream driver if needed. > Thanks, > > Bart.