Message-ID: <17ac3a17-7e54-991d-3f6e-e6cee7348ba6@linaro.org>
Date:   Thu, 9 Mar 2023 00:47:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] ARM: dts: qcom: apq8026-lg-lenok: add missing reserved
 memory
Content-Language: en-US
To:     Luca Weiss <luca@z3ntu.xyz>, ~postmarketos/upstreaming@lists.sr.ht,
        phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230308-lenok-reserved-memory-v1-1-b8bf6ff01207@z3ntu.xyz>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230308-lenok-reserved-memory-v1-1-b8bf6ff01207@z3ntu.xyz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8.03.2023 22:06, Luca Weiss wrote:
> Turns out these two memory regions also need to be avoided, otherwise
> weird things will happen when Linux tries to use this memory.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>  arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> index de2fb1c01b6e3..b82381229adf6 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> @@ -27,6 +27,16 @@ chosen {
>  	};
>  
>  	reserved-memory {
> +		sbl_region: sbl@2f00000 {
oh that must have been fun


Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> +			reg = <0x02f00000 0x100000>;
> +			no-map;
> +		};
> +
> +		external_image_region: external-image@3100000 {
> +			reg = <0x03100000 0x200000>;
> +			no-map;
> +		};
> +
>  		adsp_region: adsp@3300000 {
>  			reg = <0x03300000 0x1400000>;
>  			no-map;
> 
> ---
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
> change-id: 20230308-lenok-reserved-memory-b9373f9c8993
> 
> Best regards,