Subject: Re: [PATCH net] vmxnet3: use gro callback when UPT is enabled
To:     Ronak Doshi <doshir@vmware.com>, <netdev@vger.kernel.org>
CC:     <stable@vger.kernel.org>,
        VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Guolin Yang <gyang@vmware.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20230308222504.25675-1-doshir@vmware.com>
From:   Yunsheng Lin <linyunsheng@huawei.com>
Message-ID: <e3768ae9-6a2b-3b5e-9381-21407f96dd63@huawei.com>
Date:   Thu, 9 Mar 2023 08:34:05 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <20230308222504.25675-1-doshir@vmware.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/3/9 6:25, Ronak Doshi wrote:
> Currently, vmxnet3 uses GRO callback only if LRO is disabled. However,
> on smartNic based setups where UPT is supported, LRO can be enabled
> from guest VM but UPT devicve does not support LRO as of now. In such
> cases, there can be performance degradation as GRO is not being done.
> 
> This patch fixes this issue by calling GRO API when UPT is enabled. We
> use updateRxProd to determine if UPT mode is active or not.
> 
> Cc: stable@vger.kernel.org
> Fixes: 6f91f4ba046e ("vmxnet3: add support for capability registers")
> Signed-off-by: Ronak Doshi <doshir@vmware.com>
> Acked-by: Guolin Yang <gyang@vmware.com>
> ---
>  drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 682987040ea8..8f7ac7d85afc 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -1688,7 +1688,8 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,
>  			if (unlikely(rcd->ts))
>  				__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), rcd->tci);
>  
> -			if (adapter->netdev->features & NETIF_F_LRO)
> +			/* Use GRO callback if UPT is enabled */
> +			if ((adapter->netdev->features & NETIF_F_LRO) && !rq->shared->updateRxProd)

If UPT devicve does not support LRO, why not just clear the NETIF_F_LRO from
adapter->netdev->features?

With above change, it seems that LRO is supported for user' POV, but the GRO
is actually being done.

Also, if NETIF_F_LRO is set, do we need to clear the NETIF_F_GRO bit, so that
there is no confusion for user?

>  				netif_receive_skb(skb);
>  			else
>  				napi_gro_receive(&rq->napi, skb);
>