Date:   Thu, 9 Mar 2023 09:48:30 +0800
From:   Zhenyu Wang <zhenyuw@linux.intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Kan Liang <kan.liang@linux.intel.com>
Subject: Re: [PATCH] perf/x86/intel: use hexidecimal value for cpuid
Message-ID: <ZAk67tyBMde8k1C5@debian-scheme>
Reply-To: Zhenyu Wang <zhenyuw@linux.intel.com>
References: <20230308031501.4688-1-zhenyuw@linux.intel.com>
 <20230308141619.GI2017917@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="kQDGHQ6bVW4X2LBn"
Content-Disposition: inline
In-Reply-To: <20230308141619.GI2017917@hirez.programming.kicks-ass.net>
Precedence: bulk


--kQDGHQ6bVW4X2LBn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2023.03.08 15:16:19 +0100, Peter Zijlstra wrote:
> On Wed, Mar 08, 2023 at 11:15:01AM +0800, Zhenyu Wang wrote:
> > It's easier to use hexidecimal value instead of decimal for reading
> > and following with SDM doc, also align with other cpuid calls.
>=20
> *shrug*..
>=20
> > Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> > ---
> >  arch/x86/events/intel/core.c | 2 +-
> >  arch/x86/events/intel/lbr.c  | 2 +-
> >  arch/x86/events/intel/pt.c   | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> >=20
> > diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
> > index 14f0a746257d..5af084198c8f 100644
> > --- a/arch/x86/events/intel/core.c
> > +++ b/arch/x86/events/intel/core.c
> > @@ -5903,7 +5903,7 @@ __init int intel_pmu_init(void)
> >  	 * Check whether the Architectural PerfMon supports
> >  	 * Branch Misses Retired hw_event or not.
> >  	 */
> > -	cpuid(10, &eax.full, &ebx.full, &fixed_mask, &edx.full);
> > +	cpuid(0xA, &eax.full, &ebx.full, &fixed_mask, &edx.full);
> >  	if (eax.split.mask_length < ARCH_PERFMON_EVENTS_COUNT)
> >  		return -ENODEV;
>=20
> But now the data type names and the cpuid calls are no longer related.

oh, right, missed that. How about we change those too e.g union cpuid_0xa_e=
ax?

--kQDGHQ6bVW4X2LBn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCZAk66gAKCRCxBBozTXgY
J4QVAKCNg0g+Y2/f8QRFEGaBrIpkUGZlTQCfYKWjU6RQJ+qpiSaMzkkaUJz9oUU=
=BvZw
-----END PGP SIGNATURE-----

--kQDGHQ6bVW4X2LBn--