Message-ID: <0db9e2b9-e5ed-e817-bd3f-9812fd914c97@bytedance.com>
Date:   Thu, 9 Mar 2023 10:09:07 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH] maple_tree: Fix the error of mas->min/max in
 mas_skip_node()
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Liam.Howlett@oracle.com, snild@sony.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org,
        Stable@vger.kernel.org
References: <20230307160340.57074-1-zhangpeng.00@bytedance.com>
 <20230308175552.60b3f6a3efda2289dc6c5bc9@linux-foundation.org>
From:   Peng Zhang <zhangpeng.00@bytedance.com>
In-Reply-To: <20230308175552.60b3f6a3efda2289dc6c5bc9@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/3/9 09:55, Andrew Morton 写道:
> On Wed,  8 Mar 2023 00:03:40 +0800 Peng Zhang <zhangpeng.00@bytedance.com> wrote:
>
>> The assignment of mas->min and mas->max is wrong. mas->min and mas->max
>> should represent the range of the current node. After mas_ascend()
>> returns, mas-min and mas->max already represent the range of the current
>> node, so we should delete these assignments of mas->min and mas->max.
>>
> Please fully describe the user-visible effects of the flaw, especially
> when proposing a -stable backport.
>
The fixes made by this patch have been included in 
https://lore.kernel.org/lkml/20230307180247.2220303-2-Liam.Howlett@oracle.com/, 
so please don't pay attention.