Date:   Wed, 8 Mar 2023 19:56:30 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     ye.xingchen@zte.com.cn
Cc:     keescook@chromium.org, yzaikin@google.com,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V3 2/2] mm: =?iso-8859-1?Q?comp?=
 =?iso-8859-1?Q?action=3A_limit_illegal_input_parameters_of=A0compact=5Fme?=
 =?iso-8859-1?Q?mory?= interface
Message-ID: <ZAlY7jsj4daalgcY@bombadil.infradead.org>
References: <202303091142580726760@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202303091142580726760@zte.com.cn>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Thu, Mar 09, 2023 at 11:42:58AM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Available only when CONFIG_COMPACTION is set. When 1 is written to
> the file, all zones are compacted such that free memory is available
> in contiguous blocks where possible.
> But echo others-parameter > compact_memory, this function will be
> triggered by writing parameters to the interface.
> 
> Applied this patch,
> sh/$ echo 1.1 > /proc/sys/vm/compact_memory
> sh/$ sh: write error: Invalid argument

Didn't echo 2 > /proc/sys/vm/compact_memory used to work too?

Why kill that? Did the docs say only 1 was possible? If not
perhaps the docs need to be updated?

  Luis