Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9616C6FD1F for ; Thu, 9 Mar 2023 05:27:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229800AbjCIF1B (ORCPT ); Thu, 9 Mar 2023 00:27:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbjCIF0v (ORCPT ); Thu, 9 Mar 2023 00:26:51 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D33D5D90FC for ; Wed, 8 Mar 2023 21:26:38 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id bo22so1060017pjb.4 for ; Wed, 08 Mar 2023 21:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1678339598; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7PHhOk68Epn8sZnX7ndPf6NL58OBP8K6CT8Y40D6SQo=; b=Owc+CejdKAiIxpkuNN0LQAi/h98JsQFPO/Gl6NTildpWJk/MiskjPp1ADoY8Gncq0F VrY8pXBIEpE8R8gv8WabR5HMvv7AKQC/HTcewt8fZv3xBIF6VSMua8qbbIYIwFjFO+ku wm7fL9kjFyVXWBib+mp9jk7rGeKKWgxPGNpDw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678339598; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7PHhOk68Epn8sZnX7ndPf6NL58OBP8K6CT8Y40D6SQo=; b=gsqCEHHVFv5v285JXSYAHgISkacW8axhHTPy+5jfvOgY4htbJhxvuMnqMtnWFQPmRY pSc6StrtX0gx80vCzl3g5AjJiCEufmX3B6zYzZaXGoiwu1M8p/Uef8BrfZto+tvukCmi ArMPguKc6OJe15p511oIWVqEfjzCpkGzmg33yYiViI/YBkB3vqy6kkGEm2OIsTZDe33P cbmz2Aop+svNoi9eM5YZhFy6Gt+40o619EIUMni0gFOIIl3hAuumCziX049YCn9/SKUe SP2kndx5LEsykd6+9M0rQrEbOHm906bBPvgTdOGjzXJRKkLqIMBar/6MMyUlzfihMQw4 612g== X-Gm-Message-State: AO0yUKVEXQ/ds19QOWcIlBa0+U5qP9IqeT+CUy5l2dYtyOBWbX77snO3 +4Kf4mY3OFofdc2lj1jVhPoEMQ== X-Google-Smtp-Source: AK7set+5aarIJYSkwKmjQ0zp1CFKUeE/Ilhd8ehTbVzuM0qW9cCIsXCh/go4SPJpfZnVdPKGQULTkw== X-Received: by 2002:a05:6a20:244f:b0:cc:7106:b84b with SMTP id t15-20020a056a20244f00b000cc7106b84bmr24983089pzc.29.1678339598231; Wed, 08 Mar 2023 21:26:38 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id 19-20020a631253000000b004fb171df68fsm9776967pgs.7.2023.03.08.21.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 21:26:37 -0800 (PST) Date: Thu, 9 Mar 2023 14:26:33 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Laurent Pinchart , Mauro Carvalho Chehab , "hn.chen" , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH RESEND v5 4/5] media: uvcvideo: Refactor clock circular buffer Message-ID: <20230309052633.GA1045797@google.com> References: <20220920-resend-hwtimestamp-v5-0-139d1a144614@chromium.org> <20220920-resend-hwtimestamp-v5-4-139d1a144614@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920-resend-hwtimestamp-v5-4-139d1a144614@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (23/03/08 23:45), Ricardo Ribalda wrote: > > Isolate all the changes related to the clock circular buffer to its own > function, that way we can make changes easier to the buffer logic. > > Also simplify the lock, by removing the circular buffer clock handling > from uvc_video_clock_decode(). > > And now that we are at it, unify the API of the clock functions. > > Tested-by: HungNien Chen > Signed-off-by: Ricardo Ribalda Reviewed-by: Sergey Senozhatsky