Message-ID: <49f2c8df-0578-b99e-8687-d77047bd5a33@huawei.com>
Date:   Thu, 9 Mar 2023 14:03:39 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] mm: memory-failure: Move memory failure sysctls to its
 own file
Content-Language: en-US
To:     =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= 
        <naoya.horiguchi@nec.com>
CC:     Luis Chamberlain <mcgrof@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Miaohe Lin <linmiaohe@huawei.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>
References: <20230309045924.52395-1-wangkefeng.wang@huawei.com>
 <20230309051439.GA4018963@hori.linux.bs1.fc.nec.co.jp>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <20230309051439.GA4018963@hori.linux.bs1.fc.nec.co.jp>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2023/3/9 13:14, HORIGUCHI NAOYA(堀口 直也) wrote:
> On Thu, Mar 09, 2023 at 12:59:24PM +0800, Kefeng Wang wrote:
>> The sysctl_memory_failure_early_kill and memory_failure_recovery
>> are only used in memory-failure.c, move them to its own file.
> 
> Thank you for the patch.
> 
> Could you explain the benefit to move them?
> We seem to have many other parameters in kernel/sysctl.c which are used
> only in single places, so why do we handle these two differently?
> 

Actually, all of them need to be moved into theirs own file as required
by proc sysctl maintainer, see [1]

> Thanks,
> Naoya Horiguchi

[1] https://lore.kernel.org/all/20211123202347.818157-1-mcgrof@kernel.org/