Message-ID: <49f21605-46f8-8a53-cde3-3d8270ea576a@linaro.org>
Date:   Thu, 9 Mar 2023 07:19:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 15/27] memory: tegra: remove MODULE_LICENSE in non-modules
Content-Language: en-US
To:     Nick Alcock <nick.alcock@oracle.com>
Cc:     mcgrof@kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        linux-tegra@vger.kernel.org
References: <20230224150811.80316-1-nick.alcock@oracle.com>
 <20230224150811.80316-16-nick.alcock@oracle.com>
 <c6f39365-e840-d782-8ec0-e34ec3681b98@linaro.org>
 <acc27e8f-73ce-39ee-3666-461f5c72d39d@linaro.org>
 <87h6ux7qhp.fsf@esperi.org.uk>
 <16bee433-0088-d651-9592-96a2bb827b7f@linaro.org>
 <87zg8n3s9m.fsf@esperi.org.uk>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <87zg8n3s9m.fsf@esperi.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/03/2023 21:25, Nick Alcock wrote:
> On 6 Mar 2023, Krzysztof Kozlowski stated:
> 
>> On 06/03/2023 18:13, Nick Alcock wrote:
>>> On 6 Mar 2023, Krzysztof Kozlowski told this:
>>>
>>>> On 06/03/2023 15:30, Krzysztof Kozlowski wrote:
>>>>> On 24/02/2023 16:07, Nick Alcock wrote:
>>>>>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>>>>>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>>>>>> are used to identify modules. As a consequence, uses of the macro
>>>>>> in non-modules will cause modprobe to misidentify their containing
>>>>>> object file as a module when it is not (false positives), and modprobe
>>>>>> might succeed rather than failing with a suitable error message.
>>>>>>
>>>>>> So remove it in the files in this commit, none of which can be built as
>>>>>> modules.
>>>>>
>>>>> Applied as well. Squashed with next one. Same subject messes with b4, so
>>>>> prefix should be corrected if these were to stay as separate patches.
>>>>
>>>> And all dropped. Run checkpatch before sending patches.
>>>
>>> So... which of the 27 patches n this series is being dropped? It would
>>> also be nice to know what the checkpatch problems were, because all I
>>> can see from checkpatch is one error per patch, an apparent false
>>
>> The ones I responded that I applied - so the memory controller ones.
> 
> OK, resent those three (now two), checkpatch-clean and fused identical
> subjects together. (Not adjusted non-memory-controller patch commit
> logs, to avoid causing disruption with those that are already flowing
> into the tree.)
> 
> Hope this is better :)

If you send a new patch, mark it appropriately and include changelog.

Best regards,
Krzysztof