MIME-Version: 1.0
References: <20230309035641.3439953-1-zyytlz.wz@163.com> <ec579c96-9955-f317-b37a-4f3fcd0c206e@huawei.com>
 <c9bafa3d-12ba-e9fe-8606-8160a8c42517@huawei.com>
In-Reply-To: <c9bafa3d-12ba-e9fe-8606-8160a8c42517@huawei.com>
From:   Zheng Hacker <hackerzheng666@gmail.com>
Date:   Thu, 9 Mar 2023 15:26:54 +0800
Message-ID: <CAJedcCyUW7h+5AY8BRN13S3wEMXM2tv0ioxFF3nKKM88g7Zmtw@mail.gmail.com>
Subject: Re: [PATCH] net: calxeda: fix race condition in xgmac_remove due to
 unfinshed work
To:     Yunsheng Lin <linyunsheng@huawei.com>
Cc:     Zheng Wang <zyytlz.wz@163.com>, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        1395428693sheep@gmail.com, alex000young@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Yunsheng Lin <linyunsheng@huawei.com> =E4=BA=8E2023=E5=B9=B43=E6=9C=889=E6=
=97=A5=E5=91=A8=E5=9B=9B 14:27=E5=86=99=E9=81=93=EF=BC=9A
>
> On 2023/3/9 14:23, Yunsheng Lin wrote:
> > On 2023/3/9 11:56, Zheng Wang wrote:
> >> In xgmac_probe, the priv->tx_timeout_work is bound with
> >> xgmac_tx_timeout_work. In xgmac_remove, if there is an
> >> unfinished work, there might be a race condition that
> >> priv->base was written byte after iounmap it.
> >>
> >> Fix it by finishing the work before cleanup.
> >
> > This should go to net branch, so title should be:
> >
> >  [PATCH net] net: calxeda: fix race condition in xgmac_remove due to un=
finshed work
>
> typo error:
> unfinshed -> unfinished
>

Got it. Will correct it in the next version of patch.

Thanks,
Zheng