From:   "Aakarsh Jain" <aakarsh.jain@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Cc:     <m.szyprowski@samsung.com>, <andrzej.hajda@intel.com>,
        <mchehab@kernel.org>, <hverkuil-cisco@xs4all.nl>,
        <ezequiel@vanguardiasur.com.ar>, <jernej.skrabec@gmail.com>,
        <benjamin.gaignard@collabora.com>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <stanimir.varbanov@linaro.org>, <dillon.minfei@gmail.com>,
        <david.plowman@raspberrypi.com>, <mark.rutland@arm.com>,
        <robh+dt@kernel.org>, <krzk+dt@kernel.org>, <andi@etezian.org>,
        <alim.akhtar@samsung.com>, <aswani.reddy@samsung.com>,
        <pankaj.dubey@samsung.com>
In-Reply-To: <9b93849d-d4a4-67ba-e8a0-ee6c7209bd65@linaro.org>
Subject: RE: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to
 json-schema
Date:   Thu, 9 Mar 2023 12:52:27 +0530
Message-ID: <000701d95257$e97ebd50$bc7c37f0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHxIgKtygHqPU4mHAhqu15r4A65nwLsA7LZAklDK9wB4osi/QJmoqxPrnZwD0A=
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20230301035153epcas5p40f576188a9a69835c1050135219a3720@epcas5p4.samsung.com>
        <20230301035144.8645-1-aakarsh.jain@samsung.com>
        <8b5bea40-6f7b-1d00-ac23-83a28c7dacbc@linaro.org>
        <046b01d94d1a$418146a0$c483d3e0$@samsung.com>
        <9b93849d-d4a4-67ba-e8a0-ee6c7209bd65@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=5D
> Sent: 09 March 2023 12:15
> To: Aakarsh Jain <aakarsh.jain=40samsung.com>; linux-arm-
> kernel=40lists.infradead.org; linux-media=40vger.kernel.org; linux-
> kernel=40vger.kernel.org; devicetree=40vger.kernel.org
> Cc: m.szyprowski=40samsung.com; andrzej.hajda=40intel.com;
> mchehab=40kernel.org; hverkuil-cisco=40xs4all.nl;
> ezequiel=40vanguardiasur.com.ar; jernej.skrabec=40gmail.com;
> benjamin.gaignard=40collabora.com; krzysztof.kozlowski+dt=40linaro.org;
> stanimir.varbanov=40linaro.org; dillon.minfei=40gmail.com;
> david.plowman=40raspberrypi.com; mark.rutland=40arm.com;
> robh+dt=40kernel.org; krzk+dt=40kernel.org; andi=40etezian.org;
> alim.akhtar=40samsung.com; aswani.reddy=40samsung.com;
> pankaj.dubey=40samsung.com
> Subject: Re: =5BPatch v6=5D dt-bindings: media: s5p-mfc: convert bindings=
 to json-
> schema
>=20
> On 02/03/2023 16:18, Aakarsh Jain wrote:
> >>
> >> iommus:
> >>   maxItems: 1
> >> iommu-names: false
> >>
> > I am getting compilation errors with above property set and its breakin=
g the
> bindings.
> > If we see these two nodes in dtsi files.
> >                mfc: codec=4013400000 =7B
> >                         compatible =3D =22samsung,mfc-v5=22; ..
> >                         iommus =3D <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;
> >                         iommu-names =3D =22left=22, =22right=22; =7D An=
d
> >               mfc: codec=4013400000 =7B
> >                         compatible =3D =22samsung,exynos3250-mfc=22, =
=22samsung,mfc-v7=22;
> >                         reg =3D <0x13400000 0x10000>; ...
> >                         iommus =3D <&sysmmu_mfc>;
> >                 =7D;
> > There is no iommu-names property for compatible =22samsung,exynos3250-
> mfc, samsung,mfc-v7=22, that=E2=80=99s=20why=20I=20kept=0D=0A>=20>=20=20=
=20=20=20=20=20=20=20iommus:=0D=0A>=20>=20=20=20=20=20=20=20=20=20=20=20min=
Items:=201=0D=0A>=20>=20=20=20=20=20=20=20=20=20=20=20maxItems:=202=0D=0A>=
=20>=20I=20would=20even=20go=20with=20below=20if=20you=20agree?=0D=0A>=20>=
=20=20=20=20=20=20=20=20=20iommus:=0D=0A>=20>=20=20=20=20=20=20=20=20=20=20=
=20minItems:=201=0D=0A>=20>=20=20=20=20=20=20=20=20=20=20=20maxItems:=202=
=0D=0A>=20>=20=20=20=20=20=20=20=20=20iommus-names:=20false=0D=0A>=20=0D=0A=
>=20No,=20I=20don't=20agree.=20Why=20do=20you=20need=20two=20IOMMUs=20for=
=20Exynos3250?=0D=0A>=20>=0D=0AHere=20IOMMUs=20minItems:1=20is=20meant=20fo=
r=20Exynos3250=20while=20IOMMUs=20maxItems:2=20meant=20for=20samsung,mfc-v5=
(Exynos=204).=0D=0AAs=20you=20suggested=20=0D=0Aiommus:=0D=0A=20=20maxItems=
:=201=0D=0Aiommu-names:=20false=0D=0A=0D=0Awon't=20fit=20here.=0D=0ASince=
=20IOMMUs=20maxItems=20is=202=20here=20for=20Exynos4.=20Giving=20maxItems:2=
=20alone=20will=20also=20break=20the=20bindings.=20Thanks=20why=20suggested=
=0D=0A=20=20=20=20=20=20=20=20=20iommus:=0D=0A=20=20=20=20=20=20=20=20=20=
=20=20minItems:=201=0D=0A=20=20=20=20=20=20=20=20=20=20=20maxItems:=202=0D=
=0A>=20=0D=0A>=20Best=20regards,=0D=0A>=20Krzysztof=0D=0A=0D=0A=0D=0A