From:   Yangtao Li <frank.li@vivo.com>
To:     zbestahu@gmail.com
Cc:     chao@kernel.org, huyue2@coolpad.com, jefflexu@linux.alibaba.com,
        linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        xiang@kernel.org, zhangwen@coolpad.com
Subject: Re: erofs: use wrapper i_blocksize() in erofs_file_read_iter()
Date:   Thu,  9 Mar 2023 15:42:25 +0800
Message-Id: <20230309074225.29404-1-frank.li@vivo.com>
In-Reply-To: <bee8eb33-ec23-de1c-0340-b2cc290f4d1c@linux.alibaba.com>
References: <bee8eb33-ec23-de1c-0340-b2cc290f4d1c@linux.alibaba.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nnKqqnffAgg1HMvMQtlmwaf/3oFAbUWkI4v4U8Nh5mp+wk+hykA5ky51ZinW?=
 =?us-ascii?Q?NmA3O+cHp5TTkjEuscTYKeRueSNkYTufJj5q7NGS3fPrpCK3fn8fLU8rhmV9?=
 =?us-ascii?Q?uNOOImRnQ38oCs7rB8rV6OihdRbYI7B4MN2qL6K9BahSLue4i1tuHqtE11Vh?=
 =?us-ascii?Q?LfcTblR3dGMESFntjW7/vImqxvrvWrk2T4UIGNq6tmTM8SPTRv+44vqkKxO6?=
 =?us-ascii?Q?cTlQy7w7UtbEUcAXDtAVrSXu10fhNqGfG9SLcNxPVxZKgBrbdQYKZBwYWtkm?=
 =?us-ascii?Q?dRVjiL8lW2mtUZNStR05wZ/PPjfMIH+PXqHWu00eLe6OHCIV7+3FOmqZaq2Q?=
 =?us-ascii?Q?oupfxOVzcN8gIQwKrb7vjCfFAClWA79bqNUbO2QsPfYTMXmOYOOvYTVYY6cx?=
 =?us-ascii?Q?zyA7M388chCXvZ0v9S62DFX+KIgSq0mvsf0q24IaBDNxgbklTSJjcJjwmLep?=
 =?us-ascii?Q?M47rONXOjClIJqQBgSYqcd999rzcUf01exQqRgtgCwEMiiCU5sy1fN4IO1AQ?=
 =?us-ascii?Q?wxmpEWoP2l/bJ85OEGS+BETT4qJu6OjO8Zt9V7LvRZP7HGrX/VrCN1zuEiGE?=
 =?us-ascii?Q?S1AYmFAsNHvdpK2hmz+pH4QiP11NZRBFBkXJVMdjsYcx4N4BzJIBXXu0I5E7?=
 =?us-ascii?Q?3xI1e5HEtVu8E/Mh+rTQQLExJDORgpbXnm2MGJpai/tww+7/6v2cEOWK2/Ox?=
 =?us-ascii?Q?oPPvd+VTDyrDnMzn4OxKpeoWwQ6itnRKVdXLYulZZaHG0hoxiU/qARJU45cj?=
 =?us-ascii?Q?06zw3b+k4lUMFMNEtdSCNuSd2UPbvrXwaNyOwf/wBLU0YD4Qjxo2fV3kdnW3?=
 =?us-ascii?Q?3+IuTL+MIO3Z503exaPAB3ovR/Om9BuRH33Cxw4S5breaZbU0wTcm10eiGRa?=
 =?us-ascii?Q?7xG95YvqVXBAFiCdoV4DhV4I++kh1zdooxw4XVhfEEdbm9LqH+lkpo2P6TNH?=
 =?us-ascii?Q?WR09dw/t/rQzFrDVmxYDNFYv/HGUUrEnf/YvAHLqayNsGopb/nYYftNHA0BA?=
 =?us-ascii?Q?UFH2dEWUQMMLUy9ndeoQDx7WQYeL0e2fT3PS03xJYGUsH8QdlkXHZhA0C5yI?=
 =?us-ascii?Q?M+1QOhiSG639eFZdVpZlAbbTfLUPtCLRiNxoln7xtyL6pecsHCFHwsysoEY9?=
 =?us-ascii?Q?KvUgmLf27F0dgfolqpdbwsLUU36Vfeyy8ZVzYAtbFrSIJVNEnHG3ftkzQAg5?=
 =?us-ascii?Q?CF+CnK3CnYgZLPEgZVjNDaitQLNnk/3/ko2umfOzFx3Ti3UWeo9ZmMeKAyyz?=
 =?us-ascii?Q?YgBJKS4VA6r8S5qfTbioUZ3Td1mOz56vvRkYT7IRipoBgJshV0tgrgxALX+R?=
 =?us-ascii?Q?RWrCRin2ALnylnox95ShoKFZEuwS+8lFiF47qbXYCHnITh5clFC0YzIcR7nN?=
 =?us-ascii?Q?Hd4LOzGWya5XLBpEjhlOFwd96OxFksuKQHWEHA+4x5wgiw9hJJ2btZ70+6vX?=
 =?us-ascii?Q?rQbu9Nq4b2YRwhr+Cnk/Ssontgsil84FuJRlrwC8qGt/om+mTl865AlqlTFd?=
 =?us-ascii?Q?Sq7wneERHfuK4+lz915cekLDxef6ObBZby7BPlG6HrLOoWBhRDsyaoxrNddq?=
 =?us-ascii?Q?IRpqP1T1WeQ2R1odfpZeXqzo7uNX186aYxmNkIHI?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91a14d34-aa09-4701-3b6e-08db2071d8b0
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB5275.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 07:42:34.3128
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iu0RWUlloy69WZakEKQaGus/E3ut9BN7Akewz8KlwaZ+QMCgRrfINgKb17hMAqYNwm5x+Or4HCYYdbAUhVvLQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB6032
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> FYI it seems that GENMASK macro is widely used in driver and arch code base, while it's rarely used in fs, except for f2fs.

I think the following usage can be changed to bitmap api, just like in f2fs?
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c4ca1f7164734a1baf40d4ff1552172a07d4fc4d

fs/erofs/fscache.c:135:         unsigned long flags = 1 << NETFS_SREQ_ONDEMAND;
fs/erofs/internal.h:250:#define SECTORS_PER_BLOCK       (1 << SECTORS_PER_BLOCK)
fs/erofs/internal.h:252:#define EROFS_BLKSIZ            (1 << LOG_BLOCK_SIZE)
fs/erofs/internal.h:354:        return (value >> bit) & ((1 << bits) - 1);
fs/erofs/zmap.c:66:             ((1 << Z_EROFS_VLE_DI_CLUSTER_TYPE_BITS) - 1);
fs/erofs/zmap.c:69:             m->clusterofs = 1 << vi->z_logical_clusterbits;
fs/erofs/zmap.c:114:    const unsigned int lomask = (1 << lclusterbits) - 1;
fs/erofs/zmap.c:141:    const unsigned int lomask = (1 << lclusterbits) - 1;
fs/erofs/zmap.c:147:    if (1 << amortizedshift == 4)
fs/erofs/zmap.c:149:    else if (1 << amortizedshift == 2 && lclusterbits == 12)
fs/erofs/zmap.c:169:            m->clusterofs = 1 << lclusterbits;
fs/erofs/zmap.c:291:    pos += lcn * (1 << amortizedshift);
fs/erofs/zmap.c:409:            m->compressedblks = 1 << (lclusterbits - LOG_BLOCK_SIZE);
fs/erofs/zmap.c:457:                              m->clusterofs != 1 << lclusterbits);
fs/erofs/zmap.c:497:    endoff = ofs & ((1 << lclusterbits) - 1);
fs/erofs/erofs_fs.h:120:        ((1 << (EROFS_I_DATALAYOUT_BIT + EROFS_I_DATALAYOUT_BITS)) - 1)
fs/erofs/erofs_fs.h:279:#define Z_EROFS_ALL_COMPR_ALGS          ((1 << Z_EROFS_COMPRESSION_MAX) - 1)
fs/erofs/erofs_fs.h:377:#define Z_EROFS_VLE_DI_PARTIAL_REF              (1 << 15)
fs/erofs/erofs_fs.h:384:#define Z_EROFS_VLE_DI_D0_CBLKCNT               (1 << 11)
fs/erofs/erofs_fs.h:427:                .h_clusterbits = 1 << Z_EROFS_FRAGMENT_INODE_BIT
fs/erofs/data.c:379:                    blksize_mask = (1 << inode->i_blkbits) - 1;
fs/erofs/zdata.c:133:#define Z_EROFS_PAGE_EIO                   (1 << 30)

Thx,
Yangtao