Subject: Re: [PATCH -next] raid10: fix leak of io accounting
To:     Guoqing Jiang <guoqing.jiang@linux.dev>,
        Yu Kuai <yukuai1@huaweicloud.com>, song@kernel.org
Cc:     linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
        yi.zhang@huawei.com, yangerkun@huawei.com,
        "yukuai (C)" <yukuai3@huawei.com>
References: <20230304070133.1134975-1-yukuai1@huaweicloud.com>
 <a2551c50-feea-bcbe-00ed-802456b5a19f@linux.dev>
 <76d32496-641e-c93a-df77-9ce9d9c1a1e1@huaweicloud.com>
 <fbbb46dc-ac07-9a99-dece-f0077a9fd491@linux.dev>
From:   Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <66e481e6-ed2c-2ac2-bdd0-9e20a0ec9771@huaweicloud.com>
Date:   Thu, 9 Mar 2023 15:45:25 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <fbbb46dc-ac07-9a99-dece-f0077a9fd491@linux.dev>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

在 2023/03/09 15:27, Guoqing Jiang 写道:
> 
> 
> On 3/9/23 14:56, Yu Kuai wrote:
>> Hi,
>>
>> 在 2023/03/09 14:36, Guoqing Jiang 写道:
>>> Hi,
>>>
>>> What do you mean 'leak' here?
>>
>> I try to mean that inflight counting is leaked, because it's increased
>> twice for one io.
> 
> How about change the subject to something like?
> 
> 'md/raid10: Don't call bio_start_io_acct twice for bio which experienced 
> read error'
> 
Of course, I'll change that in v2.

>>
>>>
>>> On 3/4/23 15:01, Yu Kuai wrote:
>>>> From: Yu Kuai <yukuai3@huawei.com>
>>>>
>>>> handle_read_error() will resumit r10_bio by raid10_read_request(), 
>>>> which
>>>> will call bio_start_io_acct() again, while bio_end_io_acct() will only
>>>> be called once.
>>>>
>>>> Fix the problem by don't account io again from handle_read_error().
>>>
>>> My understanding is it caused inaccurate io stats for bio which had a 
>>> read
>>> error.
>>>
>>>> Fixes: 528bc2cf2fcc ("md/raid10: enable io accounting")
>>>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>>>> ---
>>>>   drivers/md/raid10.c | 8 ++++----
>>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
>>>> index 6c66357f92f5..4f8edb6ea3e2 100644
>>>> --- a/drivers/md/raid10.c
>>>> +++ b/drivers/md/raid10.c
>>>> @@ -1173,7 +1173,7 @@ static bool regular_request_wait(struct mddev 
>>>> *mddev, struct r10conf *conf,
>>>>   }
>>>>   static void raid10_read_request(struct mddev *mddev, struct bio *bio,
>>>> -                struct r10bio *r10_bio)
>>>> +                struct r10bio *r10_bio, bool handle_error)
>>>>   {
>>>>       struct r10conf *conf = mddev->private;
>>>>       struct bio *read_bio;
>>>> @@ -1244,7 +1244,7 @@ static void raid10_read_request(struct mddev 
>>>> *mddev, struct bio *bio,
>>>>       }
>>>>       slot = r10_bio->read_slot;
>>>> -    if (blk_queue_io_stat(bio->bi_bdev->bd_disk->queue))
>>>> +    if (!handle_error && 
>>>> blk_queue_io_stat(bio->bi_bdev->bd_disk->queue))
>>>>           r10_bio->start_time = bio_start_io_acct(bio);
>>>
>>> I think a simpler way is just check R10BIO_ReadError here.
>>
>> No, I'm afraid this is incorrect because handle_read_error clears the
>> state before resubmiting the r10bio.
> 
> Right,
> 
> Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev>

Thanks for the review.
Kuai
> 
> Thanks,
> Guoqing
> .
>