Message-ID: <81e78cf6-b8b3-0cab-d190-aa22abbc5c2d@linaro.org>
Date:   Thu, 9 Mar 2023 09:10:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to
 json-schema
Content-Language: en-US
To:     Aakarsh Jain <aakarsh.jain@samsung.com>,
        linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc:     m.szyprowski@samsung.com, andrzej.hajda@intel.com,
        mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
        ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com,
        benjamin.gaignard@collabora.com, krzysztof.kozlowski+dt@linaro.org,
        stanimir.varbanov@linaro.org, dillon.minfei@gmail.com,
        david.plowman@raspberrypi.com, mark.rutland@arm.com,
        robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org,
        alim.akhtar@samsung.com, aswani.reddy@samsung.com,
        pankaj.dubey@samsung.com
References: <CGME20230301035153epcas5p40f576188a9a69835c1050135219a3720@epcas5p4.samsung.com>
 <20230301035144.8645-1-aakarsh.jain@samsung.com>
 <8b5bea40-6f7b-1d00-ac23-83a28c7dacbc@linaro.org>
 <046b01d94d1a$418146a0$c483d3e0$@samsung.com>
 <9b93849d-d4a4-67ba-e8a0-ee6c7209bd65@linaro.org>
 <000701d95257$e97ebd50$bc7c37f0$@samsung.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <000701d95257$e97ebd50$bc7c37f0$@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 09/03/2023 08:22, Aakarsh Jain wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>> Sent: 09 March 2023 12:15
>> To: Aakarsh Jain <aakarsh.jain@samsung.com>; linux-arm-
>> kernel@lists.infradead.org; linux-media@vger.kernel.org; linux-
>> kernel@vger.kernel.org; devicetree@vger.kernel.org
>> Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com;
>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
>> ezequiel@vanguardiasur.com.ar; jernej.skrabec@gmail.com;
>> benjamin.gaignard@collabora.com; krzysztof.kozlowski+dt@linaro.org;
>> stanimir.varbanov@linaro.org; dillon.minfei@gmail.com;
>> david.plowman@raspberrypi.com; mark.rutland@arm.com;
>> robh+dt@kernel.org; krzk+dt@kernel.org; andi@etezian.org;
>> alim.akhtar@samsung.com; aswani.reddy@samsung.com;
>> pankaj.dubey@samsung.com
>> Subject: Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-
>> schema
>>
>> On 02/03/2023 16:18, Aakarsh Jain wrote:
>>>>
>>>> iommus:
>>>>   maxItems: 1
>>>> iommu-names: false
>>>>
>>> I am getting compilation errors with above property set and its breaking the
>> bindings.
>>> If we see these two nodes in dtsi files.
>>>                mfc: codec@13400000 {
>>>                         compatible = "samsung,mfc-v5"; ..
>>>                         iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;
>>>                         iommu-names = "left", "right"; } And
>>>               mfc: codec@13400000 {
>>>                         compatible = "samsung,exynos3250-mfc", "samsung,mfc-v7";
>>>                         reg = <0x13400000 0x10000>; ...
>>>                         iommus = <&sysmmu_mfc>;
>>>                 };
>>> There is no iommu-names property for compatible "samsung,exynos3250-
>> mfc, samsung,mfc-v7", that’s why I kept
>>>         iommus:
>>>           minItems: 1
>>>           maxItems: 2
>>> I would even go with below if you agree?
>>>         iommus:
>>>           minItems: 1
>>>           maxItems: 2
>>>         iommus-names: false
>>
>> No, I don't agree. Why do you need two IOMMUs for Exynos3250?
>>>
> Here IOMMUs minItems:1 is meant for Exynos3250 while IOMMUs maxItems:2 meant for samsung,mfc-v5(Exynos 4).
> As you suggested 
> iommus:
>   maxItems: 1
> iommu-names: false
> 
> won't fit here.
> Since IOMMUs maxItems is 2 here for Exynos4. Giving maxItems:2 alone will also break the bindings. Thanks why suggested
>          iommus:
>            minItems: 1
>            maxItems: 2

Are you sure you are putting this in correct place? This is if:then for
Exynos3250, isn't it?

Best regards,
Krzysztof