Message-ID: <92a9d8d4-17e8-6906-7640-e7b82787f74a@gmx.de>
Date:   Thu, 9 Mar 2023 09:15:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] fbdev: tgafb: Fix potential divide by zero
Content-Language: en-US
To:     Jani Nikula <jani.nikula@linux.intel.com>,
        harperchen <harperchen1110@gmail.com>
Cc:     linux-fbdev@vger.kernel.org, javierm@redhat.com,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        wsa+renesas@sang-engineering.com, tzimmermann@suse.de
References: <20230307130856.2295182-1-harperchen1110@gmail.com>
 <123a52d8-baf0-e32b-3262-1e8619b1c3ad@gmx.de> <87cz5ibbsb.fsf@intel.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <87cz5ibbsb.fsf@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:2VHdQPL2u6I=;Zz0nv2YwIpMpg2VExAg0Ek0dLaG
 X1yKox28FcOEv429jj6audC1B9abgYLOfP8Q9hN0yyr+zUdHSnv0kFMC0PwjytiQ8QUEWHGEt
 X4DfcW+wjOji86N0hW5uYUtcRcMoOundn2J2Reec2wYjAYm0DdEJzbRQ992sXN6sW+QtpV2aZ
 LMpPOAOsvhSq/XPmdLbAOYo5B7b9KK4bxW2MTilAhhZN0078HmhRNw+oZWIfZB6kYDUr4XGQH
 kj7RXYQmQfSe7hIixl6FdwnYOv3nf6Lt8gHfZn1+BMACEeTDgnNsBsMEoSzcSh4OggVUKQGqk
 y6TS1s9W1tW8Td4wEfNPCdt0d1808RPKYUs6J54pS8meiIVkSdXrxEuMp0FNwwNA11NyVHuMA
 EenUNgRW2uhUNrWQsvDWc3qDT+Swn6KpefIO5XgX9RDb0KmzDaTWC91cTxTNyXq76Quqjo6xq
 FECxyQTAIIcBKqY184bdUTuvcnaYVODq5SC72gmCepAoUI9Qi68V05B5wxJGqP+OTGf53XJq1
 sP7Vze+oo7ONaXMm5qIimf1UAkTei8y7LkY7VhC8abcBsQamt04Ybb6krQR5MVT3LmY8eX924
 Ecig3vqP0HQyeGnPzWXDtFT5nV+ffPR6yfKPVa7ZfC2uKgUZANfzeniTMgFHm1jcutsMMlr8W
 tQIpsbYs4qSIqyMDLBo9SwVffcogJ8qrdNQEE541U0VWvh0jDUFdmd24gMFe8rLkVoQ+5eihM
 PhHiaCoNdfXy8uB/GgPaVutqUdt21OU074TlsN31IosmH/hN6ookrUdEprhspeErZXs7ZFnIN
 3D8OTSDjAxPso2aDEqSV0bV3D0TrYbqDn8H2WCqTvitf8XGCI6900/Mh5QczLi6aK0Z2o3UIS
 2cYQLxl4VRL2hQ1E4fQEuArXOgbDWaaUrbfpIdUcZRlbpA0jIGOWjxVr28CyKWxcb96HZlxdX
 CKdozg==
Precedence: bulk

On 3/9/23 08:53, Jani Nikula wrote:
> On Wed, 08 Mar 2023, Helge Deller <deller@gmx.de> wrote:
>> On 3/7/23 14:08, harperchen wrote:
>>> fb_set_var would by called when user invokes ioctl with cmd
>>> FBIOPUT_VSCREENINFO. User-provided data would finally reach
>>> tgafb_check_var. In case var->pixclock is assigned to zero,
>>> divide by zero would occur when checking whether reciprocal
>>> of var->pixclock is too high.
>>>
>>> Similar crashes have happened in other fbdev drivers. There
>>> is no check and modification on var->pixclock along the call
>>> chain to tgafb_check_var. We believe it could also be triggered
>>> in driver tgafb from user site.
>>>
>>> Signed-off-by: harperchen <harperchen1110@gmail.com>
>>
>> Could you provide a real name?
>> Otherwise applied to fbdev git tree.
>
> See commit d4563201f33a ("Documentation: simplify and clarify DCO
> contribution example language").

Nice. Thanks for that link!
Btw, I did applied that patch yesterday to my tree with just the nickname,
but of course I do prefer real names which is why I asked.

Helge