Date:   Thu, 9 Mar 2023 16:21:11 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     kernel test robot <yujie.liu@intel.com>
CC:     Zhang Qiao <zhangqiao22@huawei.com>, <oe-lkp@lists.linux.dev>,
        <lkp@intel.com>, <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Roman Kagan <rkagan@amazon.de>, <ying.huang@intel.com>,
        <feng.tang@intel.com>, <zhengjun.xing@linux.intel.com>,
        <fengwei.yin@intel.com>,
        Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [linus:master] [sched/fair] 829c1651e9: hackbench.throughput
 -7.9% regression
Message-ID: <ZAmW99UdQQEncV2l@chenyu5-mobl1>
References: <202303091155.672f546a-yujie.liu@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202303091155.672f546a-yujie.liu@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?taoL2nrSXcjyISYB2INoVIhP4wXwEkHPMIJ61SF3+r7M8bsgQAjHZufuqk?=
 =?iso-8859-1?Q?eMqjOavwN6OqpSTTu0OM5RlW1o9M8pEJGy56OXNwmb2YXIl/ZSH8dzRfQe?=
 =?iso-8859-1?Q?S4acH6SDkoZaHzkGKV5H3/7+rlskgQOY9MQu0V6dqIzzuEQKik54PXP8hw?=
 =?iso-8859-1?Q?CKwmZ+QbZk7LVW6n77dpMmV4lgqBV6hptY8gi1OYPUw6vq70Q2ah0LUDqx?=
 =?iso-8859-1?Q?e4QU2KxQoC+2gVpxU94JnUsbcocI5e94eWYvDdvN7SuRaJY6uSehDT2J+D?=
 =?iso-8859-1?Q?HuU63+1iYbuWU/PDGbvqr8I48SMgo+PPoP06c124VxmCEU/BilECHLC0vh?=
 =?iso-8859-1?Q?Idfx+lZoHas6aZgLfyAXZYQ42o5r/48r42tLqo25opExaNU89WqWDnL7q3?=
 =?iso-8859-1?Q?BuqqxIiL8mnwB33Bk/8Iab0UKGEKxAIHc3wJaARKHQ1ZZAoZFFgyAJGhjt?=
 =?iso-8859-1?Q?BC8NB8NlSjo4q1kgbQ4syuKmv9HzD5KWUz3UMOfSLcItPfHDwTzNDe1X5I?=
 =?iso-8859-1?Q?ZY118M3Ib//2PEX4RPxaBrzszdvxEFWqjBwvqHpDuqIDTr7eutimef2uX+?=
 =?iso-8859-1?Q?QLZEK27zAPqZmVEyY6QdikHpQkeXEPR7YsX/xCRjqzRko3ZZowjB/gVrYC?=
 =?iso-8859-1?Q?bIKlQIKUVuGuApQwiXLP42OdYqCX3fhAnYifzweGW4/MMIRQZTsoqwBfqp?=
 =?iso-8859-1?Q?038tRtPsiDr++lGl1Y6HiQ6iSG6fYJcgD8afGDiHKSQfx3u/l2B/vZV6Ab?=
 =?iso-8859-1?Q?HzBI17JzVNyzM1WjYDSEvH3oTFqrkM9cd2jUIT1HknNw4Os5lkcZJY7fUq?=
 =?iso-8859-1?Q?iXH+f2mVW7PGrJ0AcRG7h6Uq5Mm8fGiJbfKBzU/qVeB/CdEbjikx7183Fa?=
 =?iso-8859-1?Q?Rqjb3Z4w8uBm5thlLAvjSKwjetvR1nVltQn5Jnp50Kd4S+WEkyYHRrCDj4?=
 =?iso-8859-1?Q?mVlPYO8qOXBffJWapBBLmVQZFSqm01y6CS3XARFks+piCQ77TLc3rV0ZUb?=
 =?iso-8859-1?Q?poxcn0Lv6WFGrTKfIRfiVrWZfRAfu4c4JjcnsxTUiyPmzFFieCpJIM/h/X?=
 =?iso-8859-1?Q?jAcGcZNUJGaFht5TeQXA011i5da72DnpTa7xMMfOYWdBwUw0OamPgb5NMj?=
 =?iso-8859-1?Q?jgM7z+86iAg/MeBuOyP3Hf2PzClRMDPAP57F+TjoBKhbvpBQp/NSZ0Bi8o?=
 =?iso-8859-1?Q?wxgXg97RPBZaBjBHbpN3CtFoFN3shYpIvjDD3YP6wbR7daMFxyRO9F8qAB?=
 =?iso-8859-1?Q?hmN4eTjIlUADK9dDBm1mL6sbG0qjHdtSP/Gb59f6G/LaUP74PSGH3sIyk9?=
 =?iso-8859-1?Q?/4+dkCQhEVjIPnactGKcljxxNfxhfMD/XtS1Rif8L1hjUPdOyoAf8VGO3C?=
 =?iso-8859-1?Q?KgQ1h3kaWgo0q2jSrBpDY+2tfsooV+jlz5zePL3+STwdRcztn2L1AA1fmV?=
 =?iso-8859-1?Q?rAJsLjvGH5mBry0+U93KXcgpCTn/lRV3tHLMSaj14Oocq+m5CiEKforFaS?=
 =?iso-8859-1?Q?hwP+0q3aLLO/WmkUrbOuALVOP24ArqqzMeBFHkK8V6H+N4Oz9lOR+pexr7?=
 =?iso-8859-1?Q?Ltwcuva7YRX7gIOxlmtOR/e0oWJVioNcP3hdRgjbmd6LAYo+zI9P6nWdw7?=
 =?iso-8859-1?Q?0hq9F/vcHgc7Lo59OUVkOKPppIuxhSBx9M?=
X-MS-Exchange-CrossTenant-Network-Message-Id: afdc193c-e026-4845-f4ad-08db20774bea
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 08:21:35.2442
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iYhYP6IwEFfh1dynZIzuBcSpNh4rwMRsqaIN0w6Di7o1hwMVCLf/WDHDjc9n7o2tYQxoNlTstMaNrm0OUaagag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7950
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-03-09 at 11:46:50 +0800, kernel test robot wrote:
> Greeting,
> 
> FYI, we noticed a -7.9% regression of hackbench.throughput due to commit:
> 
> commit: 829c1651e9c4a6f78398d3e67651cef9bb6b42cc ("sched/fair: sanitize vruntime of entity being placed")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> 
> in testcase: hackbench
> on test machine: 104 threads 2 sockets (Skylake) with 192G memory
> with following parameters:
> 
> 	nr_threads: 100%
> 	iterations: 4
> 	mode: process
> 	ipc: socket
> 	cpufreq_governor: performance
>
In theory the patch deals with a corner case that the task sleeps for more than 1 minute,
but this is not the case for hackbench, and it did increase the preemption:

 1.08e+08 ?  2%    +648.7%  8.084e+08 ?  5%  hackbench.time.involuntary_context_switches 

It might be an issue described and fixed here:
https://lore.kernel.org/lkml/20230306132418.50389-1-zhangqiao22@huawei.com/
https://lore.kernel.org/lkml/ZAiFxWLSb9HDazSI@vingu-book/
I'll check if above patch helps.

thanks,
Chenyu