Message-ID: <4e8235b8-9c2d-69e2-a965-b0787d016ef2@linaro.org>
Date:   Thu, 9 Mar 2023 09:52:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 2/2] thermal/drivers/imx: Use the thermal framework for
 the trip point
Content-Language: en-US
To:     Fabio Estevam <festevam@gmail.com>
Cc:     rafael@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>
References: <20230308214822.1317086-1-daniel.lezcano@linaro.org>
 <20230308214822.1317086-2-daniel.lezcano@linaro.org>
 <CAOMZO5CoYi2MpVLBqoKh7g9Dhjq77KfNy3QQNi2AawjGTrFZpw@mail.gmail.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <CAOMZO5CoYi2MpVLBqoKh7g9Dhjq77KfNy3QQNi2AawjGTrFZpw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 09/03/2023 02:11, Fabio Estevam wrote:
> Hi Daniel,
> 
> On Wed, Mar 8, 2023 at 6:48 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> 
>>          /* do not allow changing critical threshold */
>> -       if (trip == IMX_TRIP_CRITICAL)
>> +       if (trip.type == THERMAL_TRIP_CRITICAL)
>>                  return -EPERM;
>> -
>> +
> 
> Unrelated change?

The 'trip' is used as an index and it is checked against 
IMX_TRIP_CRITICAL which is a index in the array also. We replace that 
with the real type of trip point regardless its id.

But the extra line is a tab which was inserted, I will fix it.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog