Date:   Thu, 9 Mar 2023 17:10:48 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        "Lee Jones" <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        <linux-usb@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <srinivas.pandruvada@intel.com>,
        <heikki.krogerus@linux.intel.com>,
        <andriy.shevchenko@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <zhifeng.wang@intel.com>,
        <wentong.wu@intel.com>, <lixu.zhang@intel.com>
Subject: Re: [PATCH v4 1/5] mfd: Add support for Intel LJCA device
Message-ID: <ZAmimLMY49ktjagX@ye-NUC7i7DNHE>
References: <20230309071100.2856899-1-xiang.ye@intel.com>
 <20230309071100.2856899-2-xiang.ye@intel.com>
 <ZAmPjfH6rA0pbiUa@kroah.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZAmPjfH6rA0pbiUa@kroah.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BHiXBC18yZLotk+qwcrA+s1d8NX73zummMhAP31pIgyrFdBdPtrMsth5D6wA?=
 =?us-ascii?Q?TgmdwGNUNiLoJ3MPNx/irXJ9k/rpx1J5g0d9gNxvi+GRaXuJDzsEiJR2+k7x?=
 =?us-ascii?Q?kJntakFSOhsYkvMSsYD4k/1A+WQSurJzQn5bOYHblG3EXpkA7gztXJeHu145?=
 =?us-ascii?Q?RutlI+LZdhE9Zmczr8+iDEbBVJR564VULrE5YUCTW9EXknskQSrGPgswVrls?=
 =?us-ascii?Q?wYM8rCCVJ1bMh4/SuGh8AXdDjGFK0gxsUgUARmz9l6PWSxdHyQDGgUfTzcPH?=
 =?us-ascii?Q?dp97RFFYFK6wPtwQcBbdy7TwLFuZD4USrxy1toeQ2xy5PwEe5bqyEuain8UL?=
 =?us-ascii?Q?ejZwBhqrPmD5ZYzdi+P03Knbe4ghkazmATdzNmaUDLsCeyF8VNuulMLCVO9L?=
 =?us-ascii?Q?A0xrGvQLclyucDFV1n/3bzg/oIIGsKKvrAcabUzzHh51OlgBPNVewKH6uqAy?=
 =?us-ascii?Q?OaOWbFM4vfE242ojBTx8Co2WIo9Kf1fxrQas71YEqJPdk5gS+KigO91x86qz?=
 =?us-ascii?Q?O1gv9fVGOZR7AHhsg+Xjr46MqazTX4sxVlxE98MnH0Vz5zvUXOeMyZDDE/3T?=
 =?us-ascii?Q?17KwjBsz/PDmcMbYSvNnH5iOz4qA/HSMqFQGh1hTuiEE/mroTqnED7G6RQn9?=
 =?us-ascii?Q?CgLnEIuX07AVd7N5H27x7NJ+H8SVl5igpCjaMgD7lGKFygikjqbcVF+X/O9I?=
 =?us-ascii?Q?MiEFMw4Lkiv1zLePaq7OQOvj89fb4XJfMJtWxZ28znXzZF1wIce39t8Azdtw?=
 =?us-ascii?Q?JNkbGL6zdF+WlByLeibUmdNGXAdkTAug3KeFFewWDW2bcYx8bVcZn9/8g0v9?=
 =?us-ascii?Q?3KbATDFwkW2F1J+GDHIYHkVDqF4476pz95vCRMZYLoe17rFTTPFdoUmKng32?=
 =?us-ascii?Q?0Wwmfi2h/BSw3Ui+eTPyw7Fn9iM5EG5vcwtZzKmrx34PEgmei7kUv5GPfMJ9?=
 =?us-ascii?Q?BFo1b3FRxwNB/gbx8qlwLVqjfCHFsyZzgRrNWQO9VfyIyD/8oM5t9BDst5vS?=
 =?us-ascii?Q?Zi1FtlWqg0R8Ta/4EfL+kt97gQ7Bk6zHvt8wh1qYoL7HtRpGrmP78mQluPb5?=
 =?us-ascii?Q?ohEdxdCd/HciS/4xjjBVptecp/+k5g0wT9t/QtjFyrZNbMcndUEs6Ull4a9o?=
 =?us-ascii?Q?C+HgAoKKdWLReYPecTpM8Brp6mifTAnw4XbstbPt2IrI1atdCkkLqUG28KcQ?=
 =?us-ascii?Q?Kmjro3nrtvmyXgYqdiFww9GLOoMZu0SlBK3yyhpDUbz0PhuHSajzmEsXY5EK?=
 =?us-ascii?Q?Jai1yB/KACD/kJp6BMAGa9OaT0BfsOoL8mS7Ed1104YZAtp4MLq+y9kfOgeb?=
 =?us-ascii?Q?482aHlcposQXVE5FfB0MLqL0rTalYfTqc4uvhBHOyZBoWWO44ZVnLjaxOEUN?=
 =?us-ascii?Q?Oif3VsG25ZNLZEVPkl/BiGDcOHKwBNuEYcjwh1Gfh8OrwLN3xX+UdiNuF7wU?=
 =?us-ascii?Q?ge39dW8QpFyVwumnITON+UfufapVa6dqwmQzaPEABHi5RNzs6yKFL/ljX9Fj?=
 =?us-ascii?Q?mEegxg5plPq8dVhiHFz9thFQk3/WGpVsFRMrDvkpSHVoK0o3Z2jsOFWwrCdQ?=
 =?us-ascii?Q?RrNE6fwBScLBhOu/3Fq4K2EOzm9Y0znzGWrcgOb9?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bbdeb555-8485-4769-0916-08db207e30c7
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1418.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 09:10:56.3125
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eiOIrqnKd3p1XvEaG0KBCFt7SCiomyMvZp7iV3L0jX3URGTLC2QLS55qAqhsm/dyRFgfZI4M4dPYYnPi/FJRoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5264
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

Thanks for the review.
On Thu, Mar 09, 2023 at 08:49:33AM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 09, 2023 at 03:10:56PM +0800, Ye Xiang wrote:
> > This patch implements the USB part of Intel USB-I2C/GPIO/SPI adapter
> > device named "La Jolla Cove Adapter" (LJCA).
> 
> Then why is this called "mfd" in the subject line?
Sorry, it's a mistake. I forget to change mfd to usb in the commit message
because I just move the ljca.c from driver/mfd to drivers/usb/misc according
to previous review comments[1]. And I will address this on v5.

[1] https://www.spinics.net/lists/kernel/msg4708451.html
> 
> >  include/linux/mfd/ljca.h  |  95 ++++
> 
> Why is this .h file in the mfd directory?
It's a mistake as well. Will address it by moving include/linux/mfd/ljca.h
to include/linux/usb/ljca.h.
>
> thanks,
> 
> greg k-h

--
Thanks
Ye Xiang