Date:   Thu, 9 Mar 2023 18:00:57 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Arnd Bergmann <arnd@arndb.de>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>, <linux-usb@vger.kernel.org>,
        <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-spi@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <srinivas.pandruvada@intel.com>, <heikki.krogerus@linux.intel.com>,
        <andriy.shevchenko@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <zhifeng.wang@intel.com>,
        <wentong.wu@intel.com>, <lixu.zhang@intel.com>
Subject: Re: [PATCH v4 1/5] mfd: Add support for Intel LJCA device
Message-ID: <ZAmuWS+9dtz/T5rz@ye-NUC7i7DNHE>
References: <20230309071100.2856899-1-xiang.ye@intel.com>
 <20230309071100.2856899-2-xiang.ye@intel.com>
 <dcb805e1-2b48-481d-8e72-1b515c9d43e6@app.fastmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <dcb805e1-2b48-481d-8e72-1b515c9d43e6@app.fastmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1xMudd9KJLaWnuzsyvM/X43ptYvmJqoELrVX6/2GgsOjpjBA7pWY7Cp4WsEw?=
 =?us-ascii?Q?tX4Xg6laxP5e5z0FF5JmIiXECArg7YOHjvwN9hP+Sz/Kjmw2tVNycY01A1Y+?=
 =?us-ascii?Q?cgZMHuKknE7FFAQwqgWMZnuS7WJa9phrZH1y+zf6tCWmB3I19x7bRPnR8viR?=
 =?us-ascii?Q?m3D9mKk50qLvDeZdRYVJBfuDBKG7a3oqFAnNp2bQNneSfWVMg+vjp8SHgg9v?=
 =?us-ascii?Q?MQHz+xGi9sGXcKSA84Eeza6yYUIflebFrEw7MaR2fRXfLx/hMKnzeG2MWyea?=
 =?us-ascii?Q?IbS4gM4RLEOL4BzmkHKJiLvKiK3Yr/xctfEdh/WztxzOa8AixNudfeTq/Lbt?=
 =?us-ascii?Q?3VBtbi6OgamNuWwf6tDivpYnCh/Xa4eS2y+Vt4eLJ2Jv6J9INPcYsWM8Qyfe?=
 =?us-ascii?Q?wGoL/ugkH1ExIKsGaixY/gv64R1bX2eJnpBmniCkDzqyjkbD3QLGAMFNxaNt?=
 =?us-ascii?Q?+oV12V+AsibTq3Ojrmr4U1DYRShq1/ngQjGFynyqzeylFvlTeQuz/3M5s66q?=
 =?us-ascii?Q?easl50aFpeCfFfJVmVM/oM00Dt+A37DvdggQlgegzB+WXn0cmjihQJu/mrbx?=
 =?us-ascii?Q?UIat+PBj3manUxm7Zqr5wiM9o4zMjsOq8rm/3P+4NQo8iy3lxyT9Ql0f+E9S?=
 =?us-ascii?Q?/LrkhCcvQZRbdeDVubfW0q21Tc74Y15nxMQ3o7oXcOs/WTo94BnXdgplsB0U?=
 =?us-ascii?Q?ivaYpYsqMf1GRT0WhQu+ZTeSLFsATah4dWUIdWkOtt2dEwiHwEGHDKc8BQ8q?=
 =?us-ascii?Q?9NkyPUpaj1pM05ipqJwR82ZnYB8RXWHzEVFxmZaDftzPr793r5kkyxuBVzLb?=
 =?us-ascii?Q?0icx2OJWZUmPwAoENWdwgkkJVgXKWy7/PhlA2il8VEAxS5VGHIcj+991CPPg?=
 =?us-ascii?Q?1SPXUsCvpm1tfOaVV84gSdEnuCKQSHnytFwIIlh+TKhcdvlq/CtwLrIZi8dP?=
 =?us-ascii?Q?vcZe6YUtTilmlsW9Sr11QoLZ81mzLiwF8NItSwWYvTHqpprS7dorEfKjeMkm?=
 =?us-ascii?Q?BYzZvOT4bgHLpEkZgr/pG0fhsSffQICNly3ENrFq3zU7GF8JFN6rlKyPxrMj?=
 =?us-ascii?Q?cAfgne0f/GtfnYADnrsKePsrJdfxetem0OH5oGITTW4a3r9PE8HwwWeAfui9?=
 =?us-ascii?Q?DcKbEgUU06/97/rYwESWKm7k+ATbXeuSaf9QJF26Zh4RBfkGxrknszANOAiP?=
 =?us-ascii?Q?FbHBD6EwM57jr3cbjG/jaGkmg6Tvr6VtYMJWtOFbtsmrjv8LakOZpc2L2wyE?=
 =?us-ascii?Q?MnJ45eYfbwenI5bd2QCmD61uq20/9rzel24Wv7645szYr4YbnibBYfWwTRk0?=
 =?us-ascii?Q?PDpeMMRjraKzuGPP2hI4TwOvABg4kKrBFLOnJdYMusu1r+1EdO1rsFpeJuse?=
 =?us-ascii?Q?4PkRafhtCMc482ii5qnuOVj27Yb1LNAP0D7Doj2tl1z2qshj3O5MyJe/9Mn0?=
 =?us-ascii?Q?q5V7AktYYtpIK9MRsNNDbjnYdwIz1P0SZ5WUrIf/tgZCtknvbOUE3n3VCDyP?=
 =?us-ascii?Q?tc+3sMyz/Tp3gqkTIayyM3IetHy10Q4nE/OAsqfePS7/04qvhNfuWDZm+7Qh?=
 =?us-ascii?Q?bxLQeaqPJ2sVrWtpdn29Qnk2Omw5+F8lcW9X4u/W?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e5b182f-6359-4bfa-d481-08db208532dc
X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1409.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 10:01:06.1785
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bOtOdCcPOEWXT8RHXNhLOBx70taurEgF5SWChCRUu9q1hSMwAoKLLjV5ArJtiObBIVM0+dmSGlbxcKVOZxA94Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6477
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnd,

Thanks for the review.
On Thu, Mar 09, 2023 at 08:56:05AM +0100, Arnd Bergmann wrote:
> On Thu, Mar 9, 2023, at 08:10, Ye Xiang wrote:
> 
> > The minimum code in ASL that covers this board is
> > Scope (\_SB.PCI0.DWC3.RHUB.HS01)
> >     {
> >         Device (GPIO)
> >         {
> >             Name (_ADR, Zero)
> >             Name (_STA, 0x0F)
> >         }
> >
> >         Device (I2C)
> >         {
> >             Name (_ADR, One)
> >             Name (_STA, 0x0F)
> >         }
> >
> >         Device (SPI)
> >         {
> >             Name (_ADR, 0x02)
> >             Name (_STA, 0x0F)
> >         }
> >     }
> 
> I'm a bit confused by this bit, does that mean this only works
> if the device is integrated on the mainboard and the BIOS is
> aware of it? This won't work if  you plug it into a random
> USB port, or have no ACPI firmware, right?
LJCA can work both when there is an ACPI firmware or not.

When there is a config like "The minimum code in ASL" in DSDT, LJCA device and
its sub-devices will bind to right ACPI devices. Our current use case needs the
the ACPI binding. Because we have a camera sensor depending on this LJCA device,
We use the ACPI binding to control the probe order, making sure the camera
sensor probe after LJCA and LJCA-I2C.

When there isn't a config in DSDT, the LJCA device also can works. But
it won't have an acpi binding.

So, If you plug into a random USB port or have no ACPI binding, It just
does not have an ACPI binding.
> 
> > Signed-off-by: Ye Xiang <xiang.ye@intel.com>
> > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> >  drivers/usb/misc/Kconfig  |  13 +
> >  drivers/usb/misc/Makefile |   1 +
> >  drivers/usb/misc/ljca.c   | 969 ++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/ljca.h  |  95 ++++
> 
> Why is this in driver/usb/misc? It looks like a normal
> mfd driver to me, and it evenhas the header in include/linux/mfd/
It's a mistake. I just moved it from driver/mfd and forget to move the header to right place.
It will be addressed on next version. 
> 
>      Arnd

--
Thanks
Ye Xiang