Message-ID: <dcbf7e13-c4c6-4e66-92f1-103d111ec611@bytedance.com>
Date:   Thu, 9 Mar 2023 18:14:27 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH v4 5/8] mm: shrinkers: make count and scan in shrinker
 debugfs lockless
Content-Language: en-US
To:     Vlastimil Babka <vbabka@suse.cz>, akpm@linux-foundation.org,
        tkhai@ya.ru, hannes@cmpxchg.org, shakeelb@google.com,
        mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev,
        david@redhat.com, shy828301@gmail.com, rppt@kernel.org
Cc:     sultan@kerneltoast.com, dave@stgolabs.net,
        penguin-kernel@I-love.SAKURA.ne.jp, paulmck@kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20230307065605.58209-1-zhengqi.arch@bytedance.com>
 <20230307065605.58209-6-zhengqi.arch@bytedance.com>
 <96f34c88-ca9a-1c3c-e02a-7c5cd1a269e4@suse.cz>
From:   Qi Zheng <zhengqi.arch@bytedance.com>
In-Reply-To: <96f34c88-ca9a-1c3c-e02a-7c5cd1a269e4@suse.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/3/9 17:39, Vlastimil Babka wrote:
> On 3/7/23 07:56, Qi Zheng wrote:
>> Like global and memcg slab shrink, also use SRCU to
>> make count and scan operations in memory shrinker
>> debugfs lockless.
>>
>> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
>> ---
>>   mm/shrinker_debug.c | 24 +++++++-----------------
>>   1 file changed, 7 insertions(+), 17 deletions(-)
>>
>> diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c
>> index 39c3491e28a3..6aa7a7ec69da 100644
>> --- a/mm/shrinker_debug.c
>> +++ b/mm/shrinker_debug.c
> 
> Forgot to mention that this file should now likely also #include <linux/srcu.h>

Got it. Will do.

Thanks,
Qi

> 
>> @@ -9,6 +9,7 @@
>>   /* defined in vmscan.c */
>>   extern struct rw_semaphore shrinker_rwsem;
>>   extern struct list_head shrinker_list;
>> +extern struct srcu_struct shrinker_srcu;
>