Date:   Thu, 9 Mar 2023 18:16:47 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        "Lee Jones" <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        <linux-usb@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <srinivas.pandruvada@intel.com>,
        <heikki.krogerus@linux.intel.com>,
        <andriy.shevchenko@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <zhifeng.wang@intel.com>,
        <wentong.wu@intel.com>, <lixu.zhang@intel.com>
Subject: Re: [PATCH v4 1/5] mfd: Add support for Intel LJCA device
Message-ID: <ZAmyD9k1o4mA/VdV@ye-NUC7i7DNHE>
References: <20230309071100.2856899-1-xiang.ye@intel.com>
 <20230309071100.2856899-2-xiang.ye@intel.com>
 <ZAmPjfH6rA0pbiUa@kroah.com>
 <ZAmimLMY49ktjagX@ye-NUC7i7DNHE>
 <ZAmmQ/yKYnOG7xOS@kroah.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZAmmQ/yKYnOG7xOS@kroah.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eWrMxNq7g+/Di+Fm5TKl7rEFPuEglkOBoG8Lq6kbQ+3yqUDfouRzDHt5IMXR?=
 =?us-ascii?Q?66s/SvYDGwwT4WVjAxfu6NO6BvxPnmMFOq1xB0vjtVoWg7IPP3VMwC6VculQ?=
 =?us-ascii?Q?N2g5KnLLhO0vOWv8/tIQyxGUqlVTbFjGi1Wbm2WbQfwX5SdGTwkkvdJcFlaV?=
 =?us-ascii?Q?sYT84NUGRTaxYVSqfN9bdHCtutaXt8xQFcq7y35K/4v4JfJu7QKLNqASb0ml?=
 =?us-ascii?Q?eMzqRecTxX2lalMLldMAr6cckAhX3FJdb9J4vn4puewbVtPpNCWyQGvvjebS?=
 =?us-ascii?Q?nmlr7qaIBMzqXw55qUK4UKVoe567NvYFFw95MIbvIXBPjNRjfd4UGJUWu302?=
 =?us-ascii?Q?HIpvEubrNf8vf1DlK4lxDT2h2t/5cwWG69pOj7PhsGqbwH+bT0xHbHcGCD1P?=
 =?us-ascii?Q?UH4ApvAUIGELwRAvQ/U1p6x4H6hg96C8xOn8YDjyNZ7xlEQ1fa6SDkxaRiE6?=
 =?us-ascii?Q?MvemzlBql7jb7M9/URfHBNevHopTebWWY7pexI3EIsSrlSLrrOpk4cXdP3Vp?=
 =?us-ascii?Q?zUhIHL4jbsUCdfDmUG2JXY1bSf/tN9ph3QF6zMKowS4c5g86a84n2u3ndkZT?=
 =?us-ascii?Q?9iGFnJmN95u61rZKYfkM7KzBUwnAXL6AnAAEFDRa0+Tqm8tqUv7HuTnFoIKl?=
 =?us-ascii?Q?jYiutNVKSIM9FXoxYU1bgQjU1+hliAIDAM7u61aQYnkY5/lnsCzF3R3lCzgL?=
 =?us-ascii?Q?+dWVCV0u95eHCXOaYPIkKx12DxbUJhhmEpUXkVD0Zphz5G/moSSQsmNTv5rH?=
 =?us-ascii?Q?kQHaepWWG5SysQ+TdtySJmSTVBY/U45uWjghi25zH0bIL2RNZqGQy5boNsiI?=
 =?us-ascii?Q?xbMNCy+VItPoeeBxwbp11fyVd+tK5kiRqHjzp2ZLykPEJqEIPH/6a9gCddy0?=
 =?us-ascii?Q?MJOEV1U2/jSYuJYAnaiL949Yx3cQSXg6jp8vO/YCNI1BTUEaRoEGUeVbVJg3?=
 =?us-ascii?Q?TZKwzZJ9/EEn4J9baDC8FZt5XOa91BHKWIvio1qt+NHErZELLJcNsjjfUzLM?=
 =?us-ascii?Q?z7TYrpfsfjJuhCOxlRaxxCf0/5SGyKlBaUHvQF94PavnxxRgCG4N5KlY+O9s?=
 =?us-ascii?Q?yKDRGaYckd9ErhldwmVUF1h48g7X8IcG+rrc3M/zKf0k0NKN9XkzW2FnHvhk?=
 =?us-ascii?Q?A38iJ2JmvFvPxN1g4o2TU5VF+pL0taMGtl6DeMFArLMEuJ046ZqqwbprLH83?=
 =?us-ascii?Q?2nxt1Jf7qfZpdtvnZKkLBS/BeaYzsc9JLjStA4cRbslh8GX59qsOx5QzoMpH?=
 =?us-ascii?Q?pflhD8ZNiSNLnll9OVBjyW5Rpjy0yeI/rUBMsapk7nvFp71Kh5cgFLLEumOM?=
 =?us-ascii?Q?ph0WVVwL3dJ0C9c528ay9rvp04NGPxx5njhPX4+fD9d0iWTNzTe57X5XEG3V?=
 =?us-ascii?Q?JOSoOra8Jt7Zf9A9i3L8xf4Ngyh13cGGFDjaBKafJ6oL+0CaY2R2ZPtY9WZp?=
 =?us-ascii?Q?4r8vHgjsmlfe33etwz8kcHo+2j6oSDNNBTFjw+6dYN2ChTXfrGpOlbWG4hO5?=
 =?us-ascii?Q?QP6C7AdwEisfJfBWZ19S97OUtxA8+Xn90v6R1yPhSmFOR9AgsWtuvdrFNaMR?=
 =?us-ascii?Q?E0NmCNHnZlwfOBaeD9aRis8OCmnSvmxhDCMcakAu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d94fb32-a8e9-46a8-5603-08db208767ec
X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1409.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 10:16:54.2085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s60J+2kGw65o4yWjKSyYxXL9YjQXNVE5LIPz6U+gCZuEUPO0Q8URHhVFtWJX2UPAWd/51lIVP7bBTfyZhYoiyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4956
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 09, 2023 at 10:26:27AM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 09, 2023 at 05:10:48PM +0800, Ye, Xiang wrote:
> > Hi Greg,
> > 
> > Thanks for the review.
> > On Thu, Mar 09, 2023 at 08:49:33AM +0100, Greg Kroah-Hartman wrote:
> > > On Thu, Mar 09, 2023 at 03:10:56PM +0800, Ye Xiang wrote:
> > > > This patch implements the USB part of Intel USB-I2C/GPIO/SPI adapter
> > > > device named "La Jolla Cove Adapter" (LJCA).
> > > 
> > > Then why is this called "mfd" in the subject line?
> > Sorry, it's a mistake. I forget to change mfd to usb in the commit message
> > because I just move the ljca.c from driver/mfd to drivers/usb/misc according
> > to previous review comments[1]. And I will address this on v5.
> > 
> > [1] https://www.spinics.net/lists/kernel/msg4708451.html
> > > 
> > > >  include/linux/mfd/ljca.h  |  95 ++++
> > > 
> > > Why is this .h file in the mfd directory?
> > It's a mistake as well. Will address it by moving include/linux/mfd/ljca.h
> > to include/linux/usb/ljca.h.
> 
> Why do you need a .h file at all for such a tiny .c file?  If you don't
> need it, don't have one please.
The ljca.h file is needed because there are three function driver in
this series (LJCA-SPI, LJCA-GPIO, and LJCA-I2C) which needs LJCA API
to do actual transfers. LJCA-USB can be considered as a transport driver,
and the other three function driver use LJCA API to transfer their own
packages.

--
Thanks
Ye Xiang