Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ABF0C6FD1C for ; Thu, 9 Mar 2023 10:22:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbjCIKWQ (ORCPT ); Thu, 9 Mar 2023 05:22:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231196AbjCIKWB (ORCPT ); Thu, 9 Mar 2023 05:22:01 -0500 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B7804E5FD for ; Thu, 9 Mar 2023 02:22:00 -0800 (PST) Received: by mail-il1-x12c.google.com with SMTP id h7so775527ila.5 for ; Thu, 09 Mar 2023 02:22:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1678357319; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/Ah1TtdVxfPgfmW7zrYGGBKwFiIK5NMV4NPzf8pIYnM=; b=B72T8/xcJkjQz7mlADugAXF75gmsMItZFaKG06Dg/eKa38XtjEmB5TesT6Tgp6ASVa y7A4CQ+1SKnIFvNYlOo3PnP0nSTd+8rsz+m7vcdsxyqsxg5jUheyJ7M22oT4FGRUwJFe UlqCyzjG+7geAfz15PsLpJSOKheBGW/Vk39Kc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678357319; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Ah1TtdVxfPgfmW7zrYGGBKwFiIK5NMV4NPzf8pIYnM=; b=wUd8OM6Z6GT4tKje0ZVYSls2PGgCU7A85JgIrJjM/ss4AcKrPJDc59N4c664xngGtw ymS5VS/RUA24xHE8TpGNpCJEZVclwMdLVr5ckRQvyxJIjpLuFKwvXYLOqsNgVDEJLIAQ H2jlD1dK0SpZwShfwk7hgela1Q5XM8MixKapdPRjoNXRrpPGmqROBXJ7LtsfTEjHdYnR 85qkZKgSUOdD2xjMS+IASXkSnGlea6reWxP9d0R5zv7+ZeGn4mJUjeKu4+rlQ7V3OJ9k KYNnk/BUdwsgeEr4tDkRMyN3Z9aGTot/kf0STKtzxoFgQcahXd3zUDNWLfZwWDaAliro FSNg== X-Gm-Message-State: AO0yUKWhjYHIcSjqvlm8Tt+G3Tet3Jole2wGiZVjKOoAozXTwbJo16h4 fztY3tuiHsOi7H2+1okdg7wz/Jj3jwppDW2HB4iDRg== X-Google-Smtp-Source: AK7set/8LE04Zm+2ShiPru3Ucvo7TBxa+dRVhoQ8TlB/lSr0SCiXxU6ZSWYbEzWNlrck7ayKIPUPGHnsRZrsJ3nY8As= X-Received: by 2002:a92:b512:0:b0:30f:543d:e52c with SMTP id f18-20020a92b512000000b0030f543de52cmr10301852ile.2.1678357319507; Thu, 09 Mar 2023 02:21:59 -0800 (PST) MIME-Version: 1.0 References: <20230303143350.815623-1-treapking@chromium.org> <20230303143350.815623-11-treapking@chromium.org> In-Reply-To: From: Pin-yen Lin Date: Thu, 9 Mar 2023 18:21:48 +0800 Message-ID: Subject: Re: [PATCH v13 10/10] drm/bridge: it6505: Register Type C mode switches To: Andy Shevchenko Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck , Xin Ji , Javier Martinez Canillas , Lyude Paul , linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , chrome-platform@lists.linux.dev, =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= , Marek Vasut , Hsin-Yi Wang , devicetree@vger.kernel.org, Allen Chen , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Stephen Boyd , linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On Wed, Mar 8, 2023 at 11:31=E2=80=AFPM Andy Shevchenko wrote: > > On Wed, Mar 08, 2023 at 09:51:19PM +0800, Pin-yen Lin wrote: > > On Mon, Mar 6, 2023 at 8:03=E2=80=AFPM Andy Shevchenko > > wrote: > > > On Fri, Mar 03, 2023 at 10:33:50PM +0800, Pin-yen Lin wrote: > > ... > > > > > + it6505->port_data[i].lane_swap =3D (dp_lanes[0] / 2 = =3D=3D 1); > > > > > > ' % 2 =3D=3D 0' ? > > > > > Per another patch, I'll update this into `< 2` > > But here it should be >=3D 2 then, no? > Yes it should be >=3D 2 here. I wasn't really using my brain when I replied to the mail.... > -- > With Best Regards, > Andy Shevchenko > > Best regards, Pin-yen