MIME-Version: 1.0
References: <20230309092821.1590586-1-daniel.lezcano@linaro.org> <20230309092821.1590586-2-daniel.lezcano@linaro.org>
In-Reply-To: <20230309092821.1590586-2-daniel.lezcano@linaro.org>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 9 Mar 2023 07:45:14 -0300
Message-ID: <CAOMZO5CdLXMtBbdH1j1RLFL=t5ZGXVgi5=Aw5pde1QNcCAVKxQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] thermal/drivers/imx: Use the thermal framework for
 the trip point
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     rafael@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 9, 2023 at 6:28=E2=80=AFAM Daniel Lezcano <daniel.lezcano@linar=
o.org> wrote:
>
> The thermal framework provides an API to get the trip related to a
> trip point id. We want to consolidate the generic trip points code,
> thus preventing the different drivers to deal with the trip points
> after they registered them.
>
> The set_trip_temp ops will be changed regarding the above changes but
> first we need to rework a bit the different implementation in the
> drivers.
>
> The goal is to prevent using the trip id but use a trip point passed
> as parameter which will contain all the needed information.
>
> As we don't have the trip point passed as parameter yet, we get the
> trip point using the generic trip thermal framewrok APIs and use it to
> take exactly the same decisions.
>
> The difference with this change and the previous code is from where we
> get the thermal trip point (which is the same).
>
> No functional change intended.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>   V2:
>     - Remove extra tab inserted in the previous version

Reviewed-by: Fabio Estevam <festevam@gmail.com>