Message-ID: <c5103e6c-a7b5-d100-c731-7502fd34dbed@suse.com>
Date:   Thu, 9 Mar 2023 12:16:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v3 09/28] sound: usb: card: Introduce USB SND platform op
 callbacks
Content-Language: en-US
To:     Wesley Cheng <quic_wcheng@quicinc.com>,
        srinivas.kandagatla@linaro.org, mathias.nyman@intel.com,
        perex@perex.cz, broonie@kernel.org, lgirdwood@gmail.com,
        krzysztof.kozlowski+dt@linaro.org, agross@kernel.org,
        Thinh.Nguyen@synopsys.com, bgoswami@quicinc.com,
        andersson@kernel.org, robh+dt@kernel.org,
        gregkh@linuxfoundation.org, tiwai@suse.com
Cc:     linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-usb@vger.kernel.org, quic_jackp@quicinc.com,
        quic_plai@quicinc.com
References: <20230308235751.495-1-quic_wcheng@quicinc.com>
 <20230308235751.495-10-quic_wcheng@quicinc.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20230308235751.495-10-quic_wcheng@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDhuS1k4RFY5cFFrcldyT0RubFM0S2JRNmhBUmFlYlhyeXZmb1VOU2JYdVJu?=
 =?utf-8?B?TjlLVStMOFhoZmtGOS9vZTBLdXZ2S0xTZ1RRcnU4MmJOUnpxRktPZGN1NzUv?=
 =?utf-8?B?K3hKbVBCOEovalNBeW5sdDVHTEg2bmR3MXZMdm9rdXNvU05lY2dpQVp2RTBV?=
 =?utf-8?B?bkRiNHA2MERPUEVadmFZbTdlc3VYZnM0NUFuZHRpc0ZOREpUb25rNFdLV1hO?=
 =?utf-8?B?SVRGVmhRZGtPblBYQjdLVENhdlp1dkdTbkVlUWFZUkRONGZDUnI4N0J3RG1X?=
 =?utf-8?B?U1VBSklpa0dkK0tVZHJrMFo4OU5OQjZGNjVZd3lSTmxxeVRGTmluVjBvTXEr?=
 =?utf-8?B?N3hITGVmTXowbXZMZklDek9FZktiUVFVMVYxNDJSakk4MWlYdDFMeFlaVHZk?=
 =?utf-8?B?UFdpMGsrNEx0UXFHY2VnejNLcjFlTk5Od2VPRWZRWU9tN1cwVXkrQit5SnY5?=
 =?utf-8?B?NXdaZnlKYk82ZFo3eTlJRFF2T2FBZEZuNlBsR2R1NDJNZFg4SncyYnZQWHN6?=
 =?utf-8?B?a1FpeTAvUlFQWEI5U0NmS0FMYlQ3ZzRsekhRK3E0WkwyU0NjOU5qZncvYlZI?=
 =?utf-8?B?NWcwdEhXU1ZuRWQ1VWpjRmduUTBaaDdwaFFRcElvOUFGLzZYbzFDS0l2Ly9R?=
 =?utf-8?B?eHJpOGkyaEV6QWsxWnNBcHNWa29saVRVUFV5SGdmVnVla3VxZlROenlwdy80?=
 =?utf-8?B?dkU0cTZ6Z0QxNEJuUHg0Zk9NUjVWWHZmLzYvc0xjMVAzSTVxNDY0V09BMS9K?=
 =?utf-8?B?UENqZHYxRlMzVjl3WTlKZTh2UlQ3aW1ZRGxQRis1VFd2eUx6VGtDUkhiaXhZ?=
 =?utf-8?B?bGlsQ2UxVENSaXMyRHdrbHgxN1ZkM0pwU0hxQjZKOFl3UkFjdVBxVW1JVnFJ?=
 =?utf-8?B?ZWV5VVJaR3JDb3NOZDRMQlQrUnlaUzVCZzk5Z2tDOGpaZlZsWGdENWF2S255?=
 =?utf-8?B?VlN0SFp3VmtwajRiRmlHL3FMRTFmdFlCT0d0U3dEektpQWFYQUVtSlJ5WXNw?=
 =?utf-8?B?bm5UMDRpWjk3MU1rZys0VGY3TDZRT3c0Y0tWTTd5SjQ5a1pQL1BrWVM4N3d3?=
 =?utf-8?B?Ti9rVHNlamxvdk85WnoyRlcvTkcvZ3dkS1lYZjQ1aGpJOEQ5UnZSc2lBMFlZ?=
 =?utf-8?B?NzI5Ukc5N2kvZk92NGZNQ0pPUmRqSVpLSHFPM3NINnBzd1FWZU5jaUlvU21a?=
 =?utf-8?B?Wkk4azlSUzVQNStKelBLMmt6alg0cjdidWlDTFJvMmhNWUtHUkNQVVVlaURB?=
 =?utf-8?B?WnRyNmpZeko5bmZ5cDNOMkVuOFFGSnZxaTdIV0EyQ0kxbmlpcG5mWDcxTnRP?=
 =?utf-8?B?U3MydDhVODdJSHR1cVJYZTUveXg5V2hLVUlIL1Y2a3VTUkpuTHYyVE4xRTNv?=
 =?utf-8?B?WmVxTzh1RTdSR2pXRGVhZitLMzU1RWpJQzEvY1VXd1gvU1ZpQWxRZWJkVDdt?=
 =?utf-8?B?MW1rc0o1ZW5FaGhuNnNNbFZleUZYb0d3bFpaRzhBSytkT2RsL2pxMnR3Zy9a?=
 =?utf-8?B?bFluaFFOQll3bWR1TkNxRlAvTWZwLzhqLzcvMXZtTVNLT29ZQWpyVDVNRHJW?=
 =?utf-8?B?cVN2TU9sbG1iL205V0t0Qnk2MEl3c2RrM0xndmdWTW02R3hmQllQbVRZRTZN?=
 =?utf-8?B?WkhwVmxVZmxUeTRzQTBLYWFuMWJlQWR4aHMxaWVLSkNoVndDLy9BRTdMTndH?=
 =?utf-8?B?MXI0V0dWS2hQY1RKclZNamlvTkpoV3hRcFNDV29oeG1POFlTNEhnR1NDKzNr?=
 =?utf-8?B?QU5LZ21WUDZEUDBDNmhKTlBhSllLSGM1VkpTcThFVE9jYVVOYXVpOVVpRUJn?=
 =?utf-8?B?K3dXQkZpeWdhWWJjVUIrR3A4UFc1KzZCT3NWazEzQTRwR0VkZDJBNUh5SnhE?=
 =?utf-8?B?TTIySkdIZktQT05peXZQM0JOcUgreFkwYWpCOWYwRFZpZG4vRHlDZ25CNnli?=
 =?utf-8?B?RDQvZlpOSGlJbmhsdFJDS2M2YjNJRzVJNmc1Uy92YWlFQ1p3T0t0R2RqQnBs?=
 =?utf-8?B?VXBBUHkzakFHNG4xTnZ2OGp0VGVsMFlubnh5SFFMNFE0YUs0SDl1RjFXZVRY?=
 =?utf-8?B?TWJyWUpSUEJQWFlTd2Z3QXBEeFhBTUJxaThJY0RObGZRWm1VMjJmU0ZaRGZP?=
 =?utf-8?B?d3hycE9teEJHdmlFbG5nQ3N5RUY4RThvMER5aEhCZktrNVpFYzNSWkliOEpm?=
 =?utf-8?Q?KPoVIJwNu3SlTnfcQMIEMOSYYjNjwk4zY5EZRYnprJEo?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6dc0a7e5-b7c9-4c96-5c64-08db208fcf1e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 11:17:03.2529
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xPgawBiwaXjZ4bVhBb76JGhVtpLC2YXMYq1MJaPpuWxa4A6mV5CKpePy7Jnxme7/ECO9+RopJeMjmYsofn84iQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8053
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 09.03.23 00:57, Wesley Cheng wrote:
> Allow for different platforms to be notified on USB SND connect/disconnect
> seqeunces.  This allows for platform USB SND modules to properly initialize
> and populate internal structures with references to the USB SND chip
> device.
> 
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> ---
>   sound/usb/card.c | 36 ++++++++++++++++++++++++++++++++++++
>   sound/usb/card.h | 20 ++++++++++++++++++++
>   2 files changed, 56 insertions(+)
> 
> diff --git a/sound/usb/card.c b/sound/usb/card.c
> index 26268ffb8274..9bcbaa0c0a55 100644
> --- a/sound/usb/card.c
> +++ b/sound/usb/card.c
> @@ -117,6 +117,30 @@ MODULE_PARM_DESC(skip_validation, "Skip unit descriptor validation (default: no)
>   static DEFINE_MUTEX(register_mutex);
>   static struct snd_usb_audio *usb_chip[SNDRV_CARDS];
>   static struct usb_driver usb_audio_driver;
> +static struct snd_usb_platform_ops *platform_ops;
> +
> +int snd_usb_register_platform_ops(struct snd_usb_platform_ops *ops)
> +{
> +	if (platform_ops)
> +		return -EEXIST;
> +
> +	mutex_lock(&register_mutex);
> +	platform_ops = ops;
> +	mutex_unlock(&register_mutex);

This looks _highly_ suspicious.
Why does the assignment need a lock, but the check does not?

	Regards
		Oliver