Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A56C64EC4 for ; Thu, 9 Mar 2023 11:24:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231346AbjCILYD (ORCPT ); Thu, 9 Mar 2023 06:24:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231337AbjCILXc (ORCPT ); Thu, 9 Mar 2023 06:23:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 659D6E34AC for ; Thu, 9 Mar 2023 03:20:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 89C98B81EE4 for ; Thu, 9 Mar 2023 11:19:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1859C433D2; Thu, 9 Mar 2023 11:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678360782; bh=PNxG3AA4xzGe1bfBUCNRM4m9chUBNm4UAouDnMQhGlc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MzBPN1jNjg+ZMZ7su8hPOlARAnWjAsmYQVb0iIf3/FnJ562ISHCI8yrUVEDHxmQEq YBiICe7Xql9Z47D20UE0e8GEFZpQrLPoHFVgxNL917zB+fSqxL0HeneHKf5xVXaqDh zOFXnETzoaOwqqFiTFEWN+pXd6RVD5SQFzUHh+H/b70IkVhNL9tdG0Ure8LGDSQwQe 9OnwAhFRrjnobNdQCEKJYxVVPK1lP0S4Zu/OxZRyoa94RXARYd5TC8HspBz1xozus6 ahZw7jpSYF4w3Yrf4fhqadx8KY/ZYmNYx//uzNrJmLplTt3BLqE/lmc7ywaCoHeUkW FmKEVrfXkMsUQ== Date: Thu, 9 Mar 2023 11:19:36 +0000 From: Mark Brown To: Krzysztof Kozlowski Cc: Lucas Tanure , David Rhodes , Charles Keepax , Liam Girdwood , Krzysztof Kozlowski , Rob Herring , Jaroslav Kysela , "Takashi Iwai --cc=alsa-devel @ alsa-project . org" , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk Message-ID: References: <20230309104133.537056-1-lucas.tanure@collabora.com> <2881f527-1673-3496-85a2-84a13f074248@linaro.org> <23cb7d3c-4cf8-8d9d-dbdb-4391384a5726@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GoCK2JkrBzZJxgcj" Content-Disposition: inline In-Reply-To: <23cb7d3c-4cf8-8d9d-dbdb-4391384a5726@linaro.org> X-Cookie: I will never lie to you. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GoCK2JkrBzZJxgcj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 09, 2023 at 12:17:35PM +0100, Krzysztof Kozlowski wrote: > On 09/03/2023 12:04, Mark Brown wrote: > > On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote: > >> You are now changing ABI and adding undocumented properties. > > This is newly added code, changes are fine. > OK, for the ABI code, but not for the undocumented properties. Commit > does not explain that. It does, it says that it's adding support for the properties used in the firmware on existing Steam Decks. Those aren't even DT systems. --GoCK2JkrBzZJxgcj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQJwMcACgkQJNaLcl1U h9AeAQf/WOFCBPr6mfWX361SQ3WlSUlSuoT5qW7XNKG5Y6qfACqzAsvcwU+bGAIf Y7CEjZotFYIPod7+I3TUce7b83anxb6HKlyP7gorGSq73CebhZuaGTJQKYfJFRa4 rN2vROUGfDEERNTovNnsCSMm4Iwprg06u5m+gtOlDjb8/6CsTRx2Ia3dLagpnu2d gbdc+/PM0EpLRwH2+GQlBCKtEajpniWZkWnsDDwY3/TpNSQQPiqTTLUMzCUaDAHL jLujMxVTJpfeFUBEXqJeS7bXfMzvEQIn+4LaWK6oLBQnRhxBXeta285psHqp4DqE bVNg9YIhBWpgn7mSvgvPKT8vOSPL0A== =Yie/ -----END PGP SIGNATURE----- --GoCK2JkrBzZJxgcj--