Message-ID: <fea6e236-94da-68da-36b9-e8e21c037cfb@linaro.org>
Date:   Thu, 9 Mar 2023 12:25:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties
 quirk
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>
Cc:     Lucas Tanure <lucas.tanure@collabora.com>,
        David Rhodes <david.rhodes@cirrus.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        "Takashi Iwai --cc=alsa-devel @ alsa-project . org" <tiwai@suse.com>,
        patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
        kernel@collabora.com
References: <20230309104133.537056-1-lucas.tanure@collabora.com>
 <2881f527-1673-3496-85a2-84a13f074248@linaro.org>
 <af2de8df-b20e-4bbc-9f00-90b50546c4fb@sirena.org.uk>
 <23cb7d3c-4cf8-8d9d-dbdb-4391384a5726@linaro.org>
 <d20cd40f-659c-4260-b47e-a0c5eee5437a@sirena.org.uk>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <d20cd40f-659c-4260-b47e-a0c5eee5437a@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 09/03/2023 12:19, Mark Brown wrote:
> On Thu, Mar 09, 2023 at 12:17:35PM +0100, Krzysztof Kozlowski wrote:
>> On 09/03/2023 12:04, Mark Brown wrote:
>>> On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote:
> 
>>>> You are now changing ABI and adding undocumented properties.
> 
>>> This is newly added code, changes are fine.
> 
>> OK, for the ABI code, but not for the undocumented properties. Commit
>> does not explain that.
> 
> It does, it says that it's adding support for the properties used in the
> firmware on existing Steam Decks.  Those aren't even DT systems.

For some reason DT is cced...

The code unfortunately will allow to put them into DT and next time
people will use it as an argument to document in the binding ("because
driver already has them"). I heard this argument already many times.

Document then that these are not DT properties.

Best regards,
Krzysztof