Message-ID: <fd7e0f354da923ebb0cbe2c41188708e4d6c992a.camel@kernel.org>
Subject: Re: [PATCH] fs/locks: Remove redundant assignment to cmd
From:   Jeff Layton <jlayton@kernel.org>
To:     Christian Brauner <brauner@kernel.org>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     viro@zeniv.linux.org.uk, chuck.lever@oracle.com,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Date:   Thu, 09 Mar 2023 06:50:15 -0500
In-Reply-To: <167835349787.767856.6018396733410513369.b4-ty@kernel.org>
References: <20230308071316.16410-1-jiapeng.chong@linux.alibaba.com>
         <167835349787.767856.6018396733410513369.b4-ty@kernel.org>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-03-09 at 10:25 +0100, Christian Brauner wrote:
> From: Christian Brauner (Microsoft) <brauner@kernel.org>
>=20
>=20
> On Wed, 08 Mar 2023 15:13:16 +0800, Jiapeng Chong wrote:
> > Variable 'cmd' set but not used.
> >=20
> > fs/locks.c:2428:3: warning: Value stored to 'cmd' is never read.
> >=20
> >=20
>=20
> Seems unused for quite a while. I've picked this up since there's a few o=
ther
> trivial fixes I have pending. But I'm happy to drop this if you prefer th=
is
> goes via the lock tree, Jeff.
>=20
> [1/1] fs/locks: Remove redundant assignment to cmd
>       commit: dc592190a5543c559010e09e8130a1af3f9068d3

Thanks Christian,

I had already picked it into the locks-next branch (though I didn't get
a chance to reply and mention that), but I'll drop it and plan to let
you carry it.

Thanks,
--=20
Jeff Layton <jlayton@kernel.org>