Message-ID: <097d1742-1aa8-fc0b-db11-3571ea49383d@suse.com>
Date:   Thu, 9 Mar 2023 13:53:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v4 1/5] mfd: Add support for Intel LJCA device
Content-Language: en-US
To:     Ye Xiang <xiang.ye@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, linux-usb@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org
Cc:     srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com,
        andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com,
        zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com
References: <20230309071100.2856899-1-xiang.ye@intel.com>
 <20230309071100.2856899-2-xiang.ye@intel.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20230309071100.2856899-2-xiang.ye@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzlKR2FIRTBvQ2F2ZjhNTlM0WVgwajREYVhVc3NPRllsU2EwNG1wZlhVdXA5?=
 =?utf-8?B?TWxWWTdLdHJUd21vT1JDbDY2bnNLZFVpckhmVHRtcUVQWTFOOHYwVGo1MUJH?=
 =?utf-8?B?TlZLMzJJa2FqTElZM0tWMm9neUs2Q0FQajRqMmJValZDV1p2b2hzbXB5UUNl?=
 =?utf-8?B?dHhnK3U0Njd0cVlSRm9XZ0s5OUJydHdDckQvUW9GTnRkMi9ENnV6VVRGd0tx?=
 =?utf-8?B?U0p1TUZrajdtWEp3RHRBRE5GVllKT3IrKzl3UC9xMUxRZ2psbnd5TkJmWGVK?=
 =?utf-8?B?WjNZc3YyOU1uc3RMUktza1ZVMFlJbXFwMU9SZmxaQSt5eE9JczN6c0FvUUZn?=
 =?utf-8?B?N3lmVjJzT2kyZkwxd0FzV3psRU5HcmlHZUFxTHMxSGZhU2g5QzR6dkxIWUdS?=
 =?utf-8?B?ZWRwODQ1Q2dCalBBemtlQi9KRkdkT0NEazNxN2tEbEcrM2hkOEU0L290QU40?=
 =?utf-8?B?ZHFWenZtMkJ0SVlvdEQ0cjNXQlNpRCsyMlVXT2FHakxXR2hSSzBzaWIzVys2?=
 =?utf-8?B?dVg5aDI0d0cxZVRySDI1UXZYR0hDNkVvZ2VIKzRudWxEdjhpSTlmdEZIRE5C?=
 =?utf-8?B?aTZFejFRRFMvWkhaSVEvSDRsZDg0WUVLZmdJRnJ0Y1E3czZ2Skh0QTBRNnE5?=
 =?utf-8?B?eG1ZakYyT0dZZUt3RTFzazhSTGhhUUxlQW1PQW1Td3dCcE1sM1ZOc0xYUVR0?=
 =?utf-8?B?NTZ5eGpjSk5FY3JZdlBlb3UwMktFT3Q5R1U5aWdsRzl6RUFsYnE3M1ZLQWNt?=
 =?utf-8?B?aU40WXh4ODNYU3hPbmU5c08vRWpKeXRUemlZdThjMEMvVXZydGxBcFBrUGsx?=
 =?utf-8?B?VW54WCtrV0pGTFB3c0Zlb1l2aDhyUjU0MXlTWjZveUFpUzdNbjFkNXVRc3Nj?=
 =?utf-8?B?ejEvSmlPUkNlMm5LcTFoVWphTUF3ZkU2UlpkNUJ5WkgyVC9LcGRXcTF5TzUy?=
 =?utf-8?B?WHlZcXF4QkJmVmpnTDMvS2M4NFVvUzYxakhuQVRLSFdpSCtZQmJrV3o3WGll?=
 =?utf-8?B?bDduNVJYU2pQQzV1a3Y1a3dBWVFrdzN1SE5HZU5hTXJSYWZjUHFXL1BNaitR?=
 =?utf-8?B?MCs3UlBmM012UXpxOUlqd0hBczBCUGc2cFF5d2hhNHRvRWFzYjVPeXk0ekk4?=
 =?utf-8?B?MkdpdlZhajRiU2UwR3RDbUlZL3ZURTdDQjFKdjN6eEhQbDNKZmxmRmlxR1c0?=
 =?utf-8?B?aFkwWlpKTkFNdHRCb1A2WHZ5RVFVZWFnZWx0RFFybjVSRXRXMk42N2J5N1Qw?=
 =?utf-8?B?Qi9sU1pYeUpOa2hDZGFaV2M5NU9OSjRQbkpkY1h3c0YrVWlKQS9FWWxKeU5T?=
 =?utf-8?B?aUgzRmM1Tm9jcW5sRWtNMW1tellTN1hFK3BoUy9ZdHdJa2JMNVFiSVVSNGVt?=
 =?utf-8?B?N0toTXdkckRVS2Y0NmEyTzY0YUt2ZTFpb21kTUFSNW0vb0EvVnFoVEdDL2lj?=
 =?utf-8?B?aXFDRlpUUWhZYklFaURlRXg0WUtnYWZScndxQzAzYjNyY25rN2I1SDdGQnVV?=
 =?utf-8?B?NndhbjNKbEpaeHhER2dibmNhOHdPdEhOYk1iU0kyS2UrUVpmSUV4UWlXQ092?=
 =?utf-8?B?VmxCYzRPc3YvbDNSL3ZRSW5BWFFQRWYxRTNxZk5Pa3RzMzM1QS9NRi9HUFNT?=
 =?utf-8?B?QjBYWXozMUFuKzBOMEd1TTN5eDJETlNvRnYxdWV4d01PZHozTTU5NkFBOXA3?=
 =?utf-8?B?REZ5ZjlDc3o5ZzAwR3I1eno4UTlvYUhKdzFOSVM1RndOUWdDa0xNa2tkTUtr?=
 =?utf-8?B?aG04RERwNjNoOHlqZExzMzdwU0lOV2hGcmhlcjUyQTRJR3VpcUo1MHcrZEVW?=
 =?utf-8?B?cjN6SkpVU0ZqVXMzTW1FWE1WWmU0T0NjNExNSTJuandiK0k4TkVJS0xrRk5M?=
 =?utf-8?B?WU5JYi9tK1ZwZ201dW5XalNtamRWdGs5UDRwbXVUVEI4cy9KVGFXK2Y4S3Z3?=
 =?utf-8?B?NkNnSklJRUFSVTM5R0t5b2VLTUZ4UFhXRVRyREFLS3RSOW9icHVqcU11STBy?=
 =?utf-8?B?c0xWU3Z3WjRnaloyYkRoYlpIZUpZQ2pTaFR3S1Q1ekxVRVEvUVFLNUV5N3A4?=
 =?utf-8?B?allUNnZmSnVrNHo4RXdZcTRDK1VjY2hsNWhpWWJwQWlFNk4xeSszUXJpNUxP?=
 =?utf-8?B?aFlWbWU1RVp0c3NzL0tCbmJJQTl0SHZhbklTYjIxciswcFlENFdKV2p1VkEy?=
 =?utf-8?Q?2hvFMEMu3dWcNVwFCIMXKw0iiLxew3rL63o97W6u++C4?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97c48fd3-7c75-43d5-d6ca-08db209d4923
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 12:53:31.3672
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fXfQoTi4a9HvlTg2we3CD/6fCh+UcfrT8xa/uHT33hi4u8tfeeBdBtK5xCxlD/h08L1SUOxlgnElQTepsS5bEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8620
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 09.03.23 08:10, Ye Xiang wrote:

> +static int ljca_stub_write(struct ljca_stub *stub, u8 cmd, const void *obuf, unsigned int obuf_len,
> +			   void *ibuf, unsigned int *ibuf_len, bool wait_ack, unsigned long timeout)

Why do you make ibuf_len a pointer?

> +{
> +	struct ljca_dev *dev = usb_get_intfdata(stub->intf);
> +	u8 flags = LJCA_CMPL_FLAG;
> +	struct ljca_msg *header;
> +	unsigned int msg_len = sizeof(*header) + obuf_len;
> +	int actual;
> +	int ret;
> +
> +	if (msg_len > LJCA_MAX_PACKET_SIZE)
> +		return -EINVAL;
> +
> +	if (wait_ack)
> +		flags |= LJCA_ACK_FLAG;
> +
> +	header = kmalloc(msg_len, GFP_KERNEL);
> +	if (!header)
> +		return -ENOMEM;
> +
> +	header->type = stub->type;
> +	header->cmd = cmd;
> +	header->flags = flags;
> +	header->len = obuf_len;
> +
> +	if (obuf)
> +		memcpy(header->data, obuf, obuf_len);
> +
> +	dev_dbg(&dev->intf->dev, "send: type:%d cmd:%d flags:%d len:%d\n", header->type,
> +		header->cmd, header->flags, header->len);
> +
> +	usb_autopm_get_interface(dev->intf);
> +	if (!dev->started) {

Memory leak in error case. You must free header.

> +		ret = -ENODEV;
> +		goto error_put;
> +	}
> +
> +	mutex_lock(&dev->mutex);
> +	stub->cur_cmd = cmd;
> +	stub->ipacket.ibuf = ibuf;
> +	stub->ipacket.ibuf_len = ibuf_len;
> +	stub->acked = false;
> +	ret = usb_bulk_msg(dev->udev, usb_sndbulkpipe(dev->udev, dev->out_ep), header, msg_len,
> +			   &actual, LJCA_USB_WRITE_TIMEOUT_MS);
> +	kfree(header);
> +	if (ret) {
> +		dev_err(&dev->intf->dev, "bridge write failed ret:%d\n", ret);
> +		goto error_unlock;
> +	}
> +
> +	if (actual != msg_len) {
> +		dev_err(&dev->intf->dev, "bridge write length mismatch (%d vs %d)\n", msg_len,
> +			actual);
> +		ret = -EINVAL;
> +		goto error_unlock;
> +	}
> +
> +	if (wait_ack) {
> +		ret = wait_event_timeout(dev->ack_wq, stub->acked, msecs_to_jiffies(timeout));
> +		if (!ret) {
> +			dev_err(&dev->intf->dev, "acked wait timeout\n");
> +			ret = -ETIMEDOUT;

If that triggers, you may have a pending URB.
You must kill it.

> +			goto error_unlock;
> +		}
> +	}
> +
> +	stub->ipacket.ibuf = NULL;
> +	stub->ipacket.ibuf_len = NULL;
> +	ret = 0;
> +error_unlock:
> +	mutex_unlock(&dev->mutex);
> +error_put:
> +	usb_autopm_put_interface(dev->intf);
> +	return ret;
> +}


> +static int ljca_i2c_stub_init(struct ljca_dev *dev, struct ljca_i2c_descriptor *desc)
> +{
> +	struct ljca_i2c_info *i2c_info;
> +	struct ljca_stub *stub;
> +	int ret;
> +	int i;
> +
> +	stub = ljca_stub_alloc(dev, LJCA_I2C_STUB, size_mul(desc->num, sizeof(*i2c_info)));
> +	if (IS_ERR(stub))
> +		return PTR_ERR(stub);
> +
> +	i2c_info = ljca_priv(stub);
> +
> +	for (i = 0; i < desc->num; i++) {
> +		struct mfd_cell cell = {};
> +
> +		i2c_info[i].ljca = &stub->ljca;
> +		i2c_info[i].id = desc->info[i].id;
> +		i2c_info[i].capacity = desc->info[i].capacity;
> +		i2c_info[i].intr_pin = desc->info[i].intr_pin;
> +
> +		cell.name = "ljca-i2c";
> +		cell.platform_data = &i2c_info[i];
> +		cell.pdata_size = sizeof(i2c_info[i]);
> +
> +		if (i < ARRAY_SIZE(ljca_acpi_match_i2cs))
> +			cell.acpi_match = &ljca_acpi_match_i2cs[i];
> +
> +		ret = ljca_add_mfd_cell(dev, &cell);
> +		if (ret)
> +			return ret;

What happens to stub in the error case?

> +	}
> +
> +	return 0;
> +}


> +
> +static void ljca_disconnect(struct usb_interface *intf)
> +{
> +	struct ljca_dev *dev = usb_get_intfdata(intf);
> +
> +	ljca_stop(dev);

What prevents restarting the device here?

> +	mfd_remove_devices(&intf->dev);
> +	ljca_stub_cleanup(dev);
> +	ljca_delete(dev);
> +}
> +
> +static int ljca_suspend(struct usb_interface *intf, pm_message_t message)
> +{
> +	struct ljca_dev *dev = usb_get_intfdata(intf);
> +
> +	ljca_stop(dev);
> +	return 0;
> +}
> +
> +static int ljca_resume(struct usb_interface *intf)
> +{
> +	struct ljca_dev *dev = usb_get_intfdata(intf);
> +
> +	return ljca_start(dev);

So here you report errors, but at the same time you set "started"
even if errors occur.

	Regards
		Oliver