MIME-Version: 1.0
Date:   Thu, 09 Mar 2023 14:07:23 +0100
From:   Michael Walle <michael@walle.cc>
To:     =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <zajec5@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        =?UTF-8?Q?Ra?= =?UTF-8?Q?fa=C5=82_Mi=C5=82ecki?= 
        <rafal@milecki.pl>
Subject: Re: [PATCH V2] dt-bindings: nvmem: layouts: add fixed-layout
In-Reply-To: <20230309113936.20162-1-zajec5@gmail.com>
References: <20230309113936.20162-1-zajec5@gmail.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <8478b23e903d5236500ef2f6f7edb88f@walle.cc>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Am 2023-03-09 12:39, schrieb Rafał Miłecki:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> With the introduction of NVMEM layouts we should prefer and support
> describing all NVMEM devices content in the "nvmem-layout" node. That
> inludes using it for fixed NVMEM cells (those with hardcoded offset &
> size).
> 
> This seems to be cleaner design and more explicit.
> 
> Introduce a binding allowing fixed NVMEM cells as a type of layout. To
> avoid code duplication put shared part in the fixed-cell.yaml.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

I don't feel comfortable to add an acked-by or reviewed-by here
because I don't do much with dt-bindings myself, but this looks
good to me.

 From a device tree binding POV, could there be a

nvmem-layout@0 {
   reg = <0>;
   compatible = "layout1";
};

nvmem-layout@1000 {
   reg = <1000>;
   compatible = "layout2";
};

for partitioned eeproms for example?

-michael