MIME-Version: 1.0
References: <20230307165359.225361-1-miquel.raynal@bootlin.com>
 <20230307165359.225361-4-miquel.raynal@bootlin.com> <20230308001903.GA513330-robh@kernel.org>
 <fca549f7-a79a-4d8f-b609-efef830becd2@mercury.local>
In-Reply-To: <fca549f7-a79a-4d8f-b609-efef830becd2@mercury.local>
From:   Rob Herring <robh@kernel.org>
Date:   Thu, 9 Mar 2023 07:28:59 -0600
Message-ID: <CAL_Jsq+bs1mxdTTeazhzD39fV0EBjCKZ_HKKjLpWgSezTLJ-4A@mail.gmail.com>
Subject: Re: [PATCH v2 03/21] of: Rename of_modalias_node()
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Walle <michael@walle.cc>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Robert Marko <robert.marko@sartura.hr>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Wolfram Sang <wsa@kernel.org>, Mark Brown <broonie@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 8, 2023 at 4:06=E2=80=AFPM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> Hi,
>
> On Tue, Mar 07, 2023 at 06:19:03PM -0600, Rob Herring wrote:
> > On Tue, Mar 07, 2023 at 05:53:41PM +0100, Miquel Raynal wrote:
> > > This helper does not produce a real modalias, but tries to get the
> > > "product" compatible part of the "vendor,product" compatibles only. I=
t
> > > is far from creating a purely useful modalias string and does not see=
m
> > > to be used like that directly anyway, so let's try to give this helpe=
r a
> > > more meaningful name before moving there a real modalias helper (alre=
ady
> > > existing under of/device.c).
> > >
> > > Also update the various documentations to refer to the strings as
> > > "aliases" rather than "modaliases" which has a real meaning in the Li=
nux
> > > kernel.
> > >
> > > There is no functional change.
> > >
> > > Cc: Rafael J. Wysocki <rafael@kernel.org>
> > > Cc: Len Brown <lenb@kernel.org>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: Maxime Ripard <mripard@kernel.org>
> > > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > > Cc: Sebastian Reichel <sre@kernel.org>
> > > Cc: Wolfram Sang <wsa@kernel.org>
> > > Cc: Mark Brown <broonie@kernel.org>
> > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > > ---
> > >  drivers/acpi/bus.c                |  7 ++++---
> > >  drivers/gpu/drm/drm_mipi_dsi.c    |  2 +-
> > >  drivers/hsi/hsi_core.c            |  2 +-
> >
> > These should not have been using this function. The matching on just th=
e
> > product was a relic from I2C and SPI which we don't want to propogate.
> > No clue why ACPI needed it...
> >
> > If you respin or want to fixup while applying, can you add a kerneldoc
> > comment to not add new users of the function. Not that anyone will
> > follow that... :(
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> I just checked and HSI is not using the data for matching. Instead
> it uses the returned data to set the device name. Matching happens
> using the full compatible.
>
> FWIW the MIPI HSI standard never became a big thing, so we have only
> one HSI DT driver upstream and that is the Nokia N900 modem driver.

Can we add a patch in removing the call then.

I'm pretty sure MIPI stands for Must Invent Peripheral Interfaces.

Rob