MIME-Version: 1.0
References: <20230308190745.780221-1-leitao@debian.org>
In-Reply-To: <20230308190745.780221-1-leitao@debian.org>
From:   Eric Dumazet <edumazet@google.com>
Date:   Thu, 9 Mar 2023 14:37:50 +0100
Message-ID: <CANn89iLypT46pr+ShwXu+k0hYLNwoTjbHJ1eyA_fgZyS5U-1fw@mail.gmail.com>
Subject: Re: [PATCH] tcp: tcp_make_synack() can be called from process context
To:     Breno Leitao <leitao@debian.org>
Cc:     davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, laurent.fasnacht@proton.ch,
        hkchu@google.com, leit@meta.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 8, 2023 at 8:07=E2=80=AFPM Breno Leitao <leitao@debian.org> wro=
te:
>
> tcp_rtx_synack() now could be called in process context as explained in
> 0a375c822497 ("tcp: tcp_rtx_synack() can be called from process
> context").
>
> tcp_rtx_synack() might call tcp_make_synack(), which will touch per-CPU
> variables with preemption enabled. This causes the following BUG:
>
>
> Avoid calling __TCP_INC_STATS() with will touch per-cpu variables. Use
> TCP_INC_STATS() which is safe to be called from context switch.
>
> Fixes: 8336886f786f ("tcp: TCP Fast Open Server - support TFO listeners")
> Signed-off-by: Breno Leitao <leitao@debian.org>
>

This looks good to me, thanks !

Reviewed-by: Eric Dumazet <edumazet@google.com>