Message-ID: <2865f3d0-428b-0df1-fc50-f6af3cb9dac3@suse.com>
Date:   Thu, 9 Mar 2023 14:40:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v4 2/5] gpio: Add support for Intel LJCA USB GPIO driver
Content-Language: en-US
To:     Ye Xiang <xiang.ye@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, linux-usb@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org
Cc:     srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com,
        andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com,
        zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com
References: <20230309071100.2856899-1-xiang.ye@intel.com>
 <20230309071100.2856899-3-xiang.ye@intel.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20230309071100.2856899-3-xiang.ye@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVZ1OGlzVXVXTUxLbW5idW9wenltR25rS0pjbTl2SWt5SklpS3dsblRBMTcy?=
 =?utf-8?B?cllxSnd2Y3M0VGNvK1V2ck5HKzRHWFE4OWhTT1lTeVNBcmVKTUtwK0txVHh4?=
 =?utf-8?B?QzE2bHFscklrTW1ELzBTVjNEZERNTFY5SW5sUDFGUkl6cVRWYkRpdHBWYVI5?=
 =?utf-8?B?WHhZVmdnT2ZJblhNNnhybUpwZTZram1YZUFLREhvSWpDNUk1YjhQQnZHWWR5?=
 =?utf-8?B?U1Buc3NLQUFBNUZGVFhvQUpOeTd3UTl5UzMxMmxKM3lTOGtVYm1RdUJDcVlS?=
 =?utf-8?B?WW51VVFMSXdzRmpuY1dhNmpCWHJka0F6bjYwc0hyTjFRRjU3VXJYYzFCR3Q5?=
 =?utf-8?B?dmFISlN4dnNTK2wwL1B4MGY1RkdwdUxLbm5GV3d4Rnl3OVFLVUN6Z0NuUUxx?=
 =?utf-8?B?Y1BRb2ZtSmFhNVQyQzJxWHdVSDVXT2h6N1hTRklVMEtwdE5KcU5lRVNmeFlW?=
 =?utf-8?B?aWdmbDVJZUdXYXhaTDlBdVlHYkhuNDUxdlN4LzVmTTVxRWNTYzhhajEwd0N1?=
 =?utf-8?B?YWZpRWJwOWpuN1pMUFVMWW9IUXBvdW01RTFuMDd1Z2V1Njh1dkRlaWMydnZ6?=
 =?utf-8?B?bjRsM0gvT1VIU0dnaWUyb2gxUTVvV3FRNVNpNnNha1RtMjVFa1U4ZFFzVWZJ?=
 =?utf-8?B?WU03NXFPbFV0bXRRek4wL1hQNDc4TmZpa0txUjBOZHdhVG5WWFpaVWpoWEQv?=
 =?utf-8?B?ZHJpaitSTmFQV1B1MG03WE1GK0YxYkhtdjdrWWRQVmYySGptaXZuSHRsaWtU?=
 =?utf-8?B?Nk0rZ1hxaUg1T1paWjNuM25lalBuRzhRMVFBMXRxZ3ZsK2kzRWFUNE45Nlpv?=
 =?utf-8?B?a213NmZUK2lIaVhzZ05QL3RtNGtubVpiYmphMXlwQ0NLVHR3WW9DUmkwdkZG?=
 =?utf-8?B?QUttOUovVzVKWVZ5S1krU3RCSXAzanQ0V3B3WTJZellhdW5QZWx5TDZkRDRB?=
 =?utf-8?B?eGNjbzQzbXJIbU1rSDNpQnZqVEUrd0lOWmVTak4zR1U2WDlNT2RrU29waEpE?=
 =?utf-8?B?cWFKN09zYXFQYzVVZFZibEswNy80dURaWjR2TFJpV1Rva2o4NytpVnVYVVR4?=
 =?utf-8?B?bXFSeUkyQTVkSStBaERVYWxxUHVLV0JSR0txVE1xNG0xMDMyeGJpVEJyRmN3?=
 =?utf-8?B?ZmZrVDk1RlppSUF4SU5xVmRWcnhEcWlLM3Jacll0ZUZFTjUwK0FNT2RNMjk4?=
 =?utf-8?B?U0dKYmJSOGNrYWlDQzErSi9VNVVRcHpkUXFNTTU0N2d0WDFJdUFyeFp6b1pH?=
 =?utf-8?B?azNhY0QvQnRuZ09iayszc1hMM2l5b3R4VHJQOTlZaVMxNGt2Rm9WbjNTUzlm?=
 =?utf-8?B?R0pOTjBEWkpYNmtRNHlQYW5YazloNWlKa2FkUmlobGRKUERHNjQyTS9DK2RK?=
 =?utf-8?B?eldZNGxEZWhJZktvNEJDYmZyYXltQmsxcHFEZEVFWlkwL0RORjNWOWNsV3pP?=
 =?utf-8?B?WkxLN2FEdDd0WmNDYUN0M251WTFUNXhBaDJwbjRRWFRuMXZ5NzZCWHN4OEE5?=
 =?utf-8?B?NERFcjJ0TnpCQjZDSml4OWdiVzQ1RkxZRXExQVNuU01iMDhHZmN1R1EvUC9a?=
 =?utf-8?B?MnZnbTUvT0ZOQUxjZmZwMVBSMmc1YzdyVVdBMitJSVNhdnBNRE01bUlnS3Vu?=
 =?utf-8?B?NVFyNGtUTHc4MVpHZGFKVDl2ZS84N1pwZFAvMlRXQis0elIxR3ovZEFhbTlN?=
 =?utf-8?B?ZmNMclNCdHlaSEx3a2ROMU5EWlhLQStVWVdvN28zMVdqUlN2Z3B2SlArZW12?=
 =?utf-8?B?M0Z3R0dHc28yUlJXRTVmM25rVWExK3Y5U0JzRTN6NG13aitacDJSdjJNdndn?=
 =?utf-8?B?c3ZSTW5FakYvNUw5UEVyNWhiSXh2UkJKdnlmb0gwQXdWS0JEUjJpQmFUWjVW?=
 =?utf-8?B?TjFnOCtLRTlkRUw0ckNpQUtHVEVaNmlialhmNUc3bmRlM2xzcEo1SEV6WWdv?=
 =?utf-8?B?K3d5LzlsSTg2R1Rra0xBZFJVTWE5ZitnSVpmVXRPdGc0SVBrTlpvWnM3SzVm?=
 =?utf-8?B?RzFObVlmdk5USXM2ODJiY2JlK1pER3ZPZVB5WGl3cUZEcE82MU5jT3VKMzNu?=
 =?utf-8?B?OHc4MUg4OGxOVSt5YjVmbUVUcTJmTzlWdDFVOGhJK2g1em9paFo5UExOSlVo?=
 =?utf-8?B?SVlXZkZhZG5pSkw5NXNyL3NEN0luc05uU1p3V0orL2lXQlV4ZEkvajVuVnZp?=
 =?utf-8?Q?Iz+8ejdT8POzuNGujCTIqy4a/OyQR0eELBIS4be+PCME?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: befe4798-c276-493b-98a7-08db20a3cf7f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 13:40:13.7623
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DH2EYmlPhuSxURqPs9dVFvQf8rLex0u/FoANYh+IdThhkWgfbyZTnfMWA5OUSsAZlxRJwyNc3irUX78ECWZnyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8202
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 09.03.23 08:10, Ye Xiang wrote:

> +#define LJCA_GPIO_BUF_SIZE 60
> +struct ljca_gpio_dev {
> +	struct platform_device *pdev;
> +	struct gpio_chip gc;
> +	struct ljca_gpio_info *gpio_info;
> +	DECLARE_BITMAP(unmasked_irqs, LJCA_MAX_GPIO_NUM);
> +	DECLARE_BITMAP(enabled_irqs, LJCA_MAX_GPIO_NUM);
> +	DECLARE_BITMAP(reenable_irqs, LJCA_MAX_GPIO_NUM);
> +	u8 *connect_mode;
> +	/* mutex to protect irq bus */
> +	struct mutex irq_lock;
> +	struct work_struct work;
> +	/* lock to protect package transfer to Hardware */
> +	struct mutex trans_lock;
> +
> +	u8 obuf[LJCA_GPIO_BUF_SIZE];
> +	u8 ibuf[LJCA_GPIO_BUF_SIZE];

And here we have a violation of DMA coherency rules.
Basically you cannot embed buffers into other data structures
if they can be subject to DMA.


> +static int ljca_gpio_remove(struct platform_device *pdev)
> +{
> +	struct ljca_gpio_dev *ljca_gpio = platform_get_drvdata(pdev);
> +
> +	gpiochip_remove(&ljca_gpio->gc);
> +	ljca_unregister_event_cb(ljca_gpio->gpio_info->ljca);
> +	mutex_destroy(&ljca_gpio->irq_lock);
> +	mutex_destroy(&ljca_gpio->trans_lock);

At this time, what has made sure that no work is scheduled?

> +	return 0;
> +}

	Regards
		Oliver