Date:   Thu, 9 Mar 2023 14:47:52 +0100
From:   Lukasz Majewski <lukma@denx.de>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexander Duyck <alexander.duyck@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] dsa: marvell: Add helper function to validate the
 max_frame_size variable
Message-ID: <20230309144752.5e62e037@wsk>
In-Reply-To: <ZAnefI4vCZSIPkEK@shell.armlinux.org.uk>
References: <20230309125421.3900962-1-lukma@denx.de>
        <20230309125421.3900962-6-lukma@denx.de>
        <ZAndSR4L1QvOFta6@shell.armlinux.org.uk>
        <ZAnefI4vCZSIPkEK@shell.armlinux.org.uk>
Organization: denx.de
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/lv_wEMCvIFJXo6OqNLGw5zo";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/lv_wEMCvIFJXo6OqNLGw5zo
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Russell,

> On Thu, Mar 09, 2023 at 01:21:13PM +0000, Russell King (Oracle) wrote:
> > On Thu, Mar 09, 2023 at 01:54:19PM +0100, Lukasz Majewski wrote: =20
> > > This commit shall be regarded as a transition one, as this
> > > function helps to validate the correctness of max_frame_size
> > > variable added to mv88e6xxx_info structure.
> > >=20
> > > It is necessary to avoid regressions as manual assessment of this
> > > value turned out to be error prone.
> > >=20
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk> =20
> >=20
> > Shouldn't this be patch 2 - immediately after populating the
> > .max_frame_size members, and before adding any additional devices? =20
>=20
> Moreover, shouldn't the patch order be:
>=20
> 1, 5, 6 (fixing the entry that needs it), 7 (which then gets the
> max frame size support in place), 4 (so that .set_max_frame_size for
> 6250 is in place), 2, 3
>=20
> ?
>=20
> In other words, get the new infrastructure you need in place first
> (that being the new .max_frame_size and the .set_max_frame_size
> function) before then adding the new support.
>=20

Ok, I will reorder those patches and submit v6.

Do you have any other comments regarding this patch set?


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/lv_wEMCvIFJXo6OqNLGw5zo
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmQJ44gACgkQAR8vZIA0
zr10yggAo1vG2xwQvNUMsJwxrgZuAvdCXxJe4pYukh5o564iNNp8GdUgC3JitCUZ
B5HLPBH/d4zSqWT2S4cTHOcv1SlSQPLSK/2t6E43nqPOV9hh5HSPnxBR3qB6+Jo0
ReB6EdCi4nlcz7gSrZ4DUwyRFzjhXSaf6GrNcvqOZI4gjczyBmuB/sm4yKfWiNXQ
JwZ09sh8Ynv/mFs6PMVql1L/mRww0cbrysBvTal4jjOmMKpommCpOjPC6CDeYA0E
3Q95qFkyS/4FO2uIzelJ9BCRLMaGDfu+VF2si+hgNFTvSdKb4i3C783PIru/l7cp
Y3GRlVQoycU7ZSlelMDinvKxmJbgMw==
=qWDo
-----END PGP SIGNATURE-----

--Sig_/lv_wEMCvIFJXo6OqNLGw5zo--