Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C2DAC61DA4 for ; Thu, 9 Mar 2023 14:12:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231673AbjCIOMJ (ORCPT ); Thu, 9 Mar 2023 09:12:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231659AbjCIOL0 (ORCPT ); Thu, 9 Mar 2023 09:11:26 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B391A6152D; Thu, 9 Mar 2023 06:10:05 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0435EAD7; Thu, 9 Mar 2023 06:10:49 -0800 (PST) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 94FC63F5A1; Thu, 9 Mar 2023 06:10:04 -0800 (PST) From: Sudeep Holla To: Cristian Marussi , Dan Carpenter Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: Clean up a return statement Date: Thu, 9 Mar 2023 14:10:02 +0000 Message-Id: <167837075462.2091199.3854987429917984262.b4-ty@arm.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Jan 2023 18:07:07 +0300, Dan Carpenter wrote: > The comments say "enabled" where "disabled" is intended. Also it's > cleaner to return zero explicitly instead of ret. > > Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks! [1/1] firmware: arm_scmi: Clean up a return statement https://git.kernel.org/sudeep.holla/c/8ab5059dc4f4 -- Regards, Sudeep