Message-ID: <ef2f8faf-76cc-d221-8281-cc7b8cb68485@intel.com>
Date:   Thu, 9 Mar 2023 16:12:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.8.0
Subject: Re: [PATCH v1 2/4] Revert "dt-bindings: mmc: Add bindings for Intel
 Thunder Bay SoC"
Content-Language: en-US
To:     Krzysztof Kozlowski <krzk@kernel.org>, rashmi.a@intel.com,
        ulf.hansson@linaro.org, michal.simek@xilinx.com,
        linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        robh+dt@kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kishon@ti.com, vkoul@kernel.org,
        andriy.shevchenko@linux.intel.com, linux-phy@lists.infradead.org,
        mgross@linux.intel.com
Cc:     kris.pan@linux.intel.com, mahesh.r.vaidya@intel.com,
        nandhini.srikandan@intel.com, vasavi.v.itha@intel.com,
        kenchappa.demakkanavar@intel.com, furong.zhou@intel.com,
        mallikarjunappa.sangannavar@intel.com
References: <20230124054427.28808-1-rashmi.a@intel.com>
 <20230124054427.28808-2-rashmi.a@intel.com>
 <c850df25-57b8-3172-8e5c-c466dc8556cd@kernel.org>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <c850df25-57b8-3172-8e5c-c466dc8556cd@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 24/01/23 13:31, Krzysztof Kozlowski wrote:
> On 24/01/2023 06:44, rashmi.a@intel.com wrote:
>> From: "A, Rashmi" <rashmi.a@intel.com>
>>
>> This reverts commit ab991c05c42853f0b6110022db9bf30fcc6323dd.
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC.  It might happen, that command when run on an older
> kernel, gives you outdated entries.  Therefore please be sure you base
> your patches on recent Linux kernel.
> 
>>
>> Revert Thunder Bay specific code as the product got cancelled
>> and there are no end customers.
>>
>> Signed-off-by: A, Rashmi <rashmi.a@intel.com>
>> Reviewed-by: Hunter, Adrian <adrian.hunter@intel.com>wq
> 
> Stray characters.
> 
>> ---
>>  .../devicetree/bindings/mmc/arasan,sdhci.yaml | 25 -------------------
>>  1 file changed, 25 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> index 4053de758db6..0d5d21dd30bb 100644
>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> @@ -88,12 +88,6 @@ properties:
>>          description:
>>            For this device it is strongly suggested to include
>>            arasan,soc-ctl-syscon.
>> -      - items:
>> -          - const: intel,thunderbay-sdhci-5.1   # Intel Thunder Bay eMMC PHY
>> -          - const: arasan,sdhci-5.1
> 
> Instead should be made rather deprecated, unless you are sure there is
> no single person in the world using the bindings (e.g. with BSD or
> bootloader)?

I am sorry but this is not clear to me.  As I understand it,
the hardware was never released, so the binding serves no
purpose.  Should it be removed or "deprecated"?