Message-ID: <b9ddc3ff-ddfa-846b-61f8-cdcfcb71510e@kernel.org>
Date:   Thu, 9 Mar 2023 22:28:38 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] erofs: fix wrong kunmap when using LZMA on HIGHMEM
 platforms
Content-Language: en-US
To:     Gao Xiang <hsiangkao@linux.alibaba.com>,
        linux-erofs@lists.ozlabs.org
Cc:     LKML <linux-kernel@vger.kernel.org>, stable@vger.kernel.org
References: <20230305134455.88236-1-hsiangkao@linux.alibaba.com>
From:   Chao Yu <chao@kernel.org>
In-Reply-To: <20230305134455.88236-1-hsiangkao@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/3/5 21:44, Gao Xiang wrote:
> As the call trace shown, the root cause is kunmap incorrect pages:
> 
>   BUG: kernel NULL pointer dereference, address: 00000000
>   CPU: 1 PID: 40 Comm: kworker/u5:0 Not tainted 6.2.0-rc5 #4
>   Workqueue: erofs_worker z_erofs_decompressqueue_work
>   EIP: z_erofs_lzma_decompress+0x34b/0x8ac
>    z_erofs_decompress+0x12/0x14
>    z_erofs_decompress_queue+0x7e7/0xb1c
>    z_erofs_decompressqueue_work+0x32/0x60
>    process_one_work+0x24b/0x4d8
>    ? process_one_work+0x1a4/0x4d8
>    worker_thread+0x14c/0x3fc
>    kthread+0xe6/0x10c
>    ? rescuer_thread+0x358/0x358
>    ? kthread_complete_and_exit+0x18/0x18
>    ret_from_fork+0x1c/0x28
>   ---[ end trace 0000000000000000 ]---
> 
> The bug is trivial and should be fixed now.  It has no impact on
> !HIGHMEM platforms.
> 
> Fixes: 622ceaddb764 ("erofs: lzma compression support")
> Cc: <stable@vger.kernel.org> # 5.16+
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,