From:   Vishnu Dasa <vdasa@vmware.com>
To:     "Uladzislau Rezki (Sony)" <urezki@gmail.com>
CC:     LKML <linux-kernel@vger.kernel.org>, RCU <rcu@vger.kernel.org>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>,
        Jens Axboe <axboe@kernel.dk>,
        Philipp Reisner <philipp.reisner@linbit.com>,
        Bryan Tan <bryantan@vmware.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Eric Dumazet <edumazet@google.com>,
        Bob Pearson <rpearsonhpe@gmail.com>,
        Ariel Levkovich <lariel@nvidia.com>,
        Theodore Ts'o <tytso@mit.edu>, Julian Anastasov <ja@ssi.bg>
Subject: Re: [PATCH 03/13] misc: vmw_vmci: Rename kvfree_rcu() to
 kvfree_rcu_mightsleep()
Thread-Topic: [PATCH 03/13] misc: vmw_vmci: Rename kvfree_rcu() to
 kvfree_rcu_mightsleep()
Thread-Index: AQHZNk8LqGl6mptIS0m15e4cEL6+UK7yvIKA
Date:   Thu, 9 Mar 2023 14:36:52 +0000
Message-ID: <76DE4E7B-D642-481D-9FFC-D9B0AD74A3BD@vmware.com>
References: <20230201150815.409582-1-urezki@gmail.com>
 <20230201150815.409582-4-urezki@gmail.com>
In-Reply-To: <20230201150815.409582-4-urezki@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ucfBDVw+kumRAOtoXNdv0rg7dMPrrf4du7aGNXFHI4ON6l4ej9RFxh5U5zAV?=
 =?us-ascii?Q?oZl9jJlgYhn5fLTyK7JzwwWdq+Imtlo1xHTN20QaL0PCpBXqPKJUy1s2G1MF?=
 =?us-ascii?Q?czSxBZXrW5itaHZZ697vWXE9MT4zT/FA/cW6qUh0GniprI6GR/k7g65vieoX?=
 =?us-ascii?Q?Vu4VmiHR+7xpBxjkfB/0MX0ab4UCGviwFpUUUIJzMsbqk+wL3hgA4h40XzF6?=
 =?us-ascii?Q?+MvYAXUuQu5uUXMSUSttCp4FXHpN8olRBHGwf83tI+NJ10Yrz/zPo0lq1BOJ?=
 =?us-ascii?Q?aIs5Ln9sdmB4YJnFTssvlB7xtFjpAxS4GPIW8b4+91UQOC4K7hCK1O7ega9H?=
 =?us-ascii?Q?gKaIj6oFBSC8l9D19tNZ+unPrg8MMlwSDYwzvLjqHNdER9M3xRO2pBusVUP4?=
 =?us-ascii?Q?ReFPqb33Mnq86wdyZEQveXliQneQeFr/jv79y8YfUg20dQXw6Lz52gvL1hZ/?=
 =?us-ascii?Q?ouPcnKepGNw66Vf6qEvH61Lw7uDuDW+lRMbGXayKbUyrkdVWuzm+eROE5jY4?=
 =?us-ascii?Q?5Ybzg3T0aRfhA/yuLv9aiOj4BTyVNoRAl/oDLbupPVy8H/716AuYH60qfeyJ?=
 =?us-ascii?Q?DiRBoyEuj74KHMZlSoyGiombRv8Spn9edyiPeu2Wi0bZFuKDar5T3kjjcjEz?=
 =?us-ascii?Q?sz5QILRzqBo8a/2anjTG5D4OKEU7wGplHUx7B4FctVP4PPjfFizDAWf+vJ2E?=
 =?us-ascii?Q?P2ijtT+PTVilpPFwqODVLXSIWoufyb4+jd5eHEACvIGSTG8WQ6U9nJ9fuFPT?=
 =?us-ascii?Q?taljhiI0ck+NHMOxwHxHYzvL5ycUkMXXAYj7UsPS7whe95U7f/u5HJtclvlq?=
 =?us-ascii?Q?+2bB42Lnrm6XvxTQM78RypJhsAZoNCHdR1Szux2bgBI2HTX47kSO0w7BCll0?=
 =?us-ascii?Q?DCMRT+KvbKqwfc+wjt2csTbG0ug/0a+fv4YyKtRUqFjM30lnDK9Cw5FWLa4u?=
 =?us-ascii?Q?+FuDPt0BZaViBsUxgXpM/skSXwPTgmhonV1NU6KNrr2M6w8h2i6Nu4USorod?=
 =?us-ascii?Q?6Uz8gi5H15FszstzfXWUMJVPaJ3dFXjHWNT0BvOJJaWD76iGbCPqyCIaiJmo?=
 =?us-ascii?Q?uB2Kgxf6EiYb7uBRHbSeOgOZMpxZ1+t6TP/mXtBgRiuXdVI1Al1nIMdcBeME?=
 =?us-ascii?Q?Jw+ZKzi/+d5dyA8Iq3ImV6EdWmjvO08bO0dC/i9g+9HeWOXzdlaWvNtIyROy?=
 =?us-ascii?Q?bSEdCeuSd8n5xMiToV43WLAPCDnlBPF1rWzK0ofVAmrI7SZ36c/ot38mQplN?=
 =?us-ascii?Q?Wk3lEwtBJ3UPCOKi3mCeqR72dqqGzYT1CMf4RCw/NDnWmyPbjscVVncuKNoy?=
 =?us-ascii?Q?sD/n+9JoTGvv7bwJ/KKp9b7tG9lHI7ogqxRbZr2u8Uc9Jm+S061qwgrm85it?=
 =?us-ascii?Q?BPgYjbmQVsYIBMkD4LDAwav8Y5ZUexa6JyeNS0xDkg3fP21KEVbXohx41bgj?=
 =?us-ascii?Q?kZTdYSHUm0Ytgd+XEwRp2YZY8iaUwEugweVPe8999er0fNbwrsJPhncwH5IG?=
 =?us-ascii?Q?VY5f3MwjolusGhkEKbuEJ6/UDyOch0S8ixFIRHYVt4Ktz054R2AymGviWMoc?=
 =?us-ascii?Q?a6EBsm7EM439Vpy5A8ERBz7z4kN2202oKaB4HTjkQ6ypvLKrerM+iIwdXt/0?=
 =?us-ascii?Q?SElt1EbNUbin4GO1caOLZAz0shrPFWEDu7AL+NkiWSLf?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1DBEDCFFFBF1D84BA2333D056269B8BA@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB3960.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13f003dc-fe31-4513-c81f-08db20abb935
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2023 14:36:52.1550
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JZdNdTaFoGzKKJz5YV4llGqPEAt0xvSRXNlquq7PdqMAflr/rMyTOipTzY7dBrYlvhAG2Jhx6lhbjRDl4XEZhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR05MB7486
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Feb 1, 2023, at 7:08 AM, Uladzislau Rezki (Sony) <urezki@gmail.com> wr=
ote:
>=20
> The kvfree_rcu()'s single argument name is deprecated therefore
> rename it to kvfree_rcu_mightsleep() variant. The goal is explicitly
> underline that it is for sleepable contexts.
>=20
> Cc: Bryan Tan <bryantan@vmware.com>
> Cc: Vishnu Dasa <vdasa@vmware.com>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

Reviewed-by: Vishnu Dasa <vdasa@vmware.com>

> ---
> drivers/misc/vmw_vmci/vmci_context.c | 2 +-
> drivers/misc/vmw_vmci/vmci_event.c   | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/misc/vmw_vmci/vmci_context.c b/drivers/misc/vmw_vmci=
/vmci_context.c
> index 172696abce31..f22b44827e92 100644
> --- a/drivers/misc/vmw_vmci/vmci_context.c
> +++ b/drivers/misc/vmw_vmci/vmci_context.c
> @@ -687,7 +687,7 @@ int vmci_ctx_remove_notification(u32 context_id, u32 =
remote_cid)
> spin_unlock(&context->lock);
>=20
> if (notifier)
> - kvfree_rcu(notifier);
> + kvfree_rcu_mightsleep(notifier);
>=20
> vmci_ctx_put(context);
>=20
> diff --git a/drivers/misc/vmw_vmci/vmci_event.c b/drivers/misc/vmw_vmci/v=
mci_event.c
> index 2100297c94ad..5d7ac07623c2 100644
> --- a/drivers/misc/vmw_vmci/vmci_event.c
> +++ b/drivers/misc/vmw_vmci/vmci_event.c
> @@ -209,7 +209,7 @@ int vmci_event_unsubscribe(u32 sub_id)
> if (!s)
> return VMCI_ERROR_NOT_FOUND;
>=20
> - kvfree_rcu(s);
> + kvfree_rcu_mightsleep(s);
>=20
> return VMCI_SUCCESS;
> }
> --=20
> 2.30.2
>=20