Message-ID: <e51d01a9-c678-18a8-b861-894315c872a9@amd.com>
Date:   Thu, 9 Mar 2023 10:03:58 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] drm/amd/display: Use swap() instead of open coding it
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        harry.wentland@amd.com
Cc:     sunpeng.li@amd.com, Abaci Robot <abaci@linux.alibaba.com>,
        Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
        alexander.deucher@amd.com, airlied@gmail.com,
        christian.koenig@amd.com
References: <20230309025250.2534-1-jiapeng.chong@linux.alibaba.com>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230309025250.2534-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wjg4S3NRMndId211UlFEU2ZEN2toK01CMXNyVHVXRGtSdDgzRUpwVVlHUzYz?=
 =?utf-8?B?TEZBSkExcVR0dDQvOVVpRXdCeTE5TnY1YmUyajhtK1BPUi9SYU5lVlhqWFVi?=
 =?utf-8?B?VThpdSt4VTlOQUhBNDRkWmVSY2JiOVMzM0hveHp6VjdrZWlwd212TWc2RkdK?=
 =?utf-8?B?L0ZCSERRUEZGbkVtU29yME8zN0ZrdjJNVkNwaUdLSDJkWkZjdmlFVTNwUHND?=
 =?utf-8?B?ZUo0RC9QS21xMXpoazRLaWZZL2R3YmJwNVRhMy82TVJ0Z3NZdnR2aXFFVGs2?=
 =?utf-8?B?aU11eUt4K3ZZRXRCSjhVREF2bVQzYkM4OUdrY1JhaG16QTVremlYUkxOMC8z?=
 =?utf-8?B?bnpmYWVIL1FLdXRscllCdGpacngvY1Z6d1Y3SStVT1puajBqOTNrMUVQQ1p4?=
 =?utf-8?B?WmlvU3FvaExHd2lBWHJkdVJVbzhkekN1R2pFZDB3YWpCTmhnRlp0dGx5WU5U?=
 =?utf-8?B?NU9LSE5zaU4wT2pSa1NhSUF1WmlHV2EvUWl2eVhNNTdxZmFJVmVuNEppMjBo?=
 =?utf-8?B?Y3NaUUhKMGRBUWZpcDNYVm12UnZaWEF2dTV4MGRKQmNqUkN2ZGZUWGFnelhw?=
 =?utf-8?B?dUNLVVpzNHM3d2RIMmMvZlBDVDJsUmFSeDFzQVFTaS85RXlLeExJZFVKZVpK?=
 =?utf-8?B?SndYc2oyZzB3c2hMNExLa01BcEsvaXQ5Ym9UNnBjL0NURnRTWlBRWUtWbnZj?=
 =?utf-8?B?SzVpemkrcGVmN29tY0F6Yld4WjJXTGZRNmRPNTVEMEVSb1Q0MEQ3aHd5T0Nl?=
 =?utf-8?B?SUM1eUhKVGpVL0twQklsQWQzR2pyYWVlemJzRmNzTWpWb0FzNVF4NnlINUFs?=
 =?utf-8?B?OUwrNGZqcmRmNkNVa0ZsQUVPaVZnMGYxelYrZzgrZmZqZHdvT2h1eGZYeDRO?=
 =?utf-8?B?SVN1bnY2OUpyZGU1Yk1sdGs5ek1mQm9nODkvSmJQSUU1b0QvTnNYcDV3NHpZ?=
 =?utf-8?B?dUo3Q21JeDhyNXJFK3FKakw0bHV3RjhGNEVCVVpycUF6S2VOSmRabWNyT3JB?=
 =?utf-8?B?N1F0ejVTcU1TbUlaNzVlMXFzaTZqYkhjTXZYbnZjR3dYSHNwNG1xeTdvVFVK?=
 =?utf-8?B?dmZLNEk1Wk4xWk5QVUF5emVudjZRaUhiSGFJK0cxa0ZiN2dqMDQyQXQvaWt2?=
 =?utf-8?B?QUR5cGFRN0pSUms2b1g2MUhhYUpheDlwQ3RIVkEyTlJGNXI2YzNIT1FJSkh6?=
 =?utf-8?B?RUpNanMxUnJldkJvdTJ6NE9uS0ZUQTJhR2pTbnhqSms1NG5PZkhwRlhrbkF6?=
 =?utf-8?B?WkF5aHhIbEtrMGZsYXg2QnBCNVRMa3VkVjh2OWNJS3BVdnNCRjAxUlNpRWxn?=
 =?utf-8?B?ZnBYLzFIT240ZlFQUzBRTU12TWpCeWdkQmxFWU5HcGExZXBTMk1WZzlFVGdt?=
 =?utf-8?B?YUF5bkFRN2F3cnZicmpHSUtYMnQ1SEx1WVRxSUE5Vi9wSHVHVkpZbkliOE5t?=
 =?utf-8?B?d2xKMk1FR3pFbEtJclFvSGR3dnVhemc3NmJCT2VxRUxMYTMrNlpUZEdlMHAy?=
 =?utf-8?B?N2s3UWl5T2N4NlJLa1BCZXk0dGtEVU4rRzI4UUQ4a0VnRVdLdWkzNmxPenY3?=
 =?utf-8?B?d3ljYzJiblhaSVNXVnFacWFhR0t4WEtjaDhWSU9NeUlRU2ZOdXlHdUEvSm5q?=
 =?utf-8?B?a2RuNkVMM1RrVHdvUGlubFVHZWJ5QXVVWXVML20zOVpyRlRPYkswdTUxT1Jy?=
 =?utf-8?B?MWRwWFROR3Rhc0dHSDB0SGJRd1JNRGpTcWh5RHVjcWZaY01ycG1WVExzdXZK?=
 =?utf-8?B?aUt6dXQwTkQ3Z2dobE9ONzJvS3EvTUJxQnlSUWpFMWc3YjM2MEtrVkpmcW9i?=
 =?utf-8?B?R3VvdmcwL3Y1V3RTbTN1dFJqaVFYZklrcG9ETkVJZmxsTmhHM0llYmJHU3NO?=
 =?utf-8?B?TU14MUc4aGtHUTBDVTVsWi9XTDF2dXZBZW1EY1FGbFJ3KzhHbGZBOGFGZTlB?=
 =?utf-8?B?Wjhsd0xyaG03a0NYN241VXRydllYY2VRSjBPTzZyS3R4QkFXYjV5OG45K2NE?=
 =?utf-8?B?c1AvMnJFa2dOZWNGOUZvT3FtVUtNSjdDb0VWNmttUVJDV3diMnNySHkwVEZp?=
 =?utf-8?B?MFNFeWVlRURaOGtOU3ZDTnZyc1lob2U1eWhaU0ZZNnNFSlFxUW9QMmVvZ2k0?=
 =?utf-8?Q?bmpIo3TsJeMj3Dva2xtQVke8b?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0005e5dd-9ef7-4d42-ff06-08db20af563c
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 15:02:44.4072
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eMLsIvwvawZcWrJpIdpJB/57VFiED6j/+/7eSLeUSGz0swPQx9ObUl2moTNY88JEc2GFggK69YK7c4pZ/M6OZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8274
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/8/23 21:52, Jiapeng Chong wrote:
> Swap is a function interface that provides exchange function. To avoid
> code duplication, we can use swap function.
> 
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:359:57-58: WARNING opportunity for swap().
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4448
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index ae994c6c65ac..f6d9bbce15b2 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -352,13 +352,9 @@ static inline void reverse_planes_order(struct dc_surface_update *array_of_surfa
>   					int planes_count)
>   {
>   	int i, j;
> -	struct dc_surface_update surface_updates_temp;
>   
> -	for (i = 0, j = planes_count - 1; i < j; i++, j--) {
> -		surface_updates_temp = array_of_surface_update[i];
> -		array_of_surface_update[i] = array_of_surface_update[j];
> -		array_of_surface_update[j] = surface_updates_temp;
> -	}
> +	for (i = 0, j = planes_count - 1; i < j; i++, j--)
> +		swap(array_of_surface_update[i], array_of_surface_update[j]);
>   }
>   
>   /**

-- 
Hamza