Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896CCC61DA4 for ; Thu, 9 Mar 2023 15:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229800AbjCIPFt (ORCPT ); Thu, 9 Mar 2023 10:05:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232269AbjCIPEw (ORCPT ); Thu, 9 Mar 2023 10:04:52 -0500 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08AA91CBDC for ; Thu, 9 Mar 2023 07:02:58 -0800 (PST) Received: by mail-pg1-x52b.google.com with SMTP id 16so1203307pge.11 for ; Thu, 09 Mar 2023 07:02:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678374178; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=w52L9bYd1Bk6tnZiJ30njJezcD67pXQ479mx0gzX4ic=; b=jiI7Xlfv43mVsBRCrivf6VVVUS7KhuPjXox6NR+7xu+z9s/Anbh+SXWWfnWLUYp+Nz 5wFfne+FDFSlZF6USZ/cHZwFuY0X44974OQOaGKl4EDCaguAmy/gRKdc9/E62sZD+HYf WyoMkEaKJbzEQi15K6oK/+PZvRHAMCJrmp4U2OenejuRwyJ1oah1ooydu8v/N9X+cvax N/PIdum5sSM1nJePvdDnQwCdIgvseipInSSdkrnTytg7J1+KNmBKJ+h62sQ5+vDQl+B1 NpsPgKdrpeGsbrmj6veRNJDAWrrrYs9Hj4pUBbtdX8fX6ECvpaIAv4VIJiHEU5Xl6TDM YiEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678374178; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w52L9bYd1Bk6tnZiJ30njJezcD67pXQ479mx0gzX4ic=; b=j9XTIumi+Cww5m38WMGST/j1Yer2gvhlvEarMD5KB3uZdZoUOxt78hl4xJBbNcGcfJ PoD5ck3Ey6Jg++o5g4Tt9BgMSYAznyZtxovu6RWhYYDGSTbHA3N9aYv9sr5Yyfjfd+fM JpUTngxF1bJXxI72On5X0f7uLbHwG2PNbSMt/DPXunPRvhgAn+/l5frki6mAHmUQ4vwa 59sawJ3MXGJKhDkqDHboypiBQCwuM6/2rL5CPL5Iis9ZCbZ78EaBO3TNr6QC1wBIBQ4t Dz6+JsSeqC3Pl19y5cboS1o6TKnLdwTUKtCWr5Py1YbcB+DoWqZIGxjVjHVx5TrH3Hdi iPaQ== X-Gm-Message-State: AO0yUKX6KlHbPx9mDeqcs5ia+kweqXmDTtR//4sHfWyrdSf/5Yf0/6SU ThJCOUj7JCbs+HTCXWkRLTuR/ufy94uZSRu33Uzndg== X-Google-Smtp-Source: AK7set9vajz4jP/NGsZsd24Uz/GQxHNaDN1S1IbU2x6PLLKhY/MQcMgXaA0Q5HKDXcKWIDYpomT/1YSWtfwWZaEzY/0= X-Received: by 2002:a63:f91d:0:b0:502:fd12:83ce with SMTP id h29-20020a63f91d000000b00502fd1283cemr7999614pgi.5.1678374178256; Thu, 09 Mar 2023 07:02:58 -0800 (PST) MIME-Version: 1.0 References: <20230307163041.3815-1-wsa+renesas@sang-engineering.com> <20230307163041.3815-9-wsa+renesas@sang-engineering.com> In-Reply-To: <20230307163041.3815-9-wsa+renesas@sang-engineering.com> From: Ulf Hansson Date: Thu, 9 Mar 2023 16:02:21 +0100 Message-ID: Subject: Re: [PATCH 08/11] mmc: renesas_sdhi: remove R-Car H3 ES1.* handling To: Wolfram Sang Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , Geert Uytterhoeven , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Mar 2023 at 17:31, Wolfram Sang wrote: > > R-Car H3 ES1.* was only available to an internal development group and > needed a lot of quirks and workarounds. These become a maintenance > burden now, so our development group decided to remove upstream support > and disable booting for this SoC. Public users only have ES2 onwards. > > Reviewed-by: Laurent Pinchart > Reviewed-by: Geert Uytterhoeven > Signed-off-by: Wolfram Sang Applied for next, thanks! Kind regards Uffe > --- > Please apply individually per subsystem. There are no dependencies and the SoC > doesn't boot anymore since v6.3-rc1. > > drivers/mmc/host/renesas_sdhi_internal_dmac.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c > index f38003f6b1ca..9ab813903b2c 100644 > --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c > +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c > @@ -72,11 +72,10 @@ enum renesas_sdhi_dma_cookie { > > static unsigned long global_flags; > /* > - * Workaround for avoiding to use RX DMAC by multiple channels. > - * On R-Car H3 ES1.* and M3-W ES1.0, when multiple SDHI channels use > - * RX DMAC simultaneously, sometimes hundreds of bytes data are not > - * stored into the system memory even if the DMAC interrupt happened. > - * So, this driver then uses one RX DMAC channel only. > + * Workaround for avoiding to use RX DMAC by multiple channels. On R-Car M3-W > + * ES1.0, when multiple SDHI channels use RX DMAC simultaneously, sometimes > + * hundreds of data bytes are not stored into the system memory even if the > + * DMAC interrupt happened. So, this driver then uses one RX DMAC channel only. > */ > #define SDHI_INTERNAL_DMAC_RX_IN_USE 0 > > @@ -222,7 +221,6 @@ static const struct renesas_sdhi_quirks sdhi_quirks_r9a09g011 = { > */ > static const struct soc_device_attribute sdhi_quirks_match[] = { > { .soc_id = "r8a774a1", .revision = "ES1.[012]", .data = &sdhi_quirks_4tap_nohs400 }, > - { .soc_id = "r8a7795", .revision = "ES1.*", .data = &sdhi_quirks_4tap_nohs400_one_rx }, > { .soc_id = "r8a7795", .revision = "ES2.0", .data = &sdhi_quirks_4tap }, > { .soc_id = "r8a7796", .revision = "ES1.0", .data = &sdhi_quirks_4tap_nohs400_one_rx }, > { .soc_id = "r8a7796", .revision = "ES1.[12]", .data = &sdhi_quirks_4tap_nohs400 }, > -- > 2.35.1 >