Date:   Thu, 9 Mar 2023 23:45:51 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Andi Shyti <andi.shyti@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        "Lee Jones" <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        <linux-usb@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <srinivas.pandruvada@intel.com>,
        <heikki.krogerus@linux.intel.com>,
        <andriy.shevchenko@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <zhifeng.wang@intel.com>,
        <wentong.wu@intel.com>, <lixu.zhang@intel.com>
Subject: Re: [PATCH v4 1/5] mfd: Add support for Intel LJCA device
Message-ID: <ZAn/L8Dg/Ehx9bMo@ye-NUC7i7DNHE>
References: <20230309071100.2856899-1-xiang.ye@intel.com>
 <20230309071100.2856899-2-xiang.ye@intel.com>
 <ZAmQOIh/71rY4Pa4@kroah.com>
 <ZAmngB84ty1flD9K@ye-NUC7i7DNHE>
 <ZAmpse14Evvrfa/f@kroah.com>
 <ZAmvocpy68qurCvt@intel.intel>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZAmvocpy68qurCvt@intel.intel>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HWGpaPfng1XnvTVQJ4lbpcdF17fLKtIgQTHbf45T5gw9tS/m1HUXvBmcPwyn?=
 =?us-ascii?Q?N1ZgbLOqVcDnD4DY6TsbkmEYKiLBCR3ijhvnhtRXbJ3QdFYdbq6C45LhMOeh?=
 =?us-ascii?Q?bRAgFRF1cdcLadCr6mDM4KzPAopQZu1RRHi/EfKy7UFHUsuS9bL34FZMHJni?=
 =?us-ascii?Q?1gXdsNHfon7VD4+Ykx6u9eWswEcekSGxd6m81cgvt0tnYSkQ+60khl/Kqoth?=
 =?us-ascii?Q?Uu9Tc1EEScoHKABalblZzKwRgJ4eTo+nCVZegqZyRx4iH3rJyh2GllN6/2rY?=
 =?us-ascii?Q?2bQ5jpf2zBbi03vVvheGB3IY0LZPSpZLxPYIk5c5NWfYQhXM6we5647eBRJh?=
 =?us-ascii?Q?B0BTjq1K28P2TQOxFraSt9cjuJLIkaHYXm2A0RX+mbGwYhxq/LYLzJoXn5Xw?=
 =?us-ascii?Q?RZx6T/B1j2ORAJSFtrmw6f4gdljX7YpBx82/otJvGQkdLAkYJWssfohAnbV7?=
 =?us-ascii?Q?vKciBJGRoBHlCa5lgdvV5PsHo47zhZLJhmAxsjxmF24TUyQ1o/23jAfSlwdA?=
 =?us-ascii?Q?qRPiBErDNvhHSN8IObeD1iCTwzWuqYEcINa5zYv+SWPNodGtMBqsxVtsLZQY?=
 =?us-ascii?Q?/oERH/pYFVfozakakqmFntQW0Ozagw5J377RXRv+1c94GfO7yWWHkEaWFBo+?=
 =?us-ascii?Q?S75DYw621hHQTyg7UwePsE7uTHhciPbeg1iqRjnzPANQmOdP4EpQAnnevSX8?=
 =?us-ascii?Q?Kfvv10uwwaGBa/diIjek6DDL1ZbLK+BehdktRBeF8aa+uVQpOCaSo2ZwL+aU?=
 =?us-ascii?Q?Y1Xb9z46hEU5RgyamWAxFhyt+t9rUmmFvgCvJq4Osib7xhFUeExnUAQjSQWD?=
 =?us-ascii?Q?ER6+172+8GptPRL3N4tbz41NEhQZdFEWqFst/VBozrrLwWBSOv5mScUm/YZS?=
 =?us-ascii?Q?qEolJM5c22BIErYF8AQqb//SDqqplngJ7NP/ouCPk0j22fHAECkRxwz0XwLc?=
 =?us-ascii?Q?boaXONlcCZVzutrGgVRF132w9f1MauWzAVDZY9Z8De/2HgvVcf5Q2HJ5T1D2?=
 =?us-ascii?Q?zM5YWp6iq8KK1lUFvn1gKyec29L+3tPYXFpDe3xQYHv2DunPi7S2yLTGdeE1?=
 =?us-ascii?Q?pC5bEXxy0jgrC2gHcx7r3sDgn/b+KZSbreuKSaUnkxBNdBUxoXHPjQBFl5j9?=
 =?us-ascii?Q?JRmgGGxoQHYQ0jPTj0vc2gMGPvS9g66c1m06EK2pG6RTjQFXsVeUedHRa0MS?=
 =?us-ascii?Q?nC+gHJ0Gem1Yv40c/A7OEp2pLMDgno30P7T5+WXg7/Oyuui3RUUFQPcL45sr?=
 =?us-ascii?Q?HfIt/Ipevs2EduI/DsmIB+jaxhAEHscb+pWC7Ah1j7jhMmVCBfvX0/2f2BNn?=
 =?us-ascii?Q?qoAwv64YALCqVY8Tsct9HdXJQ7wy3ekJxqNQfGDDA2u9XmOvFtbX8PimbJy6?=
 =?us-ascii?Q?6wLlBLqKQLXLZd0qSqCC2qQRe5v3fiMi+vaiDKCGZTAWPkR8t9xISv5wx3zw?=
 =?us-ascii?Q?3KHtb9IE6D02Ljo8vg489FrsT4uNRYedAg2XwlykfjIUWakEF3ZKoxqR3jIf?=
 =?us-ascii?Q?0Z0uqCbdqeY7JRF3H49X1QAfV5eMT7k8i7Sf7tFz5I8QIU2lFv5T1zcPb+6I?=
 =?us-ascii?Q?xPiTu6ffVCbkGJlrgrk6mYFwL32O8EdYj0y4VhwJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b01447a-636a-4e9a-cc8e-08db20b565c0
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1418.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 15:46:07.3860
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CizcRvCa2cdGYaC+Eg+4TC2cJBNL5RsdNkaJnXC2N1VoNtCF9l4AwMfcu54gb+q5hB5XS9li7tILLTA6ndUW4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6536
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 09, 2023 at 11:06:25AM +0100, Andi Shyti wrote:
> On Thu, Mar 09, 2023 at 10:41:05AM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Mar 09, 2023 at 05:31:44PM +0800, Ye, Xiang wrote:
> > > On Thu, Mar 09, 2023 at 08:52:24AM +0100, Greg Kroah-Hartman wrote:
> > > > On Thu, Mar 09, 2023 at 03:10:56PM +0800, Ye Xiang wrote:
> > > > > +static int ljca_mng_get_version(struct ljca_stub *stub, char *buf)
> > > > > +{
> > > > > +	struct fw_version version = {};
> > > > > +	unsigned int len = sizeof(version);
> > > > > +	int ret;
> > > > > +
> > > > > +	ret = ljca_stub_write(stub, LJCA_MNG_GET_VERSION, NULL, 0, &version, &len, true,
> > > > > +			      LJCA_USB_WRITE_ACK_TIMEOUT_MS);
> > > > > +	if (ret)
> > > > > +		return ret;
> > > > > +
> > > > > +	if (len != sizeof(version)) {
> > > > > +		dev_err(&stub->intf->dev, "get version failed, len:%d\n", len);
> > > > > +		return -EINVAL;
> > > > > +	}
> > > > > +
> > > > > +	return sysfs_emit(buf, "%d.%d.%d.%d\n", version.major, version.minor,
> > > > > +			  le16_to_cpu(version.patch), le16_to_cpu(version.build));
> > > > > +}
> > > > 
> > > > You have sysfs files, yet no Documentation/ABI/ entries?  That's not
> > > > allowed, you know this :(
> > > The Documentation/ABI/ entries is added for the sysfs on patch 5 of this series.
> > > https://patchwork.kernel.org/project/linux-usb/patch/20230309071100.2856899-6-xiang.ye@intel.com/
> > 
> > Ah, missed that, sorry.
> > 
> > > > 
> > > > > +static ssize_t cmd_store(struct device *dev, struct device_attribute *attr, const char *buf,
> > > > > +			 size_t count)
> > > > > +{
> > > > > +	struct usb_interface *intf = to_usb_interface(dev);
> > > > > +	struct ljca_dev *ljca_dev = usb_get_intfdata(intf);
> > > > > +	struct ljca_stub *mng_stub = ljca_stub_find(ljca_dev, LJCA_MNG_STUB);
> > > > > +	struct ljca_stub *diag_stub = ljca_stub_find(ljca_dev, LJCA_DIAG_STUB);
> > > > > +
> > > > > +	if (sysfs_streq(buf, "dfu"))
> > > > > +		ljca_mng_set_dfu_mode(mng_stub);
> > > > > +	else if (sysfs_streq(buf, "debug"))
> > > > > +		ljca_diag_set_trace_level(diag_stub, 3);
> > > > 
> > > > Sorry, but no, you can't do this in a sysfs file.
> > > Do you mean that we can't use sysfs to send "debug" command to device?
> > 
> > That is correct, use the kernel-wide debugging facilities that we have
> > for this NEVER create your own custom interface just for one tiny
> > driver, that is not allowed.
> > 
> > > Could you provide some detail or hints?
> > 
> > dev_dbg().
But, this command is sent to SET LJCA Firmware logging level.
> 
> I'm not sure this is the same thing, though, as it's not a drvier
> to user debug message.
> 
> Ye, can you please explain better what this command does? You are
> sending a LJCA_DIAG_SET_TRACE_LEVEL command to the device with a
> parameter "3" which has a meaining only for you :)
Sure, the LJCA_DIAG_SET_TRACE_LEVEL command is used to set LJCA FW
logging level. 3 means debug level for FW. It is used for LJCA FW
debugging: when FW got some issue, we can send debug level to FW
to make FW print degging log for analysis.
> 
> What is ugly here is the parsing of "dfu" and "debug", I would
> just make different boolean files, something like:
> 
>  echo 1 > ljca_dfu
>  echo 0 > ljca_dfu
> 
> and
> 
>  echo N > ljca_trace_level
> 
> with a proper documentation of the trace levels.
> 
> The show counterparast can provide a feedback on how the
> interfaces are set rather than providing some help message, which
> is not what sysfs files are meant for.
> 
> Would this work?
Thanks. It should works, and I will try it.


--
Thanks
Ye Xiang